dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ladybird/Libraries/LibWeb/CSS/CSSImportRule.h

90 lines
3.1 KiB
C
Raw Permalink Normal View History

LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 13:36:34 -03:00
/*
* Copyright (c) 2021, the SerenityOS developers.
LibWeb/CSS: Wait for resources to load to fire `<style>` load event Previously, we fired the load event immediately, without waiting for anything. This was good for not timing out, but bad for anything that wanted to wait for the load to complete. CSSStyleSheet now maintains a list of critical subresources, and waits for all of them to complete before it then tells its owner that it is ready. "Complete" here means the network request completed with or without an error. This is done by having those subresources (just `@import` for now) notify their style sheet when they complete. This then propagates up as an `@import` tells its style sheet, which then would tell its parent `@import` if it had one. There are other subresources we should wait for (specifically fonts and background images) but this commit just adds `@import` as a first step.
2026-02-05 14:40:15 -03:00
* Copyright (c) 2021-2026, Sam Atkins <sam@ladybird.org>
Meta: Update my e-mail address everywhere
2024-10-04 08:19:50 -03:00
* Copyright (c) 2022, Andreas Kling <andreas@ladybird.org>
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 13:36:34 -03:00
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 05:24:48 -03:00
* SPDX-License-Identifier: BSD-2-Clause
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 13:36:34 -03:00
*/
#pragma once
#include <LibWeb/CSS/CSSRule.h>
LibWeb: Resolve cyclic dependency between StyleSheet and ImportRule Previously: CSSImportRule::loaded_style_sheet() (and others) depend on the definition of class CSSStyleSheet. Meanwhile, CSSStyleSheet::template for_each_effective_style_rule (and others) depend on the definition of class CSSImportRule. This hasn't caused any problems so far because CSSStyleSheet.h happened to be always included after CSSImportRule.h (in part due to alphabetical ordering). However, a compilation unit that (for example) only contains #include <Userland/Libraries/LibWeb/CSSImportRule.h> would fail to compile. This patch resolves this issue by pushing the inline definition of Web::CSS::CSSStyleSheet::for_each_effective_style_rule and for_first_not_loaded_import_rule into a different file, and adding the missing headers.
2021-09-30 17:57:35 -03:00
#include <LibWeb/CSS/CSSStyleSheet.h>
LibWeb: Parse scoped CSS import rules Parse and store the optional `scope` clause in `@import` preludes. WPT doesn't directly test the serialization behaviour for this, so add a custom test for it.
2026-05-29 13:16:12 -03:00
#include <LibWeb/CSS/Selector.h>
LibWeb/CSS: Don't resolve `@import` URLs until they are used The regression in the "conditional-CSSGroupingRule" test is we now fail the "inserting an `@import`" subtests differently and the subtests aren't independent. Specifically, we don't yet implement the checks in `CSSRuleList::insert_a_css_rule()` that reject certain rules from being inserted. Previously we didn't insert the `@import` rule because we failed to parse its relative URL. Now we parse it correctly, we end up inserting it.
2025-04-08 14:16:38 -03:00
#include <LibWeb/CSS/URL.h>
LibWeb: Enable EXPLICIT_SYMBOL_EXPORT
2025-07-19 23:35:33 -03:00
#include <LibWeb/Export.h>
LibGfx+LibWeb: Fix compile errors in clang-cl from recent header cleanup The recent commits 28ba610f325aaed5d20daebdd3cf732a04e62eaf and 70c4ed261fb446fe25396164400d09e0c0df8bc6 adjusted some include directives to avoid excessive recompilation when changing some header files. This has broken compilation with clang-cl on Windows without getting noticed before the PRs were merged.
2025-11-29 06:16:38 -03:00
#include <LibWeb/Forward.h>
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 13:36:34 -03:00
namespace Web::CSS {
LibWeb: Enable EXPLICIT_SYMBOL_EXPORT
2025-07-19 23:35:33 -03:00
class WEB_API CSSImportRule final
LibWeb/CSS: Wait for resources to load to fire `<style>` load event Previously, we fired the load event immediately, without waiting for anything. This was good for not timing out, but bad for anything that wanted to wait for the load to complete. CSSStyleSheet now maintains a list of critical subresources, and waits for all of them to complete before it then tells its owner that it is ready. "Complete" here means the network request completed with or without an error. This is done by having those subresources (just `@import` for now) notify their style sheet when they complete. This then propagates up as an `@import` tells its style sheet, which then would tell its parent `@import` if it had one. There are other subresources we should wait for (specifically fonts and background images) but this commit just adds `@import` as a first step.
2026-02-05 14:40:15 -03:00
: public CSSRule
, public CSSStyleSheet::Subresource {
LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated This is a monster patch that turns all EventTargets into GC-allocated PlatformObjects. Their C++ wrapper classes are removed, and the LibJS garbage collector is now responsible for their lifetimes. There's a fair amount of hacks and band-aids in this patch, and we'll have a lot of cleanup to do after this.
2022-08-28 08:42:07 -03:00
WEB_PLATFORM_OBJECT(CSSImportRule, CSSRule);
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-14 12:01:23 -03:00
GC_DECLARE_ALLOCATOR(CSSImportRule);
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 13:36:34 -03:00
public:
LibWeb: Parse scoped CSS import rules Parse and store the optional `scope` clause in `@import` preludes. WPT doesn't directly test the serialization behaviour for this, so add a custom test for it.
2026-05-29 13:16:12 -03:00
struct ImportScope {
Optional<SelectorList> start_selectors;
Optional<SelectorList> end_selectors;
};
[[nodiscard]] static GC::Ref<CSSImportRule> create(JS::Realm&, URL, GC::Ptr<DOM::Document>, Optional<FlyString> layer, Optional<ImportScope>&& scope, RefPtr<Supports>, GC::Ref<MediaList>);
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 13:36:34 -03:00
LibWeb/CSS: Wait for resources to load to fire `<style>` load event Previously, we fired the load event immediately, without waiting for anything. This was good for not timing out, but bad for anything that wanted to wait for the load to complete. CSSStyleSheet now maintains a list of critical subresources, and waits for all of them to complete before it then tells its owner that it is ready. "Complete" here means the network request completed with or without an error. This is done by having those subresources (just `@import` for now) notify their style sheet when they complete. This then propagates up as an `@import` tells its style sheet, which then would tell its parent `@import` if it had one. There are other subresources we should wait for (specifically fonts and background images) but this commit just adds `@import` as a first step.
2026-02-05 14:40:15 -03:00
virtual ~CSSImportRule() override;
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 13:36:34 -03:00
LibWeb/CSS: Don't resolve `@import` URLs until they are used The regression in the "conditional-CSSGroupingRule" test is we now fail the "inserting an `@import`" subtests differently and the subtests aren't independent. Specifically, we don't yet implement the checks in `CSSRuleList::insert_a_css_rule()` that reject certain rules from being inserted. Previously we didn't insert the `@import` rule because we failed to parse its relative URL. Now we parse it correctly, we end up inserting it.
2025-04-08 14:16:38 -03:00
URL const& url() const { return m_url; }
String href() const { return m_url.url(); }
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 13:36:34 -03:00
LibWeb: Make CSSRule and all its subclasses GC-allocated
2022-08-07 10:46:44 -03:00
CSSStyleSheet* loaded_style_sheet() { return m_style_sheet; }
CSSStyleSheet const* loaded_style_sheet() const { return m_style_sheet; }
LibWeb/CSS: Make CSSImportRule.media return its own MediaList ...instead of returning the one from its associated style sheet. This reverts 848a250b29f4581eb2ce486109d0697137d05a42 where I made `CSSImportRule.media` nullable. CSSImportRule may not have an associated style sheet, because of not matching a supports condition, or just failing to load the URL. Regardless of whether we do or not, the expected (non-spec) behaviour is that we should return a MediaList always, which matches the media queries specified on the `@import` rule.
2025-12-04 13:48:19 -03:00
GC::Ref<MediaList> media() const;
LibWeb: Make CSSRule and all its subclasses GC-allocated
2022-08-07 10:46:44 -03:00
CSSStyleSheet* style_sheet_for_bindings() { return m_style_sheet; }
LibWeb: Add actual document loading for the CSS (at)import rule
2021-02-21 13:44:17 -03:00
LibWeb/CSS: Implement CSSImportRule.layerName IDL attribute
2025-12-02 09:38:16 -03:00
Optional<FlyString> layer_name() const;
LibWeb: Implement `CSSImportRule.supportsText` Returns the supports condition specified by the given import at-rule.
2025-03-19 08:32:34 -03:00
Optional<String> supports_text() const;
LibWeb/CSS: Assign layers to `@import` statements Specifically, we create and assign a layer if its import conditions currently apply. With this change, every case in the `layer-import.html` test actually functions correctly, apart from our lack of proper `load` event support. (Tested by hacking in a 100ms wait after the `await Promise()` statement.)
2025-12-04 11:34:28 -03:00
bool matches() const;
LibWeb: Parse scoped CSS import rules Parse and store the optional `scope` clause in `@import` preludes. WPT doesn't directly test the serialization behaviour for this, so add a custom test for it.
2026-05-29 13:16:12 -03:00
bool has_scope() const { return m_scope.has_value(); }
Optional<SelectorList> const& scope_start_selectors() const;
Optional<SelectorList> const& scope_end_selectors() const;
LibWeb: Apply scopes from imported stylesheets Treat a scoped `@import` rule as a scope descriptor while traversing style-producing rules from imported stylesheets. Imported rules now inherit an outer scope for unscoped imports and replace it when the import itself carries scope(...). Scope resolution was generalized to handle both CSSScopeRule and CSSImportRule descriptors. Import-scope boundaries are matched using the stylesheet that parsed the `@import` rule, while normal imported selectors keep using the imported stylesheet context. This lets implicit scopes, nested `@scope` rules, :scope, and top-level `&` behave as the Cascade 6 model requires.
2026-06-04 13:22:45 -03:00
Optional<SelectorList> const& scope_start_selectors_for_matching() const;
Optional<SelectorList> const& scope_end_selectors_for_matching() const;
LibWeb/CSS: Assign layers to `@import` statements Specifically, we create and assign a layer if its import conditions currently apply. With this change, every case in the `layer-import.html` test actually functions correctly, apart from our lack of proper `load` event support. (Tested by hacking in a 100ms wait after the `await Promise()` statement.)
2025-12-04 11:34:28 -03:00
Optional<FlyString> internal_layer_name() const { return m_layer_internal; }
Optional<FlyString> internal_qualified_layer_name(Badge<StyleScope>) const;
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 13:36:34 -03:00
private:
LibWeb: Parse scoped CSS import rules Parse and store the optional `scope` clause in `@import` preludes. WPT doesn't directly test the serialization behaviour for this, so add a custom test for it.
2026-05-29 13:16:12 -03:00
CSSImportRule(JS::Realm&, URL, GC::Ptr<DOM::Document>, Optional<FlyString>, Optional<ImportScope>&&, RefPtr<Supports>, GC::Ref<MediaList>);
LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated This is a monster patch that turns all EventTargets into GC-allocated PlatformObjects. Their C++ wrapper classes are removed, and the LibJS garbage collector is now responsible for their lifetimes. There's a fair amount of hacks and band-aids in this patch, and we'll have a lot of cleanup to do after this.
2022-08-28 08:42:07 -03:00
LibJS: Make Cell::initialize() return void Stop worrying about tiny OOMs. Work towards #20405
2023-08-07 03:41:28 -03:00
virtual void initialize(JS::Realm&) override;
LibWeb: Make CSSRule and all its subclasses GC-allocated
2022-08-07 10:46:44 -03:00
virtual void visit_edges(Cell::Visitor&) override;
LibWeb: Apply scopes from imported stylesheets Treat a scoped `@import` rule as a scope descriptor while traversing style-producing rules from imported stylesheets. Imported rules now inherit an outer scope for unscoped imports and replace it when the import itself carries scope(...). Scope resolution was generalized to handle both CSSScopeRule and CSSImportRule descriptors. Import-scope boundaries are matched using the stylesheet that parsed the `@import` rule, while normal imported selectors keep using the imported stylesheet context. This lets implicit scopes, nested `@scope` rules, :scope, and top-level `&` behave as the Cascade 6 model requires.
2026-06-04 13:22:45 -03:00
virtual void clear_caches() override;
LibWeb: Move CSSRule dumping code into CSSRule classes Having the dumping code in a separate Dump.cpp meant that it was often overlooked when the rules gained new features, and also limits dumping to publicly-accessible information.
2025-12-04 09:03:01 -03:00
virtual void dump(StringBuilder&, int indent_levels) const override;
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 13:36:34 -03:00
LibWeb/CSS: Use fetch for CSS import rules This still has a few FIXMEs, but it's a ResourceLoader use gone! :^)
2024-12-20 17:25:40 -03:00
virtual void set_parent_style_sheet(CSSStyleSheet*) override;
LibWeb/CSS: Wait for resources to load to fire `<style>` load event Previously, we fired the load event immediately, without waiting for anything. This was good for not timing out, but bad for anything that wanted to wait for the load to complete. CSSStyleSheet now maintains a list of critical subresources, and waits for all of them to complete before it then tells its owner that it is ready. "Complete" here means the network request completed with or without an error. This is done by having those subresources (just `@import` for now) notify their style sheet when they complete. This then propagates up as an `@import` tells its style sheet, which then would tell its parent `@import` if it had one. There are other subresources we should wait for (specifically fonts and background images) but this commit just adds `@import` as a first step.
2026-02-05 14:40:15 -03:00
virtual GC::Ptr<CSSStyleSheet> parent_style_sheet_for_subresource() override { return m_parent_style_sheet; }
LibWeb: Port CSSRule::serialized from DeprecatedString to String
2023-11-20 07:16:39 -03:00
virtual String serialized() const override;
LibWeb: Implement CSSRule and CSSStyleDeclaration serialization There are a handful of FIXME's here, but this seems generally good. Note that CSS *values* don't get serialized in a spec-compliant way since we currently rely on StyleValue::to_string() which is ad-hoc.
2021-10-01 14:57:45 -03:00
LibWeb/CSS: Use fetch for CSS import rules This still has a few FIXMEs, but it's a ResourceLoader use gone! :^)
2024-12-20 17:25:40 -03:00
void fetch();
void set_style_sheet(GC::Ref<CSSStyleSheet>);
LibWeb: Make `@import` rules functional again :^) The changes in commit d462a6720afe721b6821ce14d5b7802d1890b61f meant that `CSSLoader::load_next_import_if_needed()` was no longer being called, so no `@import` rules were loading. The spec does not seem to mention when that loading should take place, but WebKit does this at parse time, as each rule is added to the style sheet. If it works for them, it's probably not that bad. :^) So, that's what we now do here. The `CSSImportRule` creates a fetch request when it is constructed, so each one is responsible for its own contents.
2021-11-18 14:34:53 -03:00
LibWeb/CSS: Don't resolve `@import` URLs until they are used The regression in the "conditional-CSSGroupingRule" test is we now fail the "inserting an `@import`" subtests differently and the subtests aren't independent. Specifically, we don't yet implement the checks in `CSSRuleList::insert_a_css_rule()` that reject certain rules from being inserted. Previously we didn't insert the `@import` rule because we failed to parse its relative URL. Now we parse it correctly, we end up inserting it.
2025-04-08 14:16:38 -03:00
URL m_url;
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-14 12:01:23 -03:00
GC::Ptr<DOM::Document> m_document;
LibWeb/CSS: Parse layer in `@import` rules
2025-12-04 11:15:07 -03:00
Optional<FlyString> m_layer;
LibWeb/CSS: Assign layers to `@import` statements Specifically, we create and assign a layer if its import conditions currently apply. With this change, every case in the `layer-import.html` test actually functions correctly, apart from our lack of proper `load` event support. (Tested by hacking in a 100ms wait after the `await Promise()` statement.)
2025-12-04 11:34:28 -03:00
Optional<FlyString> m_layer_internal;
LibWeb: Parse scoped CSS import rules Parse and store the optional `scope` clause in `@import` preludes. WPT doesn't directly test the serialization behaviour for this, so add a custom test for it.
2026-05-29 13:16:12 -03:00
Optional<ImportScope> m_scope;
LibWeb: Apply scopes from imported stylesheets Treat a scoped `@import` rule as a scope descriptor while traversing style-producing rules from imported stylesheets. Imported rules now inherit an outer scope for unscoped imports and replace it when the import itself carries scope(...). Scope resolution was generalized to handle both CSSScopeRule and CSSImportRule descriptors. Import-scope boundaries are matched using the stylesheet that parsed the `@import` rule, while normal imported selectors keep using the imported stylesheet context. This lets implicit scopes, nested `@scope` rules, :scope, and top-level `&` behave as the Cascade 6 model requires.
2026-06-04 13:22:45 -03:00
mutable Optional<SelectorList> m_cached_scope_start_selectors_for_matching;
mutable Optional<SelectorList> m_cached_scope_end_selectors_for_matching;
LibWeb/CSS: Implement import at-rule supports conditions This indicates the features the browser must support for the given stylesheet to be fetched.
2025-03-19 08:23:33 -03:00
RefPtr<Supports> m_supports;
LibWeb/CSS: Make CSSImportRule.media return its own MediaList ...instead of returning the one from its associated style sheet. This reverts 848a250b29f4581eb2ce486109d0697137d05a42 where I made `CSSImportRule.media` nullable. CSSImportRule may not have an associated style sheet, because of not matching a supports condition, or just failing to load the URL. Regardless of whether we do or not, the expected (non-spec) behaviour is that we should return a MediaList always, which matches the media queries specified on the `@import` rule.
2025-12-04 13:48:19 -03:00
GC::Ref<MediaList> m_media;
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-14 12:01:23 -03:00
GC::Ptr<CSSStyleSheet> m_style_sheet;
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 13:36:34 -03:00
};
LibWeb: Add fast_is<T> for CSSRule subclasses Since we already have a type enum for these, let's use it to make is<T> bypass dynamic_cast for CSS rules. These were often near the top of random browser profiles.
2021-03-18 17:50:52 -03:00
template<>
inline bool CSSRule::fast_is<CSSImportRule>() const { return type() == CSSRule::Type::Import; }
LibWeb: Added simple parsing for (at)import rules For now, the parsing is very crude, and parses only the document url. The meta queries for the import are ignored.
2021-02-21 13:36:34 -03:00
}
Reference in a new issue Copy permalink