ladybird/Tests/LibWeb/Text/input/input-commit.html

<!DOCTYPE html>
<input id=input type=text>
<script src="include.js"></script>
<script>
    test(() => {
        let input = document.getElementById("input");

        input.addEventListener("change", () => {
            println(input.value);
        });

        internals.sendText(input, "wfh :^)");
        internals.commitText();

        // A second commit should not result in a change event.
        internals.commitText();
    })
</script>
Meta: Add DOCTYPEs to most text tests 2025-03-18 15:28:35 -03:00			`<!DOCTYPE html>`
LibWeb: Support committing changes to <input> elements We currently fire the change event on <input> elements when they lose focus. The spec allows for us to also fire the event when changes are "committed", so long as such an action makes sense for the input type. This patch detects when the return key is entered in an <input> element and uses that as the commit action for text-related types. If no change has occurred since the last commit, no change event is fired. 2023-11-30 14:54:30 -03:00			`<input id=input type=text>`
			`<script src="include.js"></script>`
			`<script>`
LibWeb: Fire the `change` event synchronously when committing changes The spec does not say to do this asynchronously on a task queue. 2023-12-03 10:21:58 -03:00			`test(() => {`
LibWeb: Support committing changes to <input> elements We currently fire the change event on <input> elements when they lose focus. The spec allows for us to also fire the event when changes are "committed", so long as such an action makes sense for the input type. This patch detects when the return key is entered in an <input> element and uses that as the commit action for text-related types. If no change has occurred since the last commit, no change event is fired. 2023-11-30 14:54:30 -03:00			`let input = document.getElementById("input");`

			`input.addEventListener("change", () => {`
			`println(input.value);`
			`});`

			`internals.sendText(input, "wfh :^)");`
			`internals.commitText();`
LibWeb: Do not insert "return" key presses into input element values When the return key is pressed, we try to handle it as a commit action for input elements. However, we would then go on to actually insert the return key's code point (U+000D) into the input element. This would be sanitized out, but would leave the input element in a state where it thinks it has text to commit. This would result in a change event being fired when the return key is pressed multiple times in a row. We were also firing the beforeinput/input events twice for all return key presses. To fix this, this patch changes the input event target to signify if it actually handled the return key. If not (i.e. for textarea elements), only then do we insert the code point. We also must not fall through to the generic key handler, to avoid the repeated input events. 2025-03-21 12:35:42 -03:00
			`// A second commit should not result in a change event.`
			`internals.commitText();`
LibWeb: Support committing changes to <input> elements We currently fire the change event on <input> elements when they lose focus. The spec allows for us to also fire the event when changes are "committed", so long as such an action makes sense for the input type. This patch detects when the return key is entered in an <input> element and uses that as the commit action for text-related types. If no change has occurred since the last commit, no change event is fired. 2023-11-30 14:54:30 -03:00			`})`
			`</script>`