dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ladybird/Userland/Applications/PDFViewer/PDFViewerWidget.cpp

455 lines
17 KiB
C++
Raw Normal View History

Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
/*
LibPDF: Propagate errors in Parser and Document
2022-03-05 21:30:55 -03:00
* Copyright (c) 2021-2022, Matthew Olsson <mattco@serenityos.org>
Everywhere: Use my fancy new serenityos.org email :^)
2021-09-13 17:48:22 -03:00
* Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org>
Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include "PDFViewerWidget.h"
Everywhere: Fix badly-formatted includes In 7c5e30daaa615ad3a2ef55222423a747ac0a1227, the focus was "only" on Userland/Libraries/, whereas this commit cleans up the remaining headers in the repo, and any new badly-formatted include.
2023-01-02 11:15:14 -03:00
#include <AK/Assertions.h>
#include <AK/DeprecatedString.h>
#include <AK/Format.h>
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
#include <AK/HashMap.h>
#include <AK/HashTable.h>
#include <AK/Variant.h>
PDFViewer: Use FileSystemAccessClient to open files
2021-09-02 09:22:13 -03:00
#include <LibFileSystemAccessClient/Client.h>
Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
#include <LibGUI/Application.h>
#include <LibGUI/BoxLayout.h>
#include <LibGUI/FilePicker.h>
Everywhere: Fix badly-formatted includes In 7c5e30daaa615ad3a2ef55222423a747ac0a1227, the focus was "only" on Userland/Libraries/, whereas this commit cleans up the remaining headers in the repo, and any new badly-formatted include.
2023-01-02 11:15:14 -03:00
#include <LibGUI/Forward.h>
PDFViewer: Prompt password for encrypted documents This tackles a FIXME, but also makes sense to implement only now that the SecurityHandler logic has been fixed. When a Document is created an automatic attempt is made to provide the empty string as the password; even if this attempt failed the SecurityHandler still reported it had a user password, hence we never arrived to the VERIFY_NOT_REQUIRED line this commit is changing.
2022-12-20 03:15:56 -03:00
#include <LibGUI/InputBox.h>
PDFViewer: Add a toolbar The toolbar has an option to toggle the sidebar, a number input to set the current page, and two buttons to go up and down by one page
2021-05-24 02:34:44 -03:00
#include <LibGUI/Label.h>
Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
#include <LibGUI/Menu.h>
#include <LibGUI/Menubar.h>
PDFViewer: Display error dialog if necessary instead of crashing
2021-05-24 18:23:08 -03:00
#include <LibGUI/MessageBox.h>
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
#include <LibGUI/Model.h>
#include <LibGUI/SortingProxyModel.h>
PDFViewer: Add a tab bar with outlines and thumbnails Outlines are in theory implemented (though I'm having trouble finding a simple PDF with outlines to test it on), and thumbnails are not.
2021-05-24 01:34:06 -03:00
#include <LibGUI/Splitter.h>
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
#include <LibGUI/TableView.h>
PDFViewer: Add a toolbar The toolbar has an option to toggle the sidebar, a number input to set the current page, and two buttons to go up and down by one page
2021-05-24 02:34:44 -03:00
#include <LibGUI/Toolbar.h>
#include <LibGUI/ToolbarContainer.h>
Everywhere: Fix badly-formatted includes In 7c5e30daaa615ad3a2ef55222423a747ac0a1227, the focus was "only" on Userland/Libraries/, whereas this commit cleans up the remaining headers in the repo, and any new badly-formatted include.
2023-01-02 11:15:14 -03:00
#include <LibPDF/Document.h>
Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
class PagedErrorsModel : public GUI::Model {
enum Columns {
Page = 0,
Message,
_Count
};
using PageErrors = AK::OrderedHashTable<DeprecatedString>;
using PagedErrors = HashMap<u32, PageErrors>;
public:
int row_count(GUI::ModelIndex const& index) const override
{
// There are two levels: number of pages and number of errors in page
if (!index.is_valid()) {
return static_cast<int>(m_paged_errors.size());
}
if (!index.parent().is_valid()) {
PDFViewer: Fix indexing error in ErrorsView I confused myself when implementing this, plus I tested using pages that had errors in pages 1 and 2, so the index and the number of the page (internally represented as 0-indexed) was always the same. When opening files with errors on higher pages it became evident that there was an issue with how I was reading the errors per page from the corresponding ModelIndex object.
2022-12-18 10:11:29 -03:00
return static_cast<int>(error_count_in_page(index));
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
}
return 0;
}
int column_count(GUI::ModelIndex const&) const override
{
return Columns::_Count;
}
int tree_column() const override
{
return Columns::Page;
}
LibGUI+Userland: Propagate errors in Model::column_name()
2023-06-13 12:30:15 -03:00
ErrorOr<String> column_name(int index) const override
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
{
switch (index) {
case 0:
Userland: Prefer `_string` over `_short_string` As `_string` can't fail anymore (since 3434412), there are no real benefits to use the short variant in most cases.
2023-08-07 23:26:17 -03:00
return "Page"_string;
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
case 1:
Userland: Prefer `_string` over `_short_string` As `_string` can't fail anymore (since 3434412), there are no real benefits to use the short variant in most cases.
2023-08-07 23:26:17 -03:00
return "Message"_string;
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
default:
VERIFY_NOT_REACHED();
}
}
GUI::ModelIndex index(int row, int column, GUI::ModelIndex const& parent) const override
{
if (!parent.is_valid()) {
return create_index(row, column);
}
auto const& page = m_pages_with_errors[parent.row()];
return create_index(row, column, &page);
}
GUI::ModelIndex parent_index(GUI::ModelIndex const& index) const override
{
auto* const internal_data = index.internal_data();
if (internal_data == nullptr)
return {};
auto page = *static_cast<u32 const*>(internal_data);
auto page_idx = static_cast<int>(m_pages_with_errors.find_first_index(page).release_value());
return create_index(page_idx, index.column());
}
virtual GUI::Variant data(GUI::ModelIndex const& index, GUI::ModelRole) const override
{
if (!index.parent().is_valid()) {
switch (index.column()) {
case Columns::Page:
return m_pages_with_errors[index.row()] + 1;
case Columns::Message:
PDFViewer: Fix indexing error in ErrorsView I confused myself when implementing this, plus I tested using pages that had errors in pages 1 and 2, so the index and the number of the page (internally represented as 0-indexed) was always the same. When opening files with errors on higher pages it became evident that there was an issue with how I was reading the errors per page from the corresponding ModelIndex object.
2022-12-18 10:11:29 -03:00
return DeprecatedString::formatted("{} errors", error_count_in_page(index));
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
default:
VERIFY_NOT_REACHED();
}
}
auto page = *static_cast<u32 const*>(index.internal_data());
switch (index.column()) {
case Columns::Page:
return "";
case Columns::Message: {
auto page_errors = m_paged_errors.get(page).release_value();
// dbgln("Errors on page {}: {}. Requesting data for index {},{}", page, page_errors.size(), index.row(), index.column());
auto it = page_errors.begin();
auto row = index.row();
for (int i = 0; i < row; ++i, ++it)
;
return *it;
}
}
VERIFY_NOT_REACHED();
}
void add_errors(u32 page, PDF::Errors const& errors)
{
auto old_size = total_error_count();
if (!m_pages_with_errors.contains_slow(page)) {
m_pages_with_errors.append(page);
}
auto& page_errors = m_paged_errors.ensure(page);
for (auto const& error : errors.errors())
page_errors.set(error.message());
auto new_size = total_error_count();
if (old_size != new_size)
invalidate();
}
private:
size_t total_error_count() const
{
size_t count = 0;
for (auto const& entry : m_paged_errors)
count += entry.value.size();
return count;
}
PDFViewer: Fix indexing error in ErrorsView I confused myself when implementing this, plus I tested using pages that had errors in pages 1 and 2, so the index and the number of the page (internally represented as 0-indexed) was always the same. When opening files with errors on higher pages it became evident that there was an issue with how I was reading the errors per page from the corresponding ModelIndex object.
2022-12-18 10:11:29 -03:00
size_t error_count_in_page(GUI::ModelIndex const& index) const
{
VERIFY(!index.parent().is_valid());
auto page = m_pages_with_errors[index.row()];
return m_paged_errors.get(page).release_value().size();
}
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
Vector<u32> m_pages_with_errors;
PagedErrors m_paged_errors;
};
Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
PDFViewerWidget::PDFViewerWidget()
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
: m_paged_errors_model(adopt_ref(*new PagedErrorsModel()))
Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
{
set_fill_with_background_color(true);
set_layout<GUI::VerticalBoxLayout>();
PDFViewer: Add page mode option
2022-03-29 01:19:45 -03:00
auto& toolbar_container = add<GUI::ToolbarContainer>();
auto& toolbar = toolbar_container.add<GUI::Toolbar>();
PDFViewer: Add a toolbar The toolbar has an option to toggle the sidebar, a number input to set the current page, and two buttons to go up and down by one page
2021-05-24 02:34:44 -03:00
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
auto& h_splitter = add<GUI::HorizontalSplitter>();
h_splitter.layout()->set_spacing(4);
Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
m_sidebar = h_splitter.add<SidebarWidget>();
Applications+DevTools: Remove fixed sizes from Splitters And adjust some GML properties. Since a808cfa, splitters grow opportunistically. Setting them to fixed sizes now quite literally fixes them in place. Fixes immovable splitters missed in the aforementioned commit.
2022-08-30 08:38:20 -03:00
m_sidebar->set_preferred_width(200);
m_sidebar->set_visible(false);
PDFViewer: Move to page when outline item is selected
2022-12-17 09:41:59 -03:00
m_sidebar->on_destination_selected = [&](PDF::Destination const& destination) {
auto maybe_page = destination.page;
if (!maybe_page.has_value())
return;
auto page = maybe_page.release_value();
m_viewer->set_current_page(page);
};
PDFViewer: Add a tab bar with outlines and thumbnails Outlines are in theory implemented (though I'm having trouble finding a simple PDF with outlines to test it on), and thumbnails are not.
2021-05-24 01:34:06 -03:00
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
auto& v_splitter = h_splitter.add<GUI::VerticalSplitter>();
v_splitter.layout()->set_spacing(4);
m_viewer = v_splitter.add<PDFViewer>();
PDFViewer: Update the page number when scrolling between pages
2021-06-20 16:07:44 -03:00
m_viewer->on_page_change = [&](auto new_page) {
PDFViewer: Respect page navigation features in multi-page mode This includes the text box and the page up/down arrows.
2022-03-31 22:01:07 -03:00
m_page_text_box->set_current_number(new_page + 1, GUI::AllowCallback::No);
PDFViewer: Toggle prev/next page actions when page changes These actions were not updated accordingly when one scrolled through the document, and thus one could accidentally, for example, move to the next page when standing on the last, which caused a crash. This commit fixes that behavior, toggling the actions' enabled status depending on the new page being displayed.
2022-11-23 10:21:52 -03:00
m_go_to_prev_page_action->set_enabled(new_page > 0);
m_go_to_next_page_action->set_enabled(new_page < m_viewer->document()->get_page_count() - 1);
PDFViewer: Update the page number when scrolling between pages
2021-06-20 16:07:44 -03:00
};
PDFViewer: Add TreeView to communicate rendering errors Now that the rendering process communicates all errors upstream, and PDFViewer has a way to tap into those errors as they occur, we can visualise them more neatly. This commit adds a TreeView that we populate with the errors stemming from the rendering process. The TreeView has two levels: at the top sit pages where errors can be found, and under each page we can see the errors that have been found on that page. The TreeView sits below the main PDF rendering.
2022-12-14 12:13:13 -03:00
m_viewer->on_render_errors = [&](u32 page, PDF::Errors const& errors) {
verify_cast<PagedErrorsModel>(m_paged_errors_model.ptr())->add_errors(page, errors);
};
m_errors_tree_view = v_splitter.add<GUI::TreeView>();
m_errors_tree_view->set_preferred_height(10);
m_errors_tree_view->column_header().set_visible(true);
m_errors_tree_view->set_should_fill_selected_rows(true);
m_errors_tree_view->set_selection_behavior(GUI::AbstractView::SelectionBehavior::SelectRows);
m_errors_tree_view->set_model(MUST(GUI::SortingProxyModel::create(m_paged_errors_model)));
m_errors_tree_view->set_key_column(0);
PDFViewer: Add page mode option
2022-03-29 01:19:45 -03:00
initialize_toolbar(toolbar);
Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
}
PDFViewer: Propagate errors from `PDFViewerWidget::initialize_menubar()`
2023-04-16 09:50:45 -03:00
ErrorOr<void> PDFViewerWidget::initialize_menubar(GUI::Window& window)
Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
{
LibGUI: Remove Window::try_add_menu() And fall back to the infallible add_menu().
2023-08-14 05:44:42 -03:00
auto file_menu = window.add_menu("&File"_string);
LibGUI: Remove Menu::try_add_action() And fall back to the infallible add_action().
2023-08-14 05:14:27 -03:00
file_menu->add_action(GUI::CommonActions::make_open_action([&](auto&) {
Userland: Filter out unsupported file types in open dialogs in more apps
2023-05-28 12:57:02 -03:00
FileSystemAccessClient::OpenFileOptions options {
.allowed_file_types = Vector {
GUI::FileTypeFilter { "PDF Files", { { "pdf" } } },
GUI::FileTypeFilter::all_files(),
},
};
auto response = FileSystemAccessClient::Client::the().open_file(&window, options);
PDFViewer: Add page mode option
2022-03-29 01:19:45 -03:00
if (!response.is_error())
PDFViewer: Port to Core::Stream::File
2023-01-09 17:28:05 -03:00
open_file(response.value().filename(), response.value().release_stream());
LibGUI: Remove Menu::try_add_action() And fall back to the infallible add_action().
2023-08-14 05:14:27 -03:00
}));
LibGUI: Remove Menu::try_add_separator() And fall back to the infallible add_separator().
2023-08-14 02:19:40 -03:00
file_menu->add_separator();
LibGUI: Make Menu::add_recent_files_list() infallible
2023-08-14 05:16:18 -03:00
file_menu->add_recent_files_list([&](auto& action) {
PDFViewer: Propagate errors from `PDFViewerWidget::initialize_menubar()`
2023-04-16 09:50:45 -03:00
auto response = FileSystemAccessClient::Client::the().request_file_read_only_approved(&window, action.text());
if (!response.is_error())
open_file(response.value().filename(), response.value().release_stream());
LibGUI: Make Menu::add_recent_files_list() infallible
2023-08-14 05:16:18 -03:00
});
LibGUI: Remove Menu::try_add_action() And fall back to the infallible add_action().
2023-08-14 05:14:27 -03:00
file_menu->add_action(GUI::CommonActions::make_quit_action([](auto&) {
Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
GUI::Application::the()->quit();
LibGUI: Remove Menu::try_add_action() And fall back to the infallible add_action().
2023-08-14 05:14:27 -03:00
}));
PDFViewer: Propagate errors from `PDFViewerWidget::initialize_menubar()`
2023-04-16 09:50:45 -03:00
LibGUI: Remove Window::try_add_menu() And fall back to the infallible add_menu().
2023-08-14 05:44:42 -03:00
auto view_menu = window.add_menu("&View"_string);
LibGUI: Remove Menu::try_add_action() And fall back to the infallible add_action().
2023-08-14 05:14:27 -03:00
view_menu->add_action(*m_toggle_sidebar_action);
LibGUI: Remove Menu::try_add_separator() And fall back to the infallible add_separator().
2023-08-14 02:19:40 -03:00
view_menu->add_separator();
LibGUI: Remove Menu::try_add_submenu() And fall back to the infallible add_submenu().
2023-08-14 04:04:41 -03:00
auto view_mode_menu = view_menu->add_submenu("View &Mode"_string);
LibGUI: Remove Menu::try_add_action() And fall back to the infallible add_action().
2023-08-14 05:14:27 -03:00
view_mode_menu->add_action(*m_page_view_mode_single);
view_mode_menu->add_action(*m_page_view_mode_multiple);
LibGUI: Remove Menu::try_add_separator() And fall back to the infallible add_separator().
2023-08-14 02:19:40 -03:00
view_menu->add_separator();
LibGUI: Remove Menu::try_add_action() And fall back to the infallible add_action().
2023-08-14 05:14:27 -03:00
view_menu->add_action(*m_zoom_in_action);
view_menu->add_action(*m_zoom_out_action);
view_menu->add_action(*m_reset_zoom_action);
PDFViewer: Propagate errors from `PDFViewerWidget::initialize_menubar()`
2023-04-16 09:50:45 -03:00
LibGUI: Remove Window::try_add_menu() And fall back to the infallible add_menu().
2023-08-14 05:44:42 -03:00
auto help_menu = window.add_menu("&Help"_string);
LibGUI: Remove Menu::try_add_action() And fall back to the infallible add_action().
2023-08-14 05:14:27 -03:00
help_menu->add_action(GUI::CommonActions::make_command_palette_action(&window));
LibGUI+Applications: Use String in `make_about_action()`
2023-09-13 16:34:46 -03:00
help_menu->add_action(GUI::CommonActions::make_about_action("PDF Viewer"_string, GUI::Icon::default_icon("app-pdf-viewer"sv), &window));
PDFViewer: Propagate errors from `PDFViewerWidget::initialize_menubar()`
2023-04-16 09:50:45 -03:00
return {};
PDFViewer: Add a toolbar The toolbar has an option to toggle the sidebar, a number input to set the current page, and two buttons to go up and down by one page
2021-05-24 02:34:44 -03:00
}
PDFViewer: Add a tab bar with outlines and thumbnails Outlines are in theory implemented (though I'm having trouble finding a simple PDF with outlines to test it on), and thumbnails are not.
2021-05-24 01:34:06 -03:00
PDFViewer: Add page mode option
2022-03-29 01:19:45 -03:00
void PDFViewerWidget::initialize_toolbar(GUI::Toolbar& toolbar)
PDFViewer: Add a toolbar The toolbar has an option to toggle the sidebar, a number input to set the current page, and two buttons to go up and down by one page
2021-05-24 02:34:44 -03:00
{
auto open_outline_action = GUI::Action::create(
LibGfx: Remove `try_` prefix from bitmap creation functions Those don't have any non-try counterpart, so we might as well just omit it.
2023-01-20 16:06:05 -03:00
"Toggle &Sidebar", { Mod_Ctrl, Key_S }, Gfx::Bitmap::load_from_file("/res/icons/16x16/sidebar.png"sv).release_value_but_fixme_should_propagate_errors(), [&](auto&) {
PDFViewer: Add a tab bar with outlines and thumbnails Outlines are in theory implemented (though I'm having trouble finding a simple PDF with outlines to test it on), and thumbnails are not.
2021-05-24 01:34:06 -03:00
m_sidebar_open = !m_sidebar_open;
PDFViewer: Remove unnecessary ternary operation
2022-12-14 13:47:48 -03:00
m_sidebar->set_visible(m_sidebar_open);
PDFViewer: Add a tab bar with outlines and thumbnails Outlines are in theory implemented (though I'm having trouble finding a simple PDF with outlines to test it on), and thumbnails are not.
2021-05-24 01:34:06 -03:00
},
nullptr);
PDFViewer: Add a toolbar The toolbar has an option to toggle the sidebar, a number input to set the current page, and two buttons to go up and down by one page
2021-05-24 02:34:44 -03:00
open_outline_action->set_enabled(false);
m_toggle_sidebar_action = open_outline_action;
toolbar.add_action(*open_outline_action);
toolbar.add_separator();
LibGfx: Remove `try_` prefix from bitmap creation functions Those don't have any non-try counterpart, so we might as well just omit it.
2023-01-20 16:06:05 -03:00
m_go_to_prev_page_action = GUI::Action::create("Go to &Previous Page", Gfx::Bitmap::load_from_file("/res/icons/16x16/go-up.png"sv).release_value_but_fixme_should_propagate_errors(), [&](auto&) {
PDFViewer: Enable previous/next buttons conditionally Instead of having both always enabled once a document is loaded, update them on each page change and disable if appropriate.
2021-05-27 14:47:44 -03:00
VERIFY(m_viewer->current_page() > 0);
m_page_text_box->set_current_number(m_viewer->current_page());
PDFViewer: Add a toolbar The toolbar has an option to toggle the sidebar, a number input to set the current page, and two buttons to go up and down by one page
2021-05-24 02:34:44 -03:00
});
m_go_to_prev_page_action->set_enabled(false);
PDFViewer: Add a tab bar with outlines and thumbnails Outlines are in theory implemented (though I'm having trouble finding a simple PDF with outlines to test it on), and thumbnails are not.
2021-05-24 01:34:06 -03:00
LibGfx: Remove `try_` prefix from bitmap creation functions Those don't have any non-try counterpart, so we might as well just omit it.
2023-01-20 16:06:05 -03:00
m_go_to_next_page_action = GUI::Action::create("Go to &Next Page", Gfx::Bitmap::load_from_file("/res/icons/16x16/go-down.png"sv).release_value_but_fixme_should_propagate_errors(), [&](auto&) {
PDFViewer: Enable previous/next buttons conditionally Instead of having both always enabled once a document is loaded, update them on each page change and disable if appropriate.
2021-05-27 14:47:44 -03:00
VERIFY(m_viewer->current_page() < m_viewer->document()->get_page_count() - 1);
m_page_text_box->set_current_number(m_viewer->current_page() + 2);
PDFViewer: Add a toolbar The toolbar has an option to toggle the sidebar, a number input to set the current page, and two buttons to go up and down by one page
2021-05-24 02:34:44 -03:00
});
m_go_to_next_page_action->set_enabled(false);
PDFViewer: Add a tab bar with outlines and thumbnails Outlines are in theory implemented (though I'm having trouble finding a simple PDF with outlines to test it on), and thumbnails are not.
2021-05-24 01:34:06 -03:00
PDFViewer: Add a toolbar The toolbar has an option to toggle the sidebar, a number input to set the current page, and two buttons to go up and down by one page
2021-05-24 02:34:44 -03:00
toolbar.add_action(*m_go_to_prev_page_action);
toolbar.add_action(*m_go_to_next_page_action);
m_page_text_box = toolbar.add<NumericInput>();
m_page_text_box->set_enabled(false);
m_page_text_box->set_fixed_width(30);
m_page_text_box->set_min_number(1);
m_page_text_box->on_number_changed = [&](i32 number) {
PDFViewer: Enable previous/next buttons conditionally Instead of having both always enabled once a document is loaded, update them on each page change and disable if appropriate.
2021-05-27 14:47:44 -03:00
auto page_count = m_viewer->document()->get_page_count();
auto new_page_number = static_cast<u32>(number);
VERIFY(new_page_number >= 1 && new_page_number <= page_count);
m_viewer->set_current_page(new_page_number - 1);
m_go_to_prev_page_action->set_enabled(new_page_number > 1);
m_go_to_next_page_action->set_enabled(new_page_number < page_count);
PDFViewer: Add a toolbar The toolbar has an option to toggle the sidebar, a number input to set the current page, and two buttons to go up and down by one page
2021-05-24 02:34:44 -03:00
};
m_total_page_label = toolbar.add<GUI::Label>();
PDFViewer: Autosize page label
2022-03-31 22:14:54 -03:00
m_total_page_label->set_autosize(true, 5);
PDFViewer: Add zoom in/out/reset menu actions Make PDFViewer::zoom_in() & ::zoom_out() public and add menu and toolbar actions. Also add an action for zoom reset.
2022-01-02 17:58:51 -03:00
toolbar.add_separator();
m_zoom_in_action = GUI::CommonActions::make_zoom_in_action([&](auto&) {
m_viewer->zoom_in();
});
m_zoom_out_action = GUI::CommonActions::make_zoom_out_action([&](auto&) {
m_viewer->zoom_out();
});
m_reset_zoom_action = GUI::CommonActions::make_reset_zoom_action([&](auto&) {
m_viewer->reset_zoom();
});
PDFViewer: Add actions to rotate the displayed PDF This implements the rotate cw/ccw actions in PDFViewer. Since the rendered pages are stored in a HashMap for caching, the bitmap is wrapped in a struct with the current rotation. This way the caching works as expected while zooming, and a new bitmap is rendered when the page is rotated.
2022-01-02 20:24:11 -03:00
m_rotate_counterclockwise_action = GUI::CommonActions::make_rotate_counterclockwise_action([&](auto&) {
m_viewer->rotate(-90);
});
m_rotate_clockwise_action = GUI::CommonActions::make_rotate_clockwise_action([&](auto&) {
m_viewer->rotate(90);
});
PDFViewer: Add zoom in/out/reset menu actions Make PDFViewer::zoom_in() & ::zoom_out() public and add menu and toolbar actions. Also add an action for zoom reset.
2022-01-02 17:58:51 -03:00
m_zoom_in_action->set_enabled(false);
m_zoom_out_action->set_enabled(false);
m_reset_zoom_action->set_enabled(false);
PDFViewer: Add actions to rotate the displayed PDF This implements the rotate cw/ccw actions in PDFViewer. Since the rendered pages are stored in a HashMap for caching, the bitmap is wrapped in a struct with the current rotation. This way the caching works as expected while zooming, and a new bitmap is rendered when the page is rotated.
2022-01-02 20:24:11 -03:00
m_rotate_counterclockwise_action->set_enabled(false);
m_rotate_clockwise_action->set_enabled(false);
PDFViewer: Add zoom in/out/reset menu actions Make PDFViewer::zoom_in() & ::zoom_out() public and add menu and toolbar actions. Also add an action for zoom reset.
2022-01-02 17:58:51 -03:00
PDFViewer: Add page mode option
2022-03-29 01:19:45 -03:00
m_page_view_mode_single = GUI::Action::create_checkable("Single", [&](auto&) {
m_viewer->set_page_view_mode(PDFViewer::PageViewMode::Single);
});
AK: Make "foo"_string infallible Stop worrying about tiny OOMs. Work towards #20405.
2023-08-07 06:12:38 -03:00
m_page_view_mode_single->set_status_tip("Show single page at a time"_string);
PDFViewer: Add page mode option
2022-03-29 01:19:45 -03:00
m_page_view_mode_multiple = GUI::Action::create_checkable("Multiple", [&](auto&) {
m_viewer->set_page_view_mode(PDFViewer::PageViewMode::Multiple);
});
AK: Make "foo"_string infallible Stop worrying about tiny OOMs. Work towards #20405.
2023-08-07 06:12:38 -03:00
m_page_view_mode_multiple->set_status_tip("Show multiple pages at a time"_string);
PDFViewer: Add page mode option
2022-03-29 01:19:45 -03:00
if (m_viewer->page_view_mode() == PDFViewer::PageViewMode::Single) {
m_page_view_mode_single->set_checked(true);
} else {
m_page_view_mode_multiple->set_checked(true);
}
m_page_view_action_group.add_action(*m_page_view_mode_single);
m_page_view_action_group.add_action(*m_page_view_mode_multiple);
m_page_view_action_group.set_exclusive(true);
PDFViewer: Show single/multi page actions on toolbar These actions were being constructed, and they work, but were not shown in the toolbar. Adding them will allow users to actually use them, as well as pick up any bugs they might have.
2022-11-23 10:42:09 -03:00
toolbar.add_action(*m_page_view_mode_single);
toolbar.add_action(*m_page_view_mode_multiple);
toolbar.add_separator();
PDFViewer: Add page mode option
2022-03-29 01:19:45 -03:00
PDFViewer: Add zoom in/out/reset menu actions Make PDFViewer::zoom_in() & ::zoom_out() public and add menu and toolbar actions. Also add an action for zoom reset.
2022-01-02 17:58:51 -03:00
toolbar.add_action(*m_zoom_in_action);
toolbar.add_action(*m_zoom_out_action);
toolbar.add_action(*m_reset_zoom_action);
PDFViewer: Add actions to rotate the displayed PDF This implements the rotate cw/ccw actions in PDFViewer. Since the rendered pages are stored in a HashMap for caching, the bitmap is wrapped in a struct with the current rotation. This way the caching works as expected while zooming, and a new bitmap is rendered when the page is rotated.
2022-01-02 20:24:11 -03:00
toolbar.add_action(*m_rotate_counterclockwise_action);
toolbar.add_action(*m_rotate_clockwise_action);
PDFViewer: Let users change clipping paths visibility Now that the Renderer accepts preferences, PDFViewer can offer ways for changing these preferences. The first step in this direction is to add a checkbox that allows toggling whether clipping paths are visible or not. A Config item has also been added to remember this setting.
2022-11-23 10:16:52 -03:00
toolbar.add_separator();
m_show_clipping_paths = toolbar.add<GUI::CheckBox>();
AK: Make "foo"_string infallible Stop worrying about tiny OOMs. Work towards #20405.
2023-08-07 06:12:38 -03:00
m_show_clipping_paths->set_text("Show clipping paths"_string);
PDFViewer: Let users change clipping paths visibility Now that the Renderer accepts preferences, PDFViewer can offer ways for changing these preferences. The first step in this direction is to add a checkbox that allows toggling whether clipping paths are visible or not. A Config item has also been added to remember this setting.
2022-11-23 10:16:52 -03:00
m_show_clipping_paths->set_checked(m_viewer->show_clipping_paths(), GUI::AllowCallback::No);
m_show_clipping_paths->on_checked = [&](auto checked) { m_viewer->set_show_clipping_paths(checked); };
PDFViewer: Let users change image rendering A new checkbox in the toolbar now allows users toggle image rendering. A corresponding Config option makes this setting non-volatile. To void clashing with the previous "show_clipping_paths" option when caching a Page, we now use the RenderingPreferences.hash() and the pair_int_hash funcitons to compute a unique key into the page cache map for a given RenderingPreferences and zoom level.
2022-11-24 15:11:06 -03:00
m_show_images = toolbar.add<GUI::CheckBox>();
AK: Make "foo"_string infallible Stop worrying about tiny OOMs. Work towards #20405.
2023-08-07 06:12:38 -03:00
m_show_images->set_text("Show images"_string);
PDFViewer: Let users change image rendering A new checkbox in the toolbar now allows users toggle image rendering. A corresponding Config option makes this setting non-volatile. To void clashing with the previous "show_clipping_paths" option when caching a Page, we now use the RenderingPreferences.hash() and the pair_int_hash funcitons to compute a unique key into the page cache map for a given RenderingPreferences and zoom level.
2022-11-24 15:11:06 -03:00
m_show_images->set_checked(m_viewer->show_images(), GUI::AllowCallback::No);
m_show_images->on_checked = [&](auto checked) { m_viewer->set_show_images(checked); };
Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
}
LibCore: Move Stream-based file into the `Core` namespace
2023-02-08 23:02:46 -03:00
void PDFViewerWidget::open_file(StringView path, NonnullOwnPtr<Core::File> file)
Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
{
PDFViewer: Port to Core::Stream::File
2023-01-09 17:28:05 -03:00
auto maybe_error = try_open_file(path, move(file));
PDFViewer: Perform standard error handling when opening files The previous implementation of open_file had a lambda that was used to inspect the call of ErrorOr-returning calls. This was a non-standard way of doing this though, as the more usual and clearer way is to have an inner function that returns ErrorOr, then handle any incoming errors on the top level function. This commit adds a try_open_file function, where all the logic occurs, and all the failure-producing steps are simplied TRY'ed. The top level open_file function takes that result and does what the lambda previously did: showing a message box with the actual error.
2022-12-17 01:15:22 -03:00
if (maybe_error.is_error()) {
auto error = maybe_error.release_error();
warnln("{}", error.message());
PDFViewer: Inform users of underlying issue when loading document While this is not super useful to end users, it's still better than the simpler, generic "failed to load" error message.
2023-01-05 12:53:12 -03:00
auto user_error_message = DeprecatedString::formatted("Failed to load the document. Error:\n{}.", error.message());
GUI::MessageBox::show_error(nullptr, user_error_message.view());
PDFViewer: Perform standard error handling when opening files The previous implementation of open_file had a lambda that was used to inspect the call of ErrorOr-returning calls. This was a non-standard way of doing this though, as the more usual and clearer way is to have an inner function that returns ErrorOr, then handle any incoming errors on the top level function. This commit adds a try_open_file function, where all the logic occurs, and all the failure-producing steps are simplied TRY'ed. The top level open_file function takes that result and does what the lambda previously did: showing a message box with the actual error.
2022-12-17 01:15:22 -03:00
}
}
PDFViewer: Display error dialog if necessary instead of crashing
2021-05-24 18:23:08 -03:00
LibCore: Move Stream-based file into the `Core` namespace
2023-02-08 23:02:46 -03:00
PDF::PDFErrorOr<void> PDFViewerWidget::try_open_file(StringView path, NonnullOwnPtr<Core::File> file)
PDFViewer: Perform standard error handling when opening files The previous implementation of open_file had a lambda that was used to inspect the call of ErrorOr-returning calls. This was a non-standard way of doing this though, as the more usual and clearer way is to have an inner function that returns ErrorOr, then handle any incoming errors on the top level function. This commit adds a try_open_file function, where all the logic occurs, and all the failure-producing steps are simplied TRY'ed. The top level open_file function takes that result and does what the lambda previously did: showing a message box with the actual error.
2022-12-17 01:15:22 -03:00
{
PDFViewer: Port to Core::Stream::File
2023-01-09 17:28:05 -03:00
window()->set_title(DeprecatedString::formatted("{} - PDF Viewer", path));
PDFViewer: Support a continuous page view mode
2022-03-30 01:27:17 -03:00
PDFViewer: Port to Core::Stream::File
2023-01-09 17:28:05 -03:00
m_buffer = TRY(file->read_until_eof());
PDFViewer: Perform standard error handling when opening files The previous implementation of open_file had a lambda that was used to inspect the call of ErrorOr-returning calls. This was a non-standard way of doing this though, as the more usual and clearer way is to have an inner function that returns ErrorOr, then handle any incoming errors on the top level function. This commit adds a try_open_file function, where all the logic occurs, and all the failure-producing steps are simplied TRY'ed. The top level open_file function takes that result and does what the lambda previously did: showing a message box with the actual error.
2022-12-17 01:15:22 -03:00
auto document = TRY(PDF::Document::create(m_buffer));
LibPDF: Propagate errors in Parser and Document
2022-03-05 21:30:55 -03:00
LibPDF: Fix security-handler-related nullptr regression
2022-03-30 22:08:02 -03:00
if (auto sh = document->security_handler(); sh && !sh->has_user_password()) {
LibGUI+Userland: Improve error and font handling for InputBox Adds fallible factories, ports DeprecatedString, and rebuilds the layout to accomodate system font changes.
2023-04-16 17:02:07 -03:00
String password;
PDFViewer: Prompt password for encrypted documents This tackles a FIXME, but also makes sense to implement only now that the SecurityHandler logic has been fixed. When a Document is created an automatic attempt is made to provide the empty string as the password; even if this attempt failed the SecurityHandler still reported it had a user password, hence we never arrived to the VERIFY_NOT_REQUIRED line this commit is changing.
2022-12-20 03:15:56 -03:00
while (true) {
LibGUI+Userland: Switch order of parameters for InputBox::show Because usage of the input_type parameter is now higher than of the placeholder parameter, this makes for a cleaner API.
2022-12-30 17:13:54 -03:00
auto result = GUI::InputBox::show(window(), password, "Password"sv, "Password required"sv, GUI::InputType::Password);
PDFViewer: Prompt password for encrypted documents This tackles a FIXME, but also makes sense to implement only now that the SecurityHandler logic has been fixed. When a Document is created an automatic attempt is made to provide the empty string as the password; even if this attempt failed the SecurityHandler still reported it had a user password, hence we never arrived to the VERIFY_NOT_REQUIRED line this commit is changing.
2022-12-20 03:15:56 -03:00
if (result == GUI::Dialog::ExecResult::OK
&& document->security_handler()->try_provide_user_password(password))
break;
if (result == GUI::Dialog::ExecResult::Cancel)
return {};
}
LibPDF: Add implementation of the Standard security handler Security handlers manage encryption and decription of PDF files. The standard security handler uses RC4/MD5 to perform its crypto (AES as well, but that is not yet implemented).
2022-03-20 18:24:23 -03:00
}
PDFViewer: Perform standard error handling when opening files The previous implementation of open_file had a lambda that was used to inspect the call of ErrorOr-returning calls. This was a non-standard way of doing this though, as the more usual and clearer way is to have an inner function that returns ErrorOr, then handle any incoming errors on the top level function. This commit adds a try_open_file function, where all the logic occurs, and all the failure-producing steps are simplied TRY'ed. The top level open_file function takes that result and does what the lambda previously did: showing a message box with the actual error.
2022-12-17 01:15:22 -03:00
TRY(document->initialize());
TRY(m_viewer->set_document(document));
LibPDF: Add implementation of the Standard security handler Security handlers manage encryption and decription of PDF files. The standard security handler uses RC4/MD5 to perform its crypto (AES as well, but that is not yet implemented).
2022-03-20 18:24:23 -03:00
LibGUI+Userland: Port Labels to String
2023-04-29 11:41:48 -03:00
m_total_page_label->set_text(TRY(String::formatted("of {}", document->get_page_count())));
PDFViewer: Add a toolbar The toolbar has an option to toggle the sidebar, a number input to set the current page, and two buttons to go up and down by one page
2021-05-24 02:34:44 -03:00
m_page_text_box->set_enabled(true);
PDFViewer: Respect page navigation features in multi-page mode This includes the text box and the page up/down arrows.
2022-03-31 22:01:07 -03:00
m_page_text_box->set_current_number(1, GUI::AllowCallback::No);
PDFViewer: Add a toolbar The toolbar has an option to toggle the sidebar, a number input to set the current page, and two buttons to go up and down by one page
2021-05-24 02:34:44 -03:00
m_page_text_box->set_max_number(document->get_page_count());
PDFViewer: Enable previous/next buttons conditionally Instead of having both always enabled once a document is loaded, update them on each page change and disable if appropriate.
2021-05-27 14:47:44 -03:00
m_go_to_prev_page_action->set_enabled(false);
m_go_to_next_page_action->set_enabled(document->get_page_count() > 1);
PDFViewer: Add a toolbar The toolbar has an option to toggle the sidebar, a number input to set the current page, and two buttons to go up and down by one page
2021-05-24 02:34:44 -03:00
m_toggle_sidebar_action->set_enabled(true);
PDFViewer: Add zoom in/out/reset menu actions Make PDFViewer::zoom_in() & ::zoom_out() public and add menu and toolbar actions. Also add an action for zoom reset.
2022-01-02 17:58:51 -03:00
m_zoom_in_action->set_enabled(true);
m_zoom_out_action->set_enabled(true);
m_reset_zoom_action->set_enabled(true);
PDFViewer: Add actions to rotate the displayed PDF This implements the rotate cw/ccw actions in PDFViewer. Since the rendered pages are stored in a HashMap for caching, the bitmap is wrapped in a struct with the current rotation. This way the caching works as expected while zooming, and a new bitmap is rendered when the page is rotated.
2022-01-02 20:24:11 -03:00
m_rotate_counterclockwise_action->set_enabled(true);
m_rotate_clockwise_action->set_enabled(true);
PDFViewer: Let users change clipping paths visibility Now that the Renderer accepts preferences, PDFViewer can offer ways for changing these preferences. The first step in this direction is to add a checkbox that allows toggling whether clipping paths are visible or not. A Config item has also been added to remember this setting.
2022-11-23 10:16:52 -03:00
m_show_clipping_paths->set_checked(m_viewer->show_clipping_paths(), GUI::AllowCallback::No);
PDFViewer: Add a tab bar with outlines and thumbnails Outlines are in theory implemented (though I'm having trouble finding a simple PDF with outlines to test it on), and thumbnails are not.
2021-05-24 01:34:06 -03:00
if (document->outline()) {
auto outline = document->outline();
PDFViewer: Propagate errors from OutlineModel construction This follows the same idea that Andreas was doing in this latest videos, where construction-time TRY()s were not present but should have been. Like Andreas did, moving the initialisation of such fields to the factory function, which then returns ErrorOr solves the issue.
2022-12-17 01:18:29 -03:00
TRY(m_sidebar->set_outline(outline.release_nonnull()));
Applications+DevTools: Remove fixed sizes from Splitters And adjust some GML properties. Since a808cfa, splitters grow opportunistically. Setting them to fixed sizes now quite literally fixes them in place. Fixes immovable splitters missed in the aforementioned commit.
2022-08-30 08:38:20 -03:00
m_sidebar->set_visible(true);
PDFViewer: Add a tab bar with outlines and thumbnails Outlines are in theory implemented (though I'm having trouble finding a simple PDF with outlines to test it on), and thumbnails are not.
2021-05-24 01:34:06 -03:00
m_sidebar_open = true;
} else {
PDFViewer: Propagate errors from OutlineModel construction This follows the same idea that Andreas was doing in this latest videos, where construction-time TRY()s were not present but should have been. Like Andreas did, moving the initialisation of such fields to the factory function, which then returns ErrorOr solves the issue.
2022-12-17 01:18:29 -03:00
TRY(m_sidebar->set_outline({}));
Applications+DevTools: Remove fixed sizes from Splitters And adjust some GML properties. Since a808cfa, splitters grow opportunistically. Setting them to fixed sizes now quite literally fixes them in place. Fixes immovable splitters missed in the aforementioned commit.
2022-08-30 08:38:20 -03:00
m_sidebar->set_visible(false);
PDFViewer: Add a tab bar with outlines and thumbnails Outlines are in theory implemented (though I'm having trouble finding a simple PDF with outlines to test it on), and thumbnails are not.
2021-05-24 01:34:06 -03:00
m_sidebar_open = false;
}
PDFViewer: Perform standard error handling when opening files The previous implementation of open_file had a lambda that was used to inspect the call of ErrorOr-returning calls. This was a non-standard way of doing this though, as the more usual and clearer way is to have an inner function that returns ErrorOr, then handle any incoming errors on the top level function. This commit adds a try_open_file function, where all the logic occurs, and all the failure-producing steps are simplied TRY'ed. The top level open_file function takes that result and does what the lambda previously did: showing a message box with the actual error.
2022-12-17 01:15:22 -03:00
PDFViewer: Add list of recently-opened files
2023-04-03 10:30:22 -03:00
GUI::Application::the()->set_most_recently_open_file(TRY(String::from_utf8(path)));
PDFViewer: Perform standard error handling when opening files The previous implementation of open_file had a lambda that was used to inspect the call of ErrorOr-returning calls. This was a non-standard way of doing this though, as the more usual and clearer way is to have an inner function that returns ErrorOr, then handle any incoming errors on the top level function. This commit adds a try_open_file function, where all the logic occurs, and all the failure-producing steps are simplied TRY'ed. The top level open_file function takes that result and does what the lambda previously did: showing a message box with the actual error.
2022-12-17 01:15:22 -03:00
return {};
Applications: Add a very simple PDFViewer
2021-05-10 15:50:15 -03:00
}
PDFViewer: Accept file drops
2023-08-29 13:31:11 -03:00
void PDFViewerWidget::drag_enter_event(GUI::DragEvent& event)
{
auto const& mime_types = event.mime_types();
if (mime_types.contains_slow("text/uri-list"sv))
event.accept();
}
void PDFViewerWidget::drop_event(GUI::DropEvent& event)
{
event.accept();
window()->move_to_front();
if (event.mime_data().has_urls()) {
auto urls = event.mime_data().urls();
if (urls.is_empty())
return;
if (urls.size() > 1) {
GUI::MessageBox::show(window(), "PDF Viewer can only open one file at a time!"sv, "One at a time please!"sv, GUI::MessageBox::Type::Error);
return;
}
auto response = FileSystemAccessClient::Client::the().request_file_read_only_approved(window(), urls.first().serialize_path());
if (response.is_error())
return;
if (auto result = try_open_file(response.value().filename(), response.value().release_stream()); result.is_error())
GUI::MessageBox::show(window(), "Unable to open file.\n"sv, "Error"sv, GUI::MessageBox::Type::Error);
}
}
Reference in a new issue Copy permalink