dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ladybird/Userland/DevTools/HackStudio/Debugger/DebuggerVariableJSObject.h

39 lines
1.1 KiB
C
Raw Normal View History

HackStudio: Implement custom JS -> C++ "proxy" objects This patch adds a custom JS Object type that will convert written properties to their C++ equivalents, reflecting JS writes back to the debugging session. This is better than a simple proxy because printing this custom object works as expected because properties still exist on the object as existing handlers expect.
2021-04-12 22:59:15 -03:00
/*
* Copyright (c) 2021, Matthew Olsson <matthewcolsson@gmail.com>
* Copyright (c) 2021, Hunter Salyer <thefalsehonesty@gmail.com>
DevTools: Use default constructors/destructors https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules "The compiler is more likely to get the default semantics right and you cannot implement these functions better than the compiler."
2022-02-15 17:28:01 -03:00
* Copyright (c) 2022, the SerenityOS developers.
HackStudio: Implement custom JS -> C++ "proxy" objects This patch adds a custom JS Object type that will convert written properties to their C++ equivalents, reflecting JS writes back to the debugging session. This is better than a simple proxy because printing this custom object works as expected because properties still exist on the object as existing handlers expect.
2021-04-12 22:59:15 -03:00
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include "DebuggerGlobalJSObject.h"
DevTools+LibJS+LibWeb: Change class_name to use StringView This helps make the overall codebase consistent. `class_name()` in `Kernel` is always `StringView`, but not elsewhere. Additionally, this results in the `strlen` (which needs to be done when printing or other operations) always being computed at compile-time.
2022-03-16 21:26:49 -03:00
#include <AK/StringView.h>
HackStudio: Implement custom JS -> C++ "proxy" objects This patch adds a custom JS Object type that will convert written properties to their C++ equivalents, reflecting JS writes back to the debugging session. This is better than a simple proxy because printing this custom object works as expected because properties still exist on the object as existing handlers expect.
2021-04-12 22:59:15 -03:00
#include <LibDebug/DebugInfo.h>
LibJS: Convert internal_set() to ThrowCompletionOr
2021-09-29 14:31:37 -03:00
#include <LibJS/Runtime/Completion.h>
HackStudio: Implement custom JS -> C++ "proxy" objects This patch adds a custom JS Object type that will convert written properties to their C++ equivalents, reflecting JS writes back to the debugging session. This is better than a simple proxy because printing this custom object works as expected because properties still exist on the object as existing handlers expect.
2021-04-12 22:59:15 -03:00
#include <LibJS/Runtime/Object.h>
namespace HackStudio {
class DebuggerVariableJSObject final : public JS::Object {
HackStudio: Display variable type name in expression evaluator
2021-04-20 19:59:53 -03:00
using Base = JS::Object;
HackStudio: Implement custom JS -> C++ "proxy" objects This patch adds a custom JS Object type that will convert written properties to their C++ equivalents, reflecting JS writes back to the debugging session. This is better than a simple proxy because printing this custom object works as expected because properties still exist on the object as existing handlers expect.
2021-04-12 22:59:15 -03:00
public:
Everywhere: Run clang-format
2022-04-01 14:58:27 -03:00
static DebuggerVariableJSObject* create(DebuggerGlobalJSObject&, Debug::DebugInfo::VariableInfo const& variable_info);
HackStudio: Implement custom JS -> C++ "proxy" objects This patch adds a custom JS Object type that will convert written properties to their C++ equivalents, reflecting JS writes back to the debugging session. This is better than a simple proxy because printing this custom object works as expected because properties still exist on the object as existing handlers expect.
2021-04-12 22:59:15 -03:00
Everywhere: Run clang-format
2022-04-01 14:58:27 -03:00
DebuggerVariableJSObject(Debug::DebugInfo::VariableInfo const& variable_info, JS::Object& prototype);
DevTools: Use default constructors/destructors https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules "The compiler is more likely to get the default semantics right and you cannot implement these functions better than the compiler."
2022-02-15 17:28:01 -03:00
virtual ~DebuggerVariableJSObject() override = default;
HackStudio: Implement custom JS -> C++ "proxy" objects This patch adds a custom JS Object type that will convert written properties to their C++ equivalents, reflecting JS writes back to the debugging session. This is better than a simple proxy because printing this custom object works as expected because properties still exist on the object as existing handlers expect.
2021-04-12 22:59:15 -03:00
DevTools+LibJS+LibWeb: Change class_name to use StringView This helps make the overall codebase consistent. `class_name()` in `Kernel` is always `StringView`, but not elsewhere. Additionally, this results in the `strlen` (which needs to be done when printing or other operations) always being computed at compile-time.
2022-03-16 21:26:49 -03:00
virtual StringView class_name() const override { return m_variable_info.type_name; }
HackStudio: Display variable type name in expression evaluator
2021-04-20 19:59:53 -03:00
LibJS: Rename PropertyName to PropertyKey Let's use the same name as the spec. :^)
2021-10-24 11:01:24 -03:00
JS::ThrowCompletionOr<bool> internal_set(JS::PropertyKey const&, JS::Value value, JS::Value receiver) override;
HackStudio: Implement custom JS -> C++ "proxy" objects This patch adds a custom JS Object type that will convert written properties to their C++ equivalents, reflecting JS writes back to the debugging session. This is better than a simple proxy because printing this custom object works as expected because properties still exist on the object as existing handlers expect.
2021-04-12 22:59:15 -03:00
private:
DebuggerGlobalJSObject& debugger_object() const;
Everywhere: Run clang-format
2022-04-01 14:58:27 -03:00
Debug::DebugInfo::VariableInfo const& m_variable_info;
HackStudio: Implement custom JS -> C++ "proxy" objects This patch adds a custom JS Object type that will convert written properties to their C++ equivalents, reflecting JS writes back to the debugging session. This is better than a simple proxy because printing this custom object works as expected because properties still exist on the object as existing handlers expect.
2021-04-12 22:59:15 -03:00
};
}
Reference in a new issue Copy permalink