dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ladybird/Libraries/LibUnicode/UnicodeKeywords.cpp

298 lines
9.5 KiB
C++
Raw Normal View History

LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
/*
LibUnicode: Use ICU to convert Unicode keywords to their BCP 47 value We were manually doing this for the calendar keyword, and would need to do so for the collation keyword as well. I wasn't aware of this API originally, so let's start using it.
2025-06-02 15:15:05 -03:00
* Copyright (c) 2024-2025, Tim Flynn <trflynn89@ladybird.org>
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
*
* SPDX-License-Identifier: BSD-2-Clause
*/
Meta: Enable exit-time destructor warnings for libraries Enable -Wexit-time-destructors for all in-tree library targets and update process-lifetime library statics so they no longer register exit-time destructors. Long-lived caches, lookup tables, singleton registries, and generated constants now use NeverDestroyed or leaked references where the data is intended to live until process exit. Update LibWeb, LibLine, and the binding generators so regenerated sources follow the same rule instead of reintroducing destructed statics.
2026-06-04 05:40:32 -03:00
#include <AK/NeverDestroyed.h>
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
#include <AK/QuickSort.h>
#include <AK/ScopeGuard.h>
LibUnicode+Everywhere: Merge LibLocale back into LibUnicode LibLocale was split off from LibUnicode a couple years ago to reduce the number of applications on SerenityOS that depend on CLDR data. Now that we use ICU, both LibUnicode and LibLocale are actually linking in this data. And since vcpkg gives us static libraries, both libraries are over 30MB in size. This patch reverts the separation and merges LibLocale into LibUnicode again. We now have just one library that includes the ICU data. Further, this will let LibUnicode share the locale cache that previously would only exist in LibLocale.
2024-06-23 10:14:27 -03:00
#include <LibUnicode/DateTimeFormat.h>
#include <LibUnicode/ICU.h>
#include <LibUnicode/UnicodeKeywords.h>
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
#include <unicode/calendar.h>
#include <unicode/coll.h>
#include <unicode/locid.h>
#include <unicode/numsys.h>
#include <unicode/ucurr.h>
LibUnicode+Everywhere: Merge LibLocale back into LibUnicode LibLocale was split off from LibUnicode a couple years ago to reduce the number of applications on SerenityOS that depend on CLDR data. Now that we use ICU, both LibUnicode and LibLocale are actually linking in this data. And since vcpkg gives us static libraries, both libraries are over 30MB in size. This patch reverts the separation and merges LibLocale into LibUnicode again. We now have just one library that includes the ICU data. Further, this will let LibUnicode share the locale cache that previously would only exist in LibLocale.
2024-06-23 10:14:27 -03:00
namespace Unicode {
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> available_keyword_values(Utf16View locale, Utf16View key)
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
{
if (key == "ca"sv)
return available_calendars(locale);
if (key == "co"sv)
return available_collations(locale);
if (key == "hc"sv)
return available_hour_cycles(locale);
if (key == "kf"sv)
return available_collation_case_orderings();
if (key == "kn"sv)
return available_collation_numeric_orderings();
if (key == "nu"sv)
return available_number_systems(locale);
TODO();
}
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
static bool is_available_calendar(char const* value, size_t value_length)
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
{
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
// "islamic" and "islamic-rgsa" are deprecated calendar types that DateTimeFormat resolves to other calendars,
// so they should not be advertised as available.
return !StringView { value, value_length }.is_one_of("islamic"sv, "islamic-rgsa"sv);
}
Vector<Utf16String> const& available_calendars()
{
static NeverDestroyed<Vector<Utf16String>> calendars { []() -> Vector<Utf16String> {
auto calendars = available_calendars(Utf16View { "und"sv });
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
quick_sort(calendars);
return calendars;
Meta: Enable exit-time destructor warnings for libraries Enable -Wexit-time-destructors for all in-tree library targets and update process-lifetime library statics so they no longer register exit-time destructors. Long-lived caches, lookup tables, singleton registries, and generated constants now use NeverDestroyed or leaked references where the data is intended to live until process exit. Update LibWeb, LibLine, and the binding generators so regenerated sources follow the same rule instead of reintroducing destructed statics.
2026-06-04 05:40:32 -03:00
}() };
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
Meta: Enable exit-time destructor warnings for libraries Enable -Wexit-time-destructors for all in-tree library targets and update process-lifetime library statics so they no longer register exit-time destructors. Long-lived caches, lookup tables, singleton registries, and generated constants now use NeverDestroyed or leaked references where the data is intended to live until process exit. Update LibWeb, LibLine, and the binding generators so regenerated sources follow the same rule instead of reintroducing destructed statics.
2026-06-04 05:40:32 -03:00
return *calendars;
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
}
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> available_calendars(Utf16View locale)
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
{
UErrorCode status = U_ZERO_ERROR;
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
auto locale_data = LocaleData::for_locale(locale.bytes());
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
if (!locale_data.has_value())
return {};
auto keywords = adopt_own_if_nonnull(icu::Calendar::getKeywordValuesForLocale("calendar", locale_data->locale(), 0, status));
if (icu_failure(status))
return {};
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> result;
while (true) {
i32 length = 0;
auto const* value = keywords->next(&length, status);
if (icu_failure(status) || value == nullptr)
break;
if (!is_available_calendar(value, static_cast<size_t>(length)))
continue;
if (auto const* bcp47_value = uloc_toUnicodeLocaleType("ca", value))
result.append(Utf16String::from_ascii_without_validation(StringView { bcp47_value, strlen(bcp47_value) }.bytes()));
}
return result;
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
}
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> const& available_currencies()
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
{
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
static NeverDestroyed<Vector<Utf16String>> currencies { []() -> Vector<Utf16String> {
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
UErrorCode status = U_ZERO_ERROR;
auto* currencies = ucurr_openISOCurrencies(UCURR_ALL, &status);
ScopeGuard guard { [&]() { uenum_close(currencies); } };
if (icu_failure(status))
return {};
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> result;
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
while (true) {
i32 length = 0;
char const* next = uenum_next(currencies, &length, &status);
if (icu_failure(status))
return {};
if (next == nullptr)
break;
// https://unicode-org.atlassian.net/browse/ICU-21687
if (StringView currency { next, static_cast<size_t>(length) }; currency != "LSM"sv)
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
result.append(Utf16String::from_utf8(currency));
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
}
quick_sort(result);
return result;
Meta: Enable exit-time destructor warnings for libraries Enable -Wexit-time-destructors for all in-tree library targets and update process-lifetime library statics so they no longer register exit-time destructors. Long-lived caches, lookup tables, singleton registries, and generated constants now use NeverDestroyed or leaked references where the data is intended to live until process exit. Update LibWeb, LibLine, and the binding generators so regenerated sources follow the same rule instead of reintroducing destructed statics.
2026-06-04 05:40:32 -03:00
}() };
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
Meta: Enable exit-time destructor warnings for libraries Enable -Wexit-time-destructors for all in-tree library targets and update process-lifetime library statics so they no longer register exit-time destructors. Long-lived caches, lookup tables, singleton registries, and generated constants now use NeverDestroyed or leaked references where the data is intended to live until process exit. Update LibWeb, LibLine, and the binding generators so regenerated sources follow the same rule instead of reintroducing destructed statics.
2026-06-04 05:40:32 -03:00
return *currencies;
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
}
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> const& available_collation_case_orderings()
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
{
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
static NeverDestroyed<Vector<Utf16String>> case_orderings { [] {
return Vector<Utf16String> {
Utf16String::from_ascii_without_validation("false"sv.bytes()),
Utf16String::from_ascii_without_validation("lower"sv.bytes()),
Utf16String::from_ascii_without_validation("upper"sv.bytes()),
};
}() };
Meta: Enable exit-time destructor warnings for libraries Enable -Wexit-time-destructors for all in-tree library targets and update process-lifetime library statics so they no longer register exit-time destructors. Long-lived caches, lookup tables, singleton registries, and generated constants now use NeverDestroyed or leaked references where the data is intended to live until process exit. Update LibWeb, LibLine, and the binding generators so regenerated sources follow the same rule instead of reintroducing destructed statics.
2026-06-04 05:40:32 -03:00
return *case_orderings;
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
}
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> const& available_collation_numeric_orderings()
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
{
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
static NeverDestroyed<Vector<Utf16String>> numeric_orderings { [] {
return Vector<Utf16String> {
Utf16String::from_ascii_without_validation("false"sv.bytes()),
Utf16String::from_ascii_without_validation("true"sv.bytes()),
};
}() };
return *numeric_orderings;
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
}
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> const& available_collations()
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
{
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
static NeverDestroyed<Vector<Utf16String>> collations { []() -> Vector<Utf16String> {
LibJS+LibUnicode: Implement retrieval of collator keyword values Completely missed this when implementing Intl.Collator!
2025-06-02 15:35:12 -03:00
UErrorCode status = U_ZERO_ERROR;
auto keywords = adopt_own_if_nonnull(icu::Collator::getKeywordValues("collation", status));
if (icu_failure(status))
return {};
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> collations;
while (true) {
i32 length = 0;
auto const* value = keywords->next(&length, status);
if (icu_failure(status) || value == nullptr)
break;
LibJS+LibUnicode: Implement retrieval of collator keyword values Completely missed this when implementing Intl.Collator!
2025-06-02 15:35:12 -03:00
// https://tc39.es/ecma402/#sec-properties-of-intl-collator-instances
// the values "standard" and "search" are not allowed
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
if (StringView { value, static_cast<size_t>(length) }.is_one_of("standard"sv, "search"sv))
continue;
if (auto const* bcp47_value = uloc_toUnicodeLocaleType("co", value))
collations.append(Utf16String::from_ascii_without_validation(StringView { bcp47_value, strlen(bcp47_value) }.bytes()));
}
LibJS+LibUnicode: Implement retrieval of collator keyword values Completely missed this when implementing Intl.Collator!
2025-06-02 15:35:12 -03:00
quick_sort(collations);
return collations;
Meta: Enable exit-time destructor warnings for libraries Enable -Wexit-time-destructors for all in-tree library targets and update process-lifetime library statics so they no longer register exit-time destructors. Long-lived caches, lookup tables, singleton registries, and generated constants now use NeverDestroyed or leaked references where the data is intended to live until process exit. Update LibWeb, LibLine, and the binding generators so regenerated sources follow the same rule instead of reintroducing destructed statics.
2026-06-04 05:40:32 -03:00
}() };
LibJS+LibUnicode: Implement retrieval of collator keyword values Completely missed this when implementing Intl.Collator!
2025-06-02 15:35:12 -03:00
Meta: Enable exit-time destructor warnings for libraries Enable -Wexit-time-destructors for all in-tree library targets and update process-lifetime library statics so they no longer register exit-time destructors. Long-lived caches, lookup tables, singleton registries, and generated constants now use NeverDestroyed or leaked references where the data is intended to live until process exit. Update LibWeb, LibLine, and the binding generators so regenerated sources follow the same rule instead of reintroducing destructed statics.
2026-06-04 05:40:32 -03:00
return *collations;
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
}
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> available_collations(Utf16View locale)
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
{
LibJS+LibUnicode: Implement retrieval of collator keyword values Completely missed this when implementing Intl.Collator!
2025-06-02 15:35:12 -03:00
UErrorCode status = U_ZERO_ERROR;
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
auto locale_data = LocaleData::for_locale(locale.bytes());
LibJS+LibUnicode: Implement retrieval of collator keyword values Completely missed this when implementing Intl.Collator!
2025-06-02 15:35:12 -03:00
if (!locale_data.has_value())
return {};
auto keywords = adopt_own_if_nonnull(icu::Collator::getKeywordValuesForLocale("collation", locale_data->locale(), true, status));
if (icu_failure(status))
return {};
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> collations;
while (true) {
i32 length = 0;
auto const* value = keywords->next(&length, status);
if (icu_failure(status) || value == nullptr)
break;
LibJS+LibUnicode: Implement retrieval of collator keyword values Completely missed this when implementing Intl.Collator!
2025-06-02 15:35:12 -03:00
// https://tc39.es/ecma402/#sec-properties-of-intl-collator-instances
// the values "standard" and "search" are not allowed
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
if (StringView { value, static_cast<size_t>(length) }.is_one_of("standard"sv, "search"sv))
continue;
if (auto const* bcp47_value = uloc_toUnicodeLocaleType("co", value))
collations.append(Utf16String::from_ascii_without_validation(StringView { bcp47_value, strlen(bcp47_value) }.bytes()));
}
LibJS+LibUnicode: Implement retrieval of collator keyword values Completely missed this when implementing Intl.Collator!
2025-06-02 15:35:12 -03:00
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
auto default_collation = Utf16String::from_ascii_without_validation("default"sv.bytes());
if (!collations.contains_slow(default_collation))
collations.prepend(default_collation);
LibJS+LibUnicode: Implement retrieval of collator keyword values Completely missed this when implementing Intl.Collator!
2025-06-02 15:35:12 -03:00
return collations;
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
}
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> const& available_hour_cycles()
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
{
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
static NeverDestroyed<Vector<Utf16String>> hour_cycles { [] {
return Vector<Utf16String> {
Utf16String::from_ascii_without_validation("h11"sv.bytes()),
Utf16String::from_ascii_without_validation("h12"sv.bytes()),
Utf16String::from_ascii_without_validation("h23"sv.bytes()),
Utf16String::from_ascii_without_validation("h24"sv.bytes()),
};
}() };
Meta: Enable exit-time destructor warnings for libraries Enable -Wexit-time-destructors for all in-tree library targets and update process-lifetime library statics so they no longer register exit-time destructors. Long-lived caches, lookup tables, singleton registries, and generated constants now use NeverDestroyed or leaked references where the data is intended to live until process exit. Update LibWeb, LibLine, and the binding generators so regenerated sources follow the same rule instead of reintroducing destructed statics.
2026-06-04 05:40:32 -03:00
return *hour_cycles;
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
}
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> available_hour_cycles(Utf16View locale)
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
{
auto preferred_hour_cycle = default_hour_cycle(locale);
if (!preferred_hour_cycle.has_value())
return available_hour_cycles();
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> hour_cycles;
hour_cycles.append(available_hour_cycles()[to_underlying(*preferred_hour_cycle)]);
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
for (auto const& hour_cycle : available_hour_cycles()) {
if (hour_cycle != hour_cycles[0])
hour_cycles.append(hour_cycle);
}
return hour_cycles;
}
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> const& available_number_systems()
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
{
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
static NeverDestroyed<Vector<Utf16String>> number_systems { []() -> Vector<Utf16String> {
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
UErrorCode status = U_ZERO_ERROR;
auto keywords = adopt_own_if_nonnull(icu::NumberingSystem::getAvailableNames(status));
if (icu_failure(status))
return {};
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> number_systems;
while (true) {
i32 length = 0;
auto const* keyword = keywords->next(&length, status);
if (icu_failure(status) || keyword == nullptr)
break;
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
auto system = adopt_own_if_nonnull(icu::NumberingSystem::createInstanceByName(keyword, status));
if (icu_failure(status))
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
return {};
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
if (!static_cast<bool>(system->isAlgorithmic())) {
if (auto const* bcp47_value = uloc_toUnicodeLocaleType("nu", keyword))
number_systems.append(Utf16String::from_ascii_without_validation(StringView { bcp47_value, strlen(bcp47_value) }.bytes()));
}
}
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
quick_sort(number_systems);
return number_systems;
Meta: Enable exit-time destructor warnings for libraries Enable -Wexit-time-destructors for all in-tree library targets and update process-lifetime library statics so they no longer register exit-time destructors. Long-lived caches, lookup tables, singleton registries, and generated constants now use NeverDestroyed or leaked references where the data is intended to live until process exit. Update LibWeb, LibLine, and the binding generators so regenerated sources follow the same rule instead of reintroducing destructed statics.
2026-06-04 05:40:32 -03:00
}() };
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
Meta: Enable exit-time destructor warnings for libraries Enable -Wexit-time-destructors for all in-tree library targets and update process-lifetime library statics so they no longer register exit-time destructors. Long-lived caches, lookup tables, singleton registries, and generated constants now use NeverDestroyed or leaked references where the data is intended to live until process exit. Update LibWeb, LibLine, and the binding generators so regenerated sources follow the same rule instead of reintroducing destructed statics.
2026-06-04 05:40:32 -03:00
return *number_systems;
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
}
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> available_number_systems(Utf16View locale)
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
{
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
auto locale_data = LocaleData::for_locale(locale.bytes());
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
if (!locale_data.has_value())
return {};
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
Vector<Utf16String> number_systems;
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
auto const* preferred_number_system = locale_data->numbering_system().getName();
Libraries: Use UTF-16 for JS-visible runtime strings Produce JS-visible string results as UTF-16 at their source, including numeric formatting, BigInt and BigFraction formatting, URI encoding, console formatting, parser errors, regular expression errors, Intl and Temporal records, LibUnicode locale boundaries, and LibWeb bindings. Handle fractional radix formatting through the UTF-16 builder view.
2026-06-21 14:03:10 -03:00
number_systems.append(Utf16String::from_ascii_without_validation(StringView { preferred_number_system, strlen(preferred_number_system) }.bytes()));
LibJS+LibLocale: Replace Unicode keyword lookups with ICU Note: All of the changes to the test files in this patch are now aligned with both Chrome and Firefox.
2024-06-15 21:23:53 -03:00
for (auto const& number_system : available_number_systems()) {
if (number_system != number_systems[0])
number_systems.append(number_system);
}
return number_systems;
}
}
Reference in a new issue Copy permalink