dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ladybird/Userland/Libraries/LibJS/Runtime/RegExpConstructor.cpp

95 lines
2.8 KiB
C++
Raw Normal View History

LibJS: Lex and parse regex literals, add RegExp objects This adds regex parsing/lexing, as well as a relatively empty RegExpObject. The purpose of this patch is to allow the engine to not get hung up on parsing regexes. This will aid in finding new syntax errors (say, from google or twitter) without having to replace all of their regexes first!
2020-06-03 20:05:49 -03:00
/*
Userland: Use mattco@serenityos.org for my copyright headers
2021-04-22 20:53:07 -03:00
* Copyright (c) 2020, Matthew Olsson <mattco@serenityos.org>
LibJS: Lex and parse regex literals, add RegExp objects This adds regex parsing/lexing, as well as a relatively empty RegExpObject. The purpose of this patch is to allow the engine to not get hung up on parsing regexes. This will aid in finding new syntax errors (say, from google or twitter) without having to replace all of their regexes first!
2020-06-03 20:05:49 -03:00
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 05:24:48 -03:00
* SPDX-License-Identifier: BSD-2-Clause
LibJS: Lex and parse regex literals, add RegExp objects This adds regex parsing/lexing, as well as a relatively empty RegExpObject. The purpose of this patch is to allow the engine to not get hung up on parsing regexes. This will aid in finding new syntax errors (say, from google or twitter) without having to replace all of their regexes first!
2020-06-03 20:05:49 -03:00
*/
#include <LibJS/Runtime/Error.h>
#include <LibJS/Runtime/GlobalObject.h>
#include <LibJS/Runtime/RegExpConstructor.h>
#include <LibJS/Runtime/RegExpObject.h>
namespace JS {
LibJS+LibWeb: Replace GlobalObject with Realm in object constructors No functional changes - we can still very easily get to the global object via `Realm::global_object()`. This is in preparation of moving the intrinsics to the realm and no longer having to pass a global object when allocating any object. In a few (now, and many more in subsequent commits) places we get a realm using `GlobalObject::associated_realm()`, this is intended to be temporary. For example, create() functions will later receive the same treatment and are passed a realm instead of a global object.
2022-08-15 20:20:49 -03:00
RegExpConstructor::RegExpConstructor(Realm& realm)
LibJS: Do not invoke Cell::vm in constructors before Cell is constructed In a subclass of Cell, we cannot use Cell::vm() before the base Cell object itself is constructed. Use the Realm's VM instead. This was caught by UBSAN with vptr sanitation enabled.
2022-09-14 20:10:27 -03:00
: NativeFunction(realm.vm().names.RegExp.as_string(), *realm.intrinsics().function_prototype())
LibJS: Lex and parse regex literals, add RegExp objects This adds regex parsing/lexing, as well as a relatively empty RegExpObject. The purpose of this patch is to allow the engine to not get hung up on parsing regexes. This will aid in finding new syntax errors (say, from google or twitter) without having to replace all of their regexes first!
2020-06-03 20:05:49 -03:00
{
LibJS: Move native objects towards two-pass construction To make sure that everything is set up correctly in objects before we start adding properties to them, we split cell allocation into 3 steps: 1. Allocate a cell of appropriate size from the Heap 2. Call the C++ constructor on the cell 3. Call initialize() on the constructed object The job of initialize() is to define all the initial properties. Doing it in a second pass guarantees that the Object has a valid Shape and can find its own GlobalObject.
2020-06-20 10:40:48 -03:00
}
LibJS+LibWeb: Replace GlobalObject with Realm in initialize() functions This is a continuation of the previous commit. Calling initialize() is the first thing that's done after allocating a cell on the JS heap - and in the common case of allocating an object, that's where properties are assigned and intrinsics occasionally accessed. Since those are supposed to live on the realm eventually, this is another step into that direction.
2022-08-15 20:20:49 -03:00
void RegExpConstructor::initialize(Realm& realm)
LibJS: Move native objects towards two-pass construction To make sure that everything is set up correctly in objects before we start adding properties to them, we split cell allocation into 3 steps: 1. Allocate a cell of appropriate size from the Heap 2. Call the C++ constructor on the cell 3. Call initialize() on the constructed object The job of initialize() is to define all the initial properties. Doing it in a second pass guarantees that the Object has a valid Shape and can find its own GlobalObject.
2020-06-20 10:40:48 -03:00
{
LibJS: Cache commonly used FlyStrings in the VM Roughly 7% of test-js runtime was spent creating FlyStrings from string literals. This patch frontloads that work and caches all the commonly used names in LibJS on a CommonPropertyNames struct that hangs off VM.
2020-10-13 18:49:19 -03:00
auto& vm = this->vm();
LibJS+LibWeb: Replace GlobalObject with Realm in initialize() functions This is a continuation of the previous commit. Calling initialize() is the first thing that's done after allocating a cell on the JS heap - and in the common case of allocating an object, that's where properties are assigned and intrinsics occasionally accessed. Since those are supposed to live on the realm eventually, this is another step into that direction.
2022-08-15 20:20:49 -03:00
NativeFunction::initialize(realm);
LibJS: Add a bunch more missing ECMA-262 section/title/URL comments
2021-06-18 20:38:41 -03:00
// 22.2.4.1 RegExp.prototype, https://tc39.es/ecma262/#sec-regexp.prototype
LibJS: Move intrinsics to the realm Intrinsics, i.e. mostly constructor and prototype objects, but also things like empty and new object shape now live on a new heap-allocated JS::Intrinsics object, thus completing the long journey of taking all the magic away from the global object. This represents the Realm's [[Intrinsics]] slot in the spec and matches its existing [[GlobalObject]] / [[GlobalEnv]] slots in terms of architecture. In the majority of cases it should now be possibly to fully allocate a regular object without the global object existing, and in fact that's what we do now - the realm is allocated before the global object, and the intrinsics between both :^)
2022-08-26 20:54:55 -03:00
define_direct_property(vm.names.prototype, realm.intrinsics().regexp_prototype(), 0);
LibJS: Add a bunch more missing ECMA-262 section/title/URL comments
2021-06-18 20:38:41 -03:00
LibJS: Pass Realm to define_native_{accessor,function}() This is needed so that the allocated NativeFunction receives the correct realm, usually forwarded from the Object's initialize() function, rather than using the current realm.
2022-08-22 17:47:35 -03:00
define_native_accessor(realm, *vm.well_known_symbol_species(), symbol_species_getter, {}, Attribute::Configurable);
LibJS: Reorder and add missing name & length properties to Built-ins The specification dicatates that each built-in will have a length and name property. (defined in that order)
2021-07-07 20:49:53 -03:00
define_direct_property(vm.names.length, Value(2), Attribute::Configurable);
LibJS: Lex and parse regex literals, add RegExp objects This adds regex parsing/lexing, as well as a relatively empty RegExpObject. The purpose of this patch is to allow the engine to not get hung up on parsing regexes. This will aid in finding new syntax errors (say, from google or twitter) without having to replace all of their regexes first!
2020-06-03 20:05:49 -03:00
}
LibJS: Add a bunch more missing ECMA-262 section/title/URL comments
2021-06-18 20:38:41 -03:00
// 22.2.3.1 RegExp ( pattern, flags ), https://tc39.es/ecma262/#sec-regexp-pattern-flags
LibJS: Convert NativeFunction::{call,construct}() to ThrowCompletionOr Both at the same time because many of them call construct() in call() and I'm not keen on adding a bunch of temporary plumbing to turn exceptions into throw completions. Also changes the return value of construct() to Object* instead of Value as it always needs to return an object; allowing an arbitrary Value is a massive foot gun.
2021-10-20 17:16:30 -03:00
ThrowCompletionOr<Value> RegExpConstructor::call()
LibJS: Lex and parse regex literals, add RegExp objects This adds regex parsing/lexing, as well as a relatively empty RegExpObject. The purpose of this patch is to allow the engine to not get hung up on parsing regexes. This will aid in finding new syntax errors (say, from google or twitter) without having to replace all of their regexes first!
2020-06-03 20:05:49 -03:00
{
LibJS: Implement RegExp constructor according to the spec This allows passing an existing RegExp object (or an object that is sufficiently like a RegExp object) as the "pattern" argument of the RegExp constructor.
2021-07-08 14:36:09 -03:00
auto& vm = this->vm();
auto pattern = vm.argument(0);
auto flags = vm.argument(1);
LibJS: Replace GlobalObject with VM in Value AOs [Part 4/19] This is where the fun begins. :^)
2022-08-21 10:00:56 -03:00
bool pattern_is_regexp = TRY(pattern.is_regexp(vm));
LibJS: Implement RegExp constructor according to the spec This allows passing an existing RegExp object (or an object that is sufficiently like a RegExp object) as the "pattern" argument of the RegExp constructor.
2021-07-08 14:36:09 -03:00
if (pattern_is_regexp && flags.is_undefined()) {
LibJS: Convert NativeFunction::{call,construct}() to ThrowCompletionOr Both at the same time because many of them call construct() in call() and I'm not keen on adding a bunch of temporary plumbing to turn exceptions into throw completions. Also changes the return value of construct() to Object* instead of Value as it always needs to return an object; allowing an arbitrary Value is a massive foot gun.
2021-10-20 17:16:30 -03:00
auto pattern_constructor = TRY(pattern.as_object().get(vm.names.constructor));
LibJS: Implement RegExp constructor according to the spec This allows passing an existing RegExp object (or an object that is sufficiently like a RegExp object) as the "pattern" argument of the RegExp constructor.
2021-07-08 14:36:09 -03:00
if (same_value(this, pattern_constructor))
return pattern;
}
LibJS: Convert NativeFunction::{call,construct}() to ThrowCompletionOr Both at the same time because many of them call construct() in call() and I'm not keen on adding a bunch of temporary plumbing to turn exceptions into throw completions. Also changes the return value of construct() to Object* instead of Value as it always needs to return an object; allowing an arbitrary Value is a massive foot gun.
2021-10-20 17:16:30 -03:00
return TRY(construct(*this));
LibJS: Lex and parse regex literals, add RegExp objects This adds regex parsing/lexing, as well as a relatively empty RegExpObject. The purpose of this patch is to allow the engine to not get hung up on parsing regexes. This will aid in finding new syntax errors (say, from google or twitter) without having to replace all of their regexes first!
2020-06-03 20:05:49 -03:00
}
LibJS: Add a bunch more missing ECMA-262 section/title/URL comments
2021-06-18 20:38:41 -03:00
// 22.2.3.1 RegExp ( pattern, flags ), https://tc39.es/ecma262/#sec-regexp-pattern-flags
LibJS: Convert NativeFunction::{call,construct}() to ThrowCompletionOr Both at the same time because many of them call construct() in call() and I'm not keen on adding a bunch of temporary plumbing to turn exceptions into throw completions. Also changes the return value of construct() to Object* instead of Value as it always needs to return an object; allowing an arbitrary Value is a massive foot gun.
2021-10-20 17:16:30 -03:00
ThrowCompletionOr<Object*> RegExpConstructor::construct(FunctionObject&)
LibJS: Lex and parse regex literals, add RegExp objects This adds regex parsing/lexing, as well as a relatively empty RegExpObject. The purpose of this patch is to allow the engine to not get hung up on parsing regexes. This will aid in finding new syntax errors (say, from google or twitter) without having to replace all of their regexes first!
2020-06-03 20:05:49 -03:00
{
LibJS: Make native function/property callbacks take VM, not Interpreter More work on decoupling the general runtime from Interpreter. The goal is becoming clearer. Interpreter should be one possible way to execute code inside a VM. In the future we might have other ways :^)
2020-09-27 13:36:49 -03:00
auto& vm = this->vm();
LibJS: Implement RegExp constructor according to the spec This allows passing an existing RegExp object (or an object that is sufficiently like a RegExp object) as the "pattern" argument of the RegExp constructor.
2021-07-08 14:36:09 -03:00
auto pattern = vm.argument(0);
auto flags = vm.argument(1);
LibJS: Replace GlobalObject with VM in Value AOs [Part 4/19] This is where the fun begins. :^)
2022-08-21 10:00:56 -03:00
bool pattern_is_regexp = TRY(pattern.is_regexp(vm));
LibJS: Implement RegExp constructor according to the spec This allows passing an existing RegExp object (or an object that is sufficiently like a RegExp object) as the "pattern" argument of the RegExp constructor.
2021-07-08 14:36:09 -03:00
Value pattern_value;
Value flags_value;
if (pattern.is_object() && is<RegExpObject>(pattern.as_object())) {
auto& regexp_pattern = static_cast<RegExpObject&>(pattern.as_object());
pattern_value = js_string(vm, regexp_pattern.pattern());
if (flags.is_undefined())
flags_value = js_string(vm, regexp_pattern.flags());
else
flags_value = flags;
} else if (pattern_is_regexp) {
LibJS: Convert NativeFunction::{call,construct}() to ThrowCompletionOr Both at the same time because many of them call construct() in call() and I'm not keen on adding a bunch of temporary plumbing to turn exceptions into throw completions. Also changes the return value of construct() to Object* instead of Value as it always needs to return an object; allowing an arbitrary Value is a massive foot gun.
2021-10-20 17:16:30 -03:00
pattern_value = TRY(pattern.as_object().get(vm.names.source));
LibJS: Implement RegExp constructor according to the spec This allows passing an existing RegExp object (or an object that is sufficiently like a RegExp object) as the "pattern" argument of the RegExp constructor.
2021-07-08 14:36:09 -03:00
if (flags.is_undefined()) {
LibJS: Convert NativeFunction::{call,construct}() to ThrowCompletionOr Both at the same time because many of them call construct() in call() and I'm not keen on adding a bunch of temporary plumbing to turn exceptions into throw completions. Also changes the return value of construct() to Object* instead of Value as it always needs to return an object; allowing an arbitrary Value is a massive foot gun.
2021-10-20 17:16:30 -03:00
flags_value = TRY(pattern.as_object().get(vm.names.flags));
LibJS: Implement RegExp constructor according to the spec This allows passing an existing RegExp object (or an object that is sufficiently like a RegExp object) as the "pattern" argument of the RegExp constructor.
2021-07-08 14:36:09 -03:00
} else {
flags_value = flags;
}
} else {
pattern_value = pattern;
flags_value = flags;
}
LibJS: Replace GlobalObject with VM in RegExp AOs [Part 9/19]
2022-08-21 12:14:51 -03:00
return TRY(regexp_create(vm, pattern_value, flags_value));
LibJS: Lex and parse regex literals, add RegExp objects This adds regex parsing/lexing, as well as a relatively empty RegExpObject. The purpose of this patch is to allow the engine to not get hung up on parsing regexes. This will aid in finding new syntax errors (say, from google or twitter) without having to replace all of their regexes first!
2020-06-03 20:05:49 -03:00
}
LibJS: Add a bunch more missing ECMA-262 section/title/URL comments
2021-06-18 20:38:41 -03:00
// 22.2.4.2 get RegExp [ @@species ], https://tc39.es/ecma262/#sec-get-regexp-@@species
LibJS: Convert RegExpConstructor functions to ThrowCompletionOr
2021-10-22 21:52:55 -03:00
JS_DEFINE_NATIVE_FUNCTION(RegExpConstructor::symbol_species_getter)
LibJS: Add the Symbol.species getter to the appropriate built-ins
2021-06-07 13:31:32 -03:00
{
LibJS: Remove GlobalObject from VM::this_value() This is a continuation of the previous six commits. The global object is only needed to return it if the execution context stack is empty, but that doesn't seem like a useful thing to allow in the first place - if you're not currently executing JS, and the execution context stack is empty, there is no this value to retrieve.
2022-08-20 05:48:43 -03:00
return vm.this_value();
LibJS: Add the Symbol.species getter to the appropriate built-ins
2021-06-07 13:31:32 -03:00
}
LibJS: Lex and parse regex literals, add RegExp objects This adds regex parsing/lexing, as well as a relatively empty RegExpObject. The purpose of this patch is to allow the engine to not get hung up on parsing regexes. This will aid in finding new syntax errors (say, from google or twitter) without having to replace all of their regexes first!
2020-06-03 20:05:49 -03:00
}
Reference in a new issue Copy permalink