dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ladybird/Libraries/LibWeb/CSS/StyleSheetList.h

75 lines
2.5 KiB
C
Raw Normal View History

LibWeb: Process style sheets in document order Until now we would simply apply stylesheets in the order they finished loading. This patch adds a StyleSheetList object that hangs off of each Document and contains all the style sheets in document order. There's still a lot of work to do for a proper cascade, but at least this makes us consistently wrong every time. :^)
2020-06-04 11:06:32 -03:00
/*
LibWeb: Only invalidate shadow root when style sheet inside changes We don't have to invalidate style for the entire document when a style sheet changes inside of a shadow root. To make this possible, StyleSheetList now keeps track of which Document-or-ShadowRoot it corresponds to, instead of just tracking the containing Document. This avoids a lot of style recomputation on pages with lots of shadow DOM content (like GitHub).
2024-08-20 09:55:28 -03:00
* Copyright (c) 2020-2024, Andreas Kling <andreas@ladybird.org>
LibWeb: Restore proper functionality of legacy platform objects With the GC heap conversion, the functionality of legacy platform objects was broken. This is because the generated implementation of one of them was used for all of them, removing functionality such as deletion. This re-adds all functionality, where questions such as "does the object support indexed properties?" is instead answered by virtual functions instead of by the IDL generator checking the presence of certain keywords/attributes.
2023-02-27 21:05:39 -03:00
* Copyright (c) 2023, Luke Wilde <lukew@serenityos.org>
LibWeb: Move style sheet parsing into `create_a_css_style_sheet()` The spec is unclear about when exactly we should parse the style sheet. Previously we'd do so before calling this algorithm, which was error-prone, as seen by the bug fixed by the previous commit. The spec for step 1 of "create a CSS style sheet" says: 1. Create a new CSS style sheet object and set its properties as specified. The definitions linked are UA-defined enough that it seems reasonable to put the parsing here. That simplifies the user code a little and makes it harder to mess up. It does raise the question of what to do if parsing fails. I've matched our previous behaviour by just logging and returning in that case. While I'm modifying this method, I've also converted the bool params to enums so they're a little clearer to read.
2025-04-14 09:53:11 -03:00
* Copyright (c) 2025, Sam Atkins <sam@ladybird.org>
LibWeb: Process style sheets in document order Until now we would simply apply stylesheets in the order they finished loading. This patch adds a StyleSheetList object that hangs off of each Document and contains all the style sheets in document order. There's still a lot of work to do for a proper cascade, but at least this makes us consistently wrong every time. :^)
2020-06-04 11:06:32 -03:00
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 05:24:48 -03:00
* SPDX-License-Identifier: BSD-2-Clause
LibWeb: Process style sheets in document order Until now we would simply apply stylesheets in the order they finished loading. This patch adds a StyleSheetList object that hangs off of each Document and contains all the style sheets in document order. There's still a lot of work to do for a proper cascade, but at least this makes us consistently wrong every time. :^)
2020-06-04 11:06:32 -03:00
*/
#pragma once
LibWeb: Delete LegacyPlatformObject and move behavior to PlatformObject We have two known PlatformObjects that need to implement some of the behavior of LegacyPlatformObjects to date: Window, and HTMLFormElement. To make this not require double (or virtual) inheritance of PlatformObject, move the behavior of LegacyPlatformObject into PlatformObject. The selection of LegacyPlatformObject behavior is done with a new bitfield of feature flags instead of a dozen virtual functions that return bool. This change simplifies every class involved in the diff with the notable exception of Window, which now needs some ugly const casts to implement named property access.
2024-01-09 20:05:03 -03:00
#include <LibWeb/Bindings/PlatformObject.h>
LibWeb: Start exposing CSS style sheets to JavaScript :^) This patch adds bindings for the following objects: - StyleSheet - StyleSheetList - CSSStyleSheet You can get to a document's style sheets via Document.styleSheets and iterate through them using StyleSheetList's item() and length(). That's it in terms of functionality at this point, but still neat. :^)
2021-03-08 07:22:18 -03:00
#include <LibWeb/CSS/CSSStyleSheet.h>
LibWeb: Enable EXPLICIT_SYMBOL_EXPORT
2025-07-19 23:35:33 -03:00
#include <LibWeb/Export.h>
LibWeb: Process style sheets in document order Until now we would simply apply stylesheets in the order they finished loading. This patch adds a StyleSheetList object that hangs off of each Document and contains all the style sheets in document order. There's still a lot of work to do for a proper cascade, but at least this makes us consistently wrong every time. :^)
2020-06-04 11:06:32 -03:00
LibWeb: Use "namespace Web::Foo {" since C++20 allows it :^) Thanks @nico for teaching me about this!
2020-07-21 11:23:08 -03:00
namespace Web::CSS {
LibWeb: Process style sheets in document order Until now we would simply apply stylesheets in the order they finished loading. This patch adds a StyleSheetList object that hangs off of each Document and contains all the style sheets in document order. There's still a lot of work to do for a proper cascade, but at least this makes us consistently wrong every time. :^)
2020-06-04 11:06:32 -03:00
LibWeb: Enable EXPLICIT_SYMBOL_EXPORT
2025-07-19 23:35:33 -03:00
class WEB_API StyleSheetList final : public Bindings::PlatformObject {
LibWeb: Delete LegacyPlatformObject and move behavior to PlatformObject We have two known PlatformObjects that need to implement some of the behavior of LegacyPlatformObjects to date: Window, and HTMLFormElement. To make this not require double (or virtual) inheritance of PlatformObject, move the behavior of LegacyPlatformObject into PlatformObject. The selection of LegacyPlatformObject behavior is done with a new bitfield of feature flags instead of a dozen virtual functions that return bool. This change simplifies every class involved in the diff with the notable exception of Window, which now needs some ugly const casts to implement named property access.
2024-01-09 20:05:03 -03:00
WEB_PLATFORM_OBJECT(StyleSheetList, Bindings::PlatformObject);
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-14 12:01:23 -03:00
GC_DECLARE_ALLOCATOR(StyleSheetList);
LibWeb: Start exposing CSS style sheets to JavaScript :^) This patch adds bindings for the following objects: - StyleSheet - StyleSheetList - CSSStyleSheet You can get to a document's style sheets via Document.styleSheets and iterate through them using StyleSheetList's item() and length(). That's it in terms of functionality at this point, but still neat. :^)
2021-03-08 07:22:18 -03:00
LibWeb: Make StyleSheetList GC-allocated
2022-08-07 08:29:49 -03:00
public:
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-14 12:01:23 -03:00
[[nodiscard]] static GC::Ref<StyleSheetList> create(GC::Ref<DOM::Node> document_or_shadow_root);
LibWeb: Process style sheets in document order Until now we would simply apply stylesheets in the order they finished loading. This patch adds a StyleSheetList object that hangs off of each Document and contains all the style sheets in document order. There's still a lot of work to do for a proper cascade, but at least this makes us consistently wrong every time. :^)
2020-06-04 11:06:32 -03:00
LibWeb: Move style sheet parsing into `create_a_css_style_sheet()` The spec is unclear about when exactly we should parse the style sheet. Previously we'd do so before calling this algorithm, which was error-prone, as seen by the bug fixed by the previous commit. The spec for step 1 of "create a CSS style sheet" says: 1. Create a new CSS style sheet object and set its properties as specified. The definitions linked are UA-defined enough that it seems reasonable to put the parsing here. That simplifies the user code a little and makes it harder to mess up. It does raise the question of what to do if parsing fails. I've matched our previous behaviour by just logging and returning in that case. While I'm modifying this method, I've also converted the bool params to enums so they're a little clearer to read.
2025-04-14 09:53:11 -03:00
void add_a_css_style_sheet(CSSStyleSheet&);
void remove_a_css_style_sheet(CSSStyleSheet&);
enum class Alternate : u8 {
No,
Yes,
};
enum class OriginClean : u8 {
No,
Yes,
};
LibWeb/CSS: Return GC::Ref from style sheet parsing methods These actually always return a value, despite the `CSSStyleSheet*` return type. So, make that clearer by returning `GC::Ref<CSSStyleSheet>` instead. This also means we can remove some ad-hoc error-checking code.
2025-04-14 10:04:36 -03:00
GC::Ref<CSSStyleSheet> create_a_css_style_sheet(String const& css_text, String type, DOM::Element* owner_node, String media, String title, Alternate, OriginClean, Optional<::URL::URL> location, CSSStyleSheet* parent_style_sheet, CSSRule* owner_rule);
LibWeb: Reimplement the <style> element following the spec We now follow the "update a style block" algorithm from the HTML spec instead of using the ad-hoc CSSLoader mechanism. This necessitated improving our StyleSheet and CSSStyleSheet classes as well, so that's baked into this commit.
2021-09-29 18:46:16 -03:00
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-14 12:01:23 -03:00
Vector<GC::Ref<CSSStyleSheet>> const& sheets() const { return m_sheets; }
Vector<GC::Ref<CSSStyleSheet>>& sheets() { return m_sheets; }
LibWeb: Start exposing CSS style sheets to JavaScript :^) This patch adds bindings for the following objects: - StyleSheet - StyleSheetList - CSSStyleSheet You can get to a document's style sheets via Document.styleSheets and iterate through them using StyleSheetList's item() and length(). That's it in terms of functionality at this point, but still neat. :^)
2021-03-08 07:22:18 -03:00
LibWeb: Make StyleSheet and CSSStyleSheet GC-allocated
2022-08-07 08:14:54 -03:00
CSSStyleSheet* item(size_t index) const
LibWeb: Start exposing CSS style sheets to JavaScript :^) This patch adds bindings for the following objects: - StyleSheet - StyleSheetList - CSSStyleSheet You can get to a document's style sheets via Document.styleSheets and iterate through them using StyleSheetList's item() and length(). That's it in terms of functionality at this point, but still neat. :^)
2021-03-08 07:22:18 -03:00
{
if (index >= m_sheets.size())
return {};
LibWeb: Keep CSS sheets sorted in document tree order This ensures that style is applied consistently, even if the document has external CSS resources that don't always arrive in the same order.
2022-09-09 06:08:56 -03:00
return const_cast<CSSStyleSheet*>(m_sheets[index].ptr());
LibWeb: Start exposing CSS style sheets to JavaScript :^) This patch adds bindings for the following objects: - StyleSheet - StyleSheetList - CSSStyleSheet You can get to a document's style sheets via Document.styleSheets and iterate through them using StyleSheetList's item() and length(). That's it in terms of functionality at this point, but still neat. :^)
2021-03-08 07:22:18 -03:00
}
LibWeb: Process style sheets in document order Until now we would simply apply stylesheets in the order they finished loading. This patch adds a StyleSheetList object that hangs off of each Document and contains all the style sheets in document order. There's still a lot of work to do for a proper cascade, but at least this makes us consistently wrong every time. :^)
2020-06-04 11:06:32 -03:00
LibWeb: Start exposing CSS style sheets to JavaScript :^) This patch adds bindings for the following objects: - StyleSheet - StyleSheetList - CSSStyleSheet You can get to a document's style sheets via Document.styleSheets and iterate through them using StyleSheetList's item() and length(). That's it in terms of functionality at this point, but still neat. :^)
2021-03-08 07:22:18 -03:00
size_t length() const { return m_sheets.size(); }
LibWeb: Process style sheets in document order Until now we would simply apply stylesheets in the order they finished loading. This patch adds a StyleSheetList object that hangs off of each Document and contains all the style sheets in document order. There's still a lot of work to do for a proper cascade, but at least this makes us consistently wrong every time. :^)
2020-06-04 11:06:32 -03:00
Bindings: Make item_value return an Optional<JS::Value> This removes some ambiguity about what the return value should be if the index is out of range. Previously, we would sometimes return a JS null, and other times a JS undefined. It will also let us fold together the checks for whether an index is a supported property index, followed by getting the value just afterwards.
2024-07-25 03:15:51 -03:00
virtual Optional<JS::Value> item_value(size_t index) const override;
LibWeb: Make StyleSheetList.item an IDL getter
2021-09-29 09:03:09 -03:00
LibWeb: Only invalidate shadow root when style sheet inside changes We don't have to invalidate style for the entire document when a style sheet changes inside of a shadow root. To make this possible, StyleSheetList now keeps track of which Document-or-ShadowRoot it corresponds to, instead of just tracking the containing Document. This avoids a lot of style recomputation on pages with lots of shadow DOM content (like GitHub).
2024-08-20 09:55:28 -03:00
[[nodiscard]] DOM::Document& document();
[[nodiscard]] DOM::Document const& document() const;
[[nodiscard]] DOM::Node& document_or_shadow_root() { return m_document_or_shadow_root; }
[[nodiscard]] DOM::Node const& document_or_shadow_root() const { return m_document_or_shadow_root; }
LibWeb: Invalidate style after CSSStyleSheet.{insert,remove}Rule() When rules are inserted or removed via the CSSOM API, we now invalidate document style to ensure that any changes made are reflected. 1% progression on ACID3. :^)
2022-03-09 15:57:15 -03:00
LibWeb: Process style sheets in document order Until now we would simply apply stylesheets in the order they finished loading. This patch adds a StyleSheetList object that hangs off of each Document and contains all the style sheets in document order. There's still a lot of work to do for a proper cascade, but at least this makes us consistently wrong every time. :^)
2020-06-04 11:06:32 -03:00
private:
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-14 12:01:23 -03:00
explicit StyleSheetList(GC::Ref<DOM::Node> document_or_shadow_root);
LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated This is a monster patch that turns all EventTargets into GC-allocated PlatformObjects. Their C++ wrapper classes are removed, and the LibJS garbage collector is now responsible for their lifetimes. There's a fair amount of hacks and band-aids in this patch, and we'll have a lot of cleanup to do after this.
2022-08-28 08:42:07 -03:00
LibJS: Make Cell::initialize() return void Stop worrying about tiny OOMs. Work towards #20405
2023-08-07 03:41:28 -03:00
virtual void initialize(JS::Realm&) override;
LibWeb: Make StyleSheetList GC-allocated
2022-08-07 08:29:49 -03:00
virtual void visit_edges(Cell::Visitor&) override;
LibWeb: Process style sheets in document order Until now we would simply apply stylesheets in the order they finished loading. This patch adds a StyleSheetList object that hangs off of each Document and contains all the style sheets in document order. There's still a lot of work to do for a proper cascade, but at least this makes us consistently wrong every time. :^)
2020-06-04 11:06:32 -03:00
LibWeb: Unset stylesheet properties when removing from a StyleSheetList Previously, the parent CSS stylesheet, owner node and owner CSS rule properties were not unset when removing a sheet from a StyleSheetList. This change moves the methods for adding and removing sheets to and from a StyleSheetList, directly into the StyleSheetList class and ensures they are called as required by the CSSOM specification.
2024-04-15 17:42:46 -03:00
void add_sheet(CSSStyleSheet&);
void remove_sheet(CSSStyleSheet&);
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-14 12:01:23 -03:00
GC::Ref<DOM::Node> m_document_or_shadow_root;
Vector<GC::Ref<CSSStyleSheet>> m_sheets;
LibWeb: Flesh out `StyleSheetList::add_a_css_style_sheet()` steps This is required to support loading alternative style sheets.
2024-04-16 18:59:40 -03:00
// https://www.w3.org/TR/cssom/#preferred-css-style-sheet-set-name
String m_preferred_css_style_sheet_set_name;
// https://www.w3.org/TR/cssom/#last-css-style-sheet-set-name
Optional<String> m_last_css_style_sheet_set_name;
LibWeb: Process style sheets in document order Until now we would simply apply stylesheets in the order they finished loading. This patch adds a StyleSheetList object that hangs off of each Document and contains all the style sheets in document order. There's still a lot of work to do for a proper cascade, but at least this makes us consistently wrong every time. :^)
2020-06-04 11:06:32 -03:00
};
}
Reference in a new issue Copy permalink