dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Create selection range when enabling designMode

Browse source 
Previously, setting designMode to "on" would only modify the selection
range if one already existed. Since selections start empty, this meant
no range was created and no selectionchange event was fired.

Use Selection::collapse() instead, which creates a new range if needed
and properly triggers the selectionchange event.
This commit is contained in:
Jelle Raaijmakers 2026-01-12 16:56:54 +01:00 committed by Jelle Raaijmakers
parent 64f1e6e11a
commit 1bef8b259a
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibWeb/DOM/Document.cpp
View file

@ -5659,12 +5659,9 @@ WebIDL::ExceptionOr<void> Document::set_design_mode(String const& design_mode)
// 1. Set this's design mode enabled to true.
set_design_mode_enabled_state(true);
// 2. Reset this's active range's start and end boundary points to be at the start of this.
if (auto selection = get_selection(); selection) {
if (auto active_range = selection->range(); active_range) {
TRY(active_range->set_start(*this, 0));
TRY(active_range->set_end(*this, 0));
update_layout(UpdateLayoutReason::DocumentSetDesignMode);
}
if (auto selection = get_selection()) {
TRY(selection->collapse(this, 0));
update_layout(UpdateLayoutReason::DocumentSetDesignMode);
}
// 3. Run the focusing steps for this's document element, if non-null.
if (auto* document_element = this->document_element(); document_element)