dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Tests/LibJS: Enable test-js on Windows

Browse source
This commit is contained in:
ayeteadoe 2025-08-07 13:25:30 -07:00 committed by Andrew Kaster
parent 79b30e7c9a
commit 3355b7fb1f
2 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibJS/CMakeLists.txt
View file

@ -286,6 +286,9 @@ endif()
target_link_libraries(LibJS PUBLIC JSClangPlugin)
# TODO: Use lagom_generate_export_header and annotate entire LibJS with export macros
include(GenerateExportHeader)
generate_export_header(LibJS EXPORT_MACRO_NAME JS_API EXPORT_FILE_NAME "Export.h")
if (ENABLE_WINDOWS_CI)
# FIXME: Fix address sanitizer stack-overflow error when running test-js.
# Even tripling the stack size for this target to 24MB didn't fix it, so it is most likely some ASAN related bug/quirk given test-js passes using the 8MB stack without ASAN
# ==9948==ERROR: AddressSanitizer: stack-overflow on address 0x7ffd983a6f47 (pc 0x7ffd983a6f47 bp 0x004e514053e0 sp 0x004e51405348 T0)
target_compile_options(LibJS PRIVATE -fno-sanitize=address)
endif()

5
Tests/LibJS/CMakeLists.txt
View file

@ -1,10 +1,5 @@
ladybird_test(test-invalid-unicode-js.cpp LibJS LIBS LibJS LibUnicode)
ladybird_test(test-value-js.cpp LibJS LIBS LibJS LibUnicode)
# FIXME: This test is currently not working in the windows-2025 GHA image due to the Visual Studio version currently being used
if (WIN32 AND ENABLE_WINDOWS_CI)
return()
endif()
ladybird_testjs_test(test-js.cpp test-js LIBS LibGC)
set_tests_properties(test-js PROPERTIES ENVIRONMENT LADYBIRD_SOURCE_DIR=${LADYBIRD_PROJECT_ROOT})