dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

AK: Remove unused SegmentedVector

Browse source 
Display lists were the last user of SegmentedVector before the flat
command buffer replaced that storage. With no remaining includes, remove
the container and its unit test.
This commit is contained in:
Aliaksandr Kalenik 2026-05-08 18:10:40 +02:00 committed by Alexander Kalenik
parent 998ec2af83
commit 4bbfe7eedd
3 changed files with 0 additions and 100 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

71
AK/SegmentedVector.h
View file

@ -1,71 +0,0 @@
/*
* Copyright (c) 2023, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <AK/OwnPtr.h>
#include <AK/Vector.h>
namespace AK {
template<typename T, int segment_size = 512>
class SegmentedVector {
private:
using VisibleType = RemoveReference<T>;
static constexpr bool contains_reference = IsLvalueReference<T>;
public:
SegmentedVector() = default;
size_t size() const { return m_size; }
bool is_empty() const { return m_size == 0; }
using Iterator = SimpleIterator<SegmentedVector, VisibleType>;
using ConstIterator = SimpleIterator<SegmentedVector const, VisibleType const>;
Iterator begin() { return Iterator::begin(*this); }
ConstIterator begin() const { return ConstIterator::begin(*this); }
Iterator end() { return Iterator::end(*this); }
ConstIterator end() const { return ConstIterator::end(*this); }
ALWAYS_INLINE VisibleType const& at(size_t i) const
{
VERIFY(i < m_size);
auto segment_index = i / segment_size;
auto index_in_segment = i % segment_size;
return m_segments[segment_index]->at(index_in_segment);
}
ALWAYS_INLINE VisibleType& at(size_t i)
{
VERIFY(i < m_size);
auto segment_index = i / segment_size;
auto index_in_segment = i % segment_size;
return m_segments[segment_index]->at(index_in_segment);
}
ALWAYS_INLINE VisibleType const& operator[](size_t i) const { return at(i); }
ALWAYS_INLINE VisibleType& operator[](size_t i) { return at(i); }
void append(T&& value)
{
if (m_segments.is_empty() || m_segments.last()->size() >= segment_size)
m_segments.append(make<Vector<T, segment_size>>());
if constexpr (contains_reference) {
m_segments.last()->append(value);
} else {
m_segments.last()->append(move(value));
}
++m_size;
}
private:
Vector<NonnullOwnPtr<Vector<T, segment_size>>> m_segments;
size_t m_size { 0 };
};
}

1
Tests/AK/CMakeLists.txt
View file

@ -60,7 +60,6 @@ set(AK_TEST_SOURCES
TestRandom.cpp
TestRedBlackTree.cpp
TestRefPtr.cpp
TestSegmentedVector.cpp
TestSinglyLinkedList.cpp
TestSourceGenerator.cpp
TestSourceLocation.cpp

28
Tests/AK/TestSegmentedVector.cpp
View file

@ -1,28 +0,0 @@
/*
* Copyright (c) 2023, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <AK/SegmentedVector.h>
#include <LibTest/TestCase.h>
TEST_CASE(append)
{
AK::SegmentedVector<int, 2> segmented_vector;
segmented_vector.append(1);
segmented_vector.append(2);
segmented_vector.append(3);
EXPECT_EQ(segmented_vector.size(), 3u);
}
TEST_CASE(at)
{
AK::SegmentedVector<int, 2> segmented_vector;
segmented_vector.append(1);
segmented_vector.append(2);
segmented_vector.append(3);
EXPECT_EQ(segmented_vector[0], 1);
EXPECT_EQ(segmented_vector[1], 2);
EXPECT_EQ(segmented_vector[2], 3);
}