dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Clang-tidy up HTMLMediaElement a bit

Browse source
This commit is contained in:
Zaggy1024 2026-02-25 17:25:27 -06:00 committed by Gregory Bertilson
parent 7ee96285e2
commit 4bfa0d408e
3 changed files with 12 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/Forward.h
View file

@ -862,7 +862,6 @@ class WorkerNavigator;
class XMLSerializer;
enum class AllowMultipleFiles;
enum class MediaSeekMode;
enum class RequireWellFormed;
enum class SandboxingFlagSet;

6
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View file

@ -650,7 +650,7 @@ WebIDL::ExceptionOr<void> HTMLMediaElement::load_element()
return {};
}
enum class SelectMode {
enum class SelectMode : u8 {
Object,
Attribute,
Children,
@ -711,7 +711,7 @@ public:
// 9. Run the resource fetch algorithm with urlRecord. If that algorithm returns without aborting this one, then
// the load failed.
m_media_element->fetch_resource(*url_record, [self = GC::make_root(this)](auto) { self->failed_with_elements().release_value_but_fixme_should_propagate_errors(); });
m_media_element->fetch_resource(*url_record, [self = GC::make_root(this)](auto const&) { self->failed_with_elements().release_value_but_fixme_should_propagate_errors(); });
return {};
}
@ -1133,7 +1133,7 @@ void HTMLMediaElement::fetch_resource(NonnullRefPtr<FetchData> const& fetch_data
// 4. If the result of verifying response given the current media resource and byteRange is false, then abort these steps.
// NOTE: We do this step before creating the updateMedia task so that we can invoke the failure callback.
auto maybe_verify_response_failure = weak_self->verify_response_or_get_failure_reason(response, byte_range, fetch_data);
auto maybe_verify_response_failure = verify_response_or_get_failure_reason(response, byte_range, fetch_data);
if (maybe_verify_response_failure.has_value()) {
fetch_data->failure_callback(maybe_verify_response_failure.value());
return;

18
Libraries/LibWeb/HTML/HTMLMediaElement.h
View file

@ -26,7 +26,7 @@
namespace Web::HTML {
enum class MediaSeekMode {
enum class MediaSeekMode : u8 {
Accurate,
ApproximateForSpeed,
};
@ -56,7 +56,7 @@ public:
String const& current_src() const { return m_current_src; }
void select_resource();
enum class NetworkState : u16 {
enum class NetworkState : u8 {
Empty,
Idle,
Loading,
@ -68,13 +68,13 @@ public:
[[nodiscard]] GC::Ref<TimeRanges> played() const;
[[nodiscard]] GC::Ref<TimeRanges> seekable() const;
static inline constexpr auto supported_video_subtypes = Array {
static constexpr auto supported_video_subtypes = Array {
"webm"sv,
"mp4"sv,
"mpeg"sv,
"ogg"sv,
};
static inline constexpr auto supported_audio_subtypes = Array {
static constexpr auto supported_audio_subtypes = Array {
"flac"sv,
"mp3"sv,
"mpeg"sv,
@ -84,7 +84,7 @@ public:
};
Bindings::CanPlayTypeResult can_play_type(StringView type) const;
enum class ReadyState : u16 {
enum class ReadyState : u8 {
HaveNothing,
HaveMetadata,
HaveCurrentData,
@ -183,12 +183,12 @@ private:
struct FetchData;
void fetch_resource(NonnullRefPtr<FetchData> const&, ByteRange const&);
Optional<String> verify_response_or_get_failure_reason(GC::Ref<Fetch::Infrastructure::Response>, ByteRange const&, NonnullRefPtr<FetchData> const&);
static Optional<String> verify_response_or_get_failure_reason(GC::Ref<Fetch::Infrastructure::Response>, ByteRange const&, NonnullRefPtr<FetchData> const&);
void restart_fetch_at_offset(FetchData&, u64 offset);
void set_up_playback_manager(NonnullRefPtr<FetchData> const&);
enum class FetchingStatus {
enum class FetchingStatus : u8 {
Ongoing,
Complete,
};
@ -229,7 +229,7 @@ private:
void dispatch_time_update_event();
enum class TimeMarchesOnReason {
enum class TimeMarchesOnReason : u8 {
NormalPlayback,
Other,
};
@ -250,7 +250,7 @@ private:
}
// https://html.spec.whatwg.org/multipage/media.html#media-element-event-task-source
UniqueTaskSource m_media_element_event_task_source {};
UniqueTaskSource m_media_element_event_task_source;
// https://html.spec.whatwg.org/multipage/media.html#dom-media-error
GC::Ptr<MediaError> m_error;