dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

AK: Remove HashMap::hash()

Browse source 
Using `pair_int_hash()` which subsequently uses `int_hash()` means that
ordering of the input is important. Since this operates on unordered
HashMaps as well, order of the keys and values is dependent on the
internal implementation of HashTable and might differ between HashMaps
with identical contents, making this implementation of `::hash()` not
that useful.

Fortunately, it is unused, so let's remove this footgun.
This commit is contained in:
Jelle Raaijmakers 2026-01-28 13:34:48 +01:00 committed by Jelle Raaijmakers
parent 887ed85877
commit 4c58be255a
1 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
AK/HashMap.h
View file

@ -301,16 +301,6 @@ public:
return list; return list;
} }
[[nodiscard]] u32 hash() const
{
u32 hash = 0;
for (auto const& [key, value] : *this) {
auto entry_hash = pair_int_hash(key.hash(), value.hash());
hash = pair_int_hash(hash, entry_hash);
}
return hash;
}
template<typename NewKeyTraits = KeyTraits, typename NewValueTraits = ValueTraits, bool NewIsOrdered = IsOrdered> template<typename NewKeyTraits = KeyTraits, typename NewValueTraits = ValueTraits, bool NewIsOrdered = IsOrdered>
ErrorOr<HashMap<K, V, NewKeyTraits, NewValueTraits, NewIsOrdered>> clone() const ErrorOr<HashMap<K, V, NewKeyTraits, NewValueTraits, NewIsOrdered>> clone() const
{ {