dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Deal with legacy event types for event dispatch optimization

Browse source 
We forgot to handle legacy transition events such as
`webkitAnimationEnd` in the optimization introduced in
57c9bb5caa, causing Google's sign-in to
fail on the password screen.

Fixes #8995
This commit is contained in:
Jelle Raaijmakers 2026-05-31 16:00:54 +02:00 committed by Andreas Kling
parent 756be80c8e
commit 4e31aaf368
3 changed files with 56 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
Libraries/LibWeb/DOM/EventDispatcher.cpp
View file

@ -6,6 +6,7 @@
*/
#include <AK/Assertions.h>
#include <AK/Optional.h>
#include <AK/TypeCasts.h>
#include <LibJS/Runtime/AbstractOperations.h>
#include <LibJS/Runtime/FunctionObject.h>
@ -31,6 +32,20 @@
namespace Web::DOM {
// https://dom.spec.whatwg.org/#concept-event-listener-invoke
static Optional<FlyString> legacy_event_type_for_event_type(FlyString const& event_type)
{
if (event_type == HTML::EventNames::animationend)
return HTML::EventNames::webkitAnimationEnd;
if (event_type == HTML::EventNames::animationiteration)
return HTML::EventNames::webkitAnimationIteration;
if (event_type == HTML::EventNames::animationstart)
return HTML::EventNames::webkitAnimationStart;
if (event_type == HTML::EventNames::transitionend)
return HTML::EventNames::webkitTransitionEnd;
return {};
}
// https://dom.spec.whatwg.org/#concept-event-listener-inner-invoke
bool EventDispatcher::inner_invoke(Event& event, Vector<GC::Root<DOM::DOMEventListener>>& listeners, Event::Phase phase, bool invocation_target_in_shadow_tree, bool& legacy_output_did_listeners_throw)
{
@ -164,16 +179,10 @@ void EventDispatcher::invoke(Event::PathEntry& struct_, Event& event, Event::Pha
// 2. If event’s type attribute value is a match for any of the strings in the first column in the following table,
// set event’s type attribute value to the string in the second column on the same row as the matching string, and return otherwise.
if (event.type() == HTML::EventNames::animationend)
event.set_type(HTML::EventNames::webkitAnimationEnd);
else if (event.type() == HTML::EventNames::animationiteration)
event.set_type(HTML::EventNames::webkitAnimationIteration);
else if (event.type() == HTML::EventNames::animationstart)
event.set_type(HTML::EventNames::webkitAnimationStart);
else if (event.type() == HTML::EventNames::transitionend)
event.set_type(HTML::EventNames::webkitTransitionEnd);
else
auto legacy_event_type = legacy_event_type_for_event_type(event.type());
if (!legacy_event_type.has_value())
return;
event.set_type(legacy_event_type.release_value());
// 3. Inner invoke with event, listeners, phase, invocationTargetInShadowTree, and legacyOutputDidListenersThrowFlag if given.
inner_invoke(event, listeners, phase, invocation_target_in_shadow_tree, legacy_output_did_listeners_throw);
@ -222,6 +231,10 @@ bool EventDispatcher::dispatch(GC::Ref<EventTarget> target, Event& event, bool l
if (!should_dispatch) {
auto const* node = as_if<Node>(*target);
should_dispatch = !node || node->has_inclusive_ancestor_with_event_listener(event.type());
if (!should_dispatch && event.is_trusted()) {
if (auto legacy_event_type = legacy_event_type_for_event_type(event.type()); legacy_event_type.has_value())
should_dispatch = node->has_inclusive_ancestor_with_event_listener(*legacy_event_type);
}
}
// 6. If target is not relatedTarget or target is event’s relatedTarget, then:

3
Tests/LibWeb/Text/expected/css/transition-legacy-event-listener.txt Normal file
View file

@ -0,0 +1,3 @@
legacy transitionend event count: 1
legacy transitionend event type: webkitTransitionEnd
legacy transitionend property name: opacity

31
Tests/LibWeb/Text/input/css/transition-legacy-event-listener.html Normal file
View file

@ -0,0 +1,31 @@
<!DOCTYPE html>
<style>
#target {
opacity: 0;
transition: opacity 20ms linear;
}
</style>
<div id="target"></div>
<script src="../include.js"></script>
<script>
asyncTest(async done => {
let eventCount = 0;
let eventType = "";
let propertyName = "";
target.addEventListener("webkitTransitionEnd", event => {
++eventCount;
eventType = event.type;
propertyName = event.propertyName;
});
getComputedStyle(target).opacity;
target.style.opacity = "1";
await timeout(200);
println(`legacy transitionend event count: ${eventCount}`);
println(`legacy transitionend event type: ${eventType}`);
println(`legacy transitionend property name: ${propertyName}`);
done();
});
</script>