dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Don't serialize UnresolvedStyleValue comparison text when unused

Browse source 
UnresolvedStyleValue::create() serialized the component values into a
comparison string unconditionally, but the result is only used when the
caller supplied separate original source text. On the common path that
serialization (including float formatting of every numeric token) was
computed and immediately discarded.

Move the serialization into the branch that actually uses it. This is
hot during var() substitution, where many intermediate
UnresolvedStyleValues are created and never compared.
This commit is contained in:
Andreas Kling 2026-06-19 10:44:32 +02:00 committed by Andreas Kling
parent 1a0f8d4372
commit 523cdab7d9
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/CSS/StyleValues/UnresolvedStyleValue.cpp
View file

@ -55,7 +55,6 @@ StringView UnresolvedStyleValue::comparison_text() const
ValueComparingNonnullRefPtr<UnresolvedStyleValue const> UnresolvedStyleValue::create(Vector<Parser::ComponentValue>&& values, Parser::SubstitutionFunctionsPresence substitution_presence, Optional<String> original_source_text, SourceTextMode source_text_mode, bool contains_attr_tainted_values)
{
auto has_original_source_text = original_source_text.has_value();
auto serialized_values = serialize_a_series_of_component_values(values);
auto source_text = [&] {
if (has_original_source_text)
return MUST(original_source_text.release_value().trim_ascii_whitespace());
@ -65,7 +64,9 @@ ValueComparingNonnullRefPtr<UnresolvedStyleValue const> UnresolvedStyleValue::cr
return source_text_from_component_values(values, source_text_mode);
}();
auto value_comparison_text = has_original_source_text ? MUST(serialized_values.trim_ascii_whitespace()) : String {};
// NB: The comparison text is a normalized serialization, only used when we have separate original source text.
// Don't pay for serializing it otherwise.
auto value_comparison_text = has_original_source_text ? MUST(serialize_a_series_of_component_values(values).trim_ascii_whitespace()) : String {};
return adopt_ref(*new (nothrow) UnresolvedStyleValue(move(source_text), move(value_comparison_text), substitution_presence, contains_attr_tainted_values));
}