dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

WebDriver: Tolerate a WebContent process swap during load-url-from-ui

Browse source 
Problem: Intermittent TestWebDriverSessionHistory crashes in CI.

Cause: A process-swap navigation driven through the load-url-from-ui
test hook (introduced in 24f37c6732 / #10085) could tear down the
WebContent process before it replied to the sync LoadUrlFromUi message,
tripping an assert — even though the result is still delivered over the
driver-execution-complete channel separately. (The reply’s just an ACK.)

Fix: Send the message with send_sync_but_allow_failure. Treat a dropped
reply as the swap proceeding. Nothing’s lost: WebContent sends the async
completion before this, and early errors return before any swap.
This commit is contained in:
sideshowbarker 2026-06-22 13:27:26 +09:00 committed by Andreas Kling
parent 2e86169246
commit 5440f0797b
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Services/WebDriver/Client.cpp
View file

@ -312,8 +312,11 @@ Web::WebDriver::Response Client::load_url_from_ui(Web::WebDriver::Parameters par
auto session = TRY(find_session_with_ladybird_test_hooks(parameters));
RefPtr previous_connection { &session->web_content_connection() };
auto response = TRY(session->perform_async_action([&](auto& connection) {
return connection.load_url_from_ui(move(payload));
auto response = TRY(session->perform_async_action([&](auto& connection) -> Web::WebDriver::Response {
auto reply = connection.template send_sync_but_allow_failure<Messages::WebDriverClient::LoadUrlFromUi>(move(payload));
if (!reply)
return JsonValue {};
return reply->take_response();
}));
if (response.is_object() && response.as_object().get_bool("willReplaceWebContentProcess"sv).value_or(false))
session->mark_current_window_as_awaiting_replacement(*previous_connection);