dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Throw from SourceBuffer::buffered() after removing SourceBuffer

Browse source 
Make SourceBuffer::buffered() throw InvalidStateError when the
SourceBuffer is no longer present in its parent MediaSource.

This matches the existing removed-SourceBuffer checks in other methods
in the file.

Also change the return type for SourceBuffer::buffered() to
WebIDL::ExceptionOr so the getter can return the error.
This commit is contained in:
Thiyagesh Venkatesan 2026-06-02 14:15:52 -07:00 committed by Gregory Bertilson
parent afb0fa2413
commit 5b2dc0dabc
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibWeb/MediaSourceExtensions/SourceBuffer.cpp
View file

@ -215,12 +215,15 @@ bool SourceBuffer::updating() const
}
// https://w3c.github.io/media-source/#dom-sourcebuffer-buffered
GC::Ref<HTML::TimeRanges> SourceBuffer::buffered()
WebIDL::ExceptionOr<GC::Ref<HTML::TimeRanges>> SourceBuffer::buffered()
{
auto time_ranges = realm().create<HTML::TimeRanges>(realm());
// 1. If this object has been removed from the sourceBuffers attribute of the parent media source then throw
// an InvalidStateError exception and abort these steps.
// FIXME: 1. If this object has been removed from the sourceBuffers attribute of the parent media source then throw
// an InvalidStateError exception and abort these steps.
if (!m_media_source->source_buffers()->contains(*this))
return WebIDL::InvalidStateError::create(realm(), "SourceBuffer has been removed"_utf16);
auto time_ranges = realm().create<HTML::TimeRanges>(realm());
// NB: Further steps to intersect the buffered ranges of the track buffers are implemented within
// SourceBufferProcessor::buffered_ranges() below, since it has access to the track buffers.

2
Libraries/LibWeb/MediaSourceExtensions/SourceBuffer.h
View file

@ -46,7 +46,7 @@ public:
bool updating() const;
// https://w3c.github.io/media-source/#dom-sourcebuffer-buffered
GC::Ref<HTML::TimeRanges> buffered();
WebIDL::ExceptionOr<GC::Ref<HTML::TimeRanges>> buffered();
void set_content_type(String const& type);