dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibHTTP: Reuse cookie domain attribute parsing

Browse source 
The Cookie to ParsedCookie conversion stripped a leading dot and
lowercased the cookie domain itself. Use the existing Domain attribute
parser instead, so edited cookies follow the same ASCII validation and
normalization as Set-Cookie parsing.
This commit is contained in:
Sam Atkins 2026-06-17 15:42:38 +01:00 committed by Jelle Raaijmakers
parent b1547d467e
commit 680dc78dac
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibHTTP/Cookie/ParsedCookie.cpp
View file

@ -111,12 +111,8 @@ ErrorOr<ParsedCookie> parse_cookie(Cookie const& cookie)
parsed_cookie.secure_attribute_present = cookie.secure;
parsed_cookie.http_only_attribute_present = cookie.http_only;
if (!cookie.host_only) {
auto domain = cookie.domain.bytes_as_string_view();
if (domain.starts_with('.'))
domain = domain.substring_view(1);
parsed_cookie.domain = domain.to_ascii_lowercase_string();
}
if (!cookie.host_only)
TRY(on_domain_attribute(parsed_cookie, cookie.domain.bytes_as_string_view()));
if (cookie.persistent)
parsed_cookie.expiry_time_from_expires_attribute = cookie.expiry_time;