dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Tests: Adjust timing in abortsignal-timeout test to avoid failure

Browse source 
Many clock related functions in Ladybird use the clock type called
CLOCK_MONOTONIC_COARSE to obtain timestamps. This is a less precise
clock and can be skewed by 1 or more milliseconds.

This less precise clock timing is causing the abortsignal-timeout.html
test to fail randomly as it expects the abort signal to arrive after
10ms, but in some cases it arrives at 9ms causing the test to fail. In
some very rare cases it could even arrive in 7ms or 8ms.

Test is changed to accept 9ms as a good result and if that is still
not enough the test also will display the timings so that further
investigations can be made.
This commit is contained in:
Rocco Corsi 2025-10-04 09:23:37 -04:00 committed by Jelle Raaijmakers
parent 120bba597d
commit 6fa32fbf69
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Tests/LibWeb/Text/input/abortsignal-timeout.html
View file

@ -7,10 +7,16 @@
const signal = AbortSignal.timeout(timeout_milliseconds);
signal.onabort = (event) => {
const abort_event_time = performance.now();
const time_taken_milliseconds = abort_event_time - test_start_time;
const time_taken_milliseconds = (abort_event_time - test_start_time) + 1; // Add 1ms for possible coarse clock skew
println(`Time passed before abort event fired is at least ${timeout_milliseconds} milliseconds: ${time_taken_milliseconds >= timeout_milliseconds}`);
println(`Reason type: ${signal.reason.name}`);
println(`onabort event isTrusted: ${event.isTrusted}`);
if (time_taken_milliseconds < timeout_milliseconds) {
println(`start time: ${test_start_time}`);
println(`abort time: ${abort_event_time}`);
println(`difference (coarse adjusted): ${time_taken_milliseconds}`);
println(`difference (actual): ${time_taken_milliseconds - 1}`);
}
done();
};
});