dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibGfx: Re-enable tech(variations) font support

Browse source
This commit is contained in:
Johan Dahlin 2026-04-20 18:04:02 +02:00 committed by Jelle Raaijmakers
parent 7685a5e14a
commit 75ae9abe7a
2 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibGfx/Font/FontSupport.cpp
View file

@ -53,8 +53,7 @@ bool font_tech_is_supported(FontTech const font_tech)
#endif
case FontTech::Variations:
// avar, cvar, fvar, gvar, HVAR, MVAR, STAT, and VVAR, supported by HarfBuzz
// FIXME: This does not actually seem to work and causes issues with the font weight on https://ladybird.org
return false;
return true;
case FontTech::ColorColrv0:
case FontTech::ColorColrv1:
// COLR, supported by HarfBuzz

9
Tests/LibWeb/Text/expected/wpt-import/css/css-fonts/parsing/font-face-src-tech.txt
View file

@ -2,8 +2,7 @@ Harness status: OK
Found 39 tests
36 Pass
3 Fail
39 Pass
Pass Check that src: url("foo.ttf") is valid
Pass Check that src: url("foo.ttf") tech() is invalid
Pass Check that src: url("foo.ttf") tech(features-opentype) is valid
@ -12,12 +11,12 @@ Pass Check that src: url("foo.ttf") tech(color-COLRv0) is valid
Pass Check that src: url("foo.ttf") tech(color-COLRv1) is valid
Pass Check that src: url("foo.ttf") tech(color-sbix) is valid
Pass Check that src: url("foo.ttf") tech(color-CBDT) is valid
Fail Check that src: url("foo.ttf") tech(variations) is valid
Pass Check that src: url("foo.ttf") tech(variations) is valid
Pass Check that src: url("foo.ttf") tech(palettes) is valid
Pass Check that src: url("foo.ttf") tech("features-opentype") is invalid
Pass Check that src: url("foo.ttf") tech("color-COLRv0") is invalid
Pass Check that src: url("foo.ttf") tech("variations") is invalid
Fail Check that src: url("foo.ttf") tech(features-opentype, color-COLRv0, variations, palettes) is valid
Pass Check that src: url("foo.ttf") tech(features-opentype, color-COLRv0, variations, palettes) is valid
Pass Check that src: url("foo.ttf") tech(features-opentype color-COLRv0 variations palettes) is invalid
Pass Check that src: url("foo.ttf") tech(feature-opentype) is invalid
Pass Check that src: url("foo.ttf") tech(feature-aat) is invalid
@ -41,5 +40,5 @@ Pass Check that src: url("foo.ttf") tech(features-graphite), url("bar.html") is
Pass Check that src: url("foo.ttf") dummy("opentype") tech(variations) is invalid
Pass Check that src: url("foo.ttf") dummy("opentype") dummy(variations) is invalid
Pass Check that src: url("foo.ttf") format(opentype) tech(features-opentype) dummy(something) is invalid
Fail Check that src: url("foo.ttf") format(dummy), url("foo.ttf") tech(variations) is valid
Pass Check that src: url("foo.ttf") format(dummy), url("foo.ttf") tech(variations) is valid
Pass Check that src: url("foo.ttf") tech(color), url("bar.html") is valid