dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Clean-up more input state after running each test

Browse source 
The clean-up in 71c457c36e turns out to
not be enough for all cases. So be more thorough and clear up anything
that could affect the next test.

In particular this fixes flakiness in `Text/input/select-text.html` but
hopefully it solves the issue for good!
This commit is contained in:
Sam Atkins 2026-04-17 11:18:13 +01:00
parent 71d92c7298
commit 7c1d359790
4 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/Internals/Internals.cpp
View file

@ -574,8 +574,8 @@ void Internals::perform_per_test_cleanup()
gamepad->disconnect();
m_gamepads.clear();
// Clear any mouse-down state
page().top_level_traversable()->event_handler().clear_mousedown_tracking();
// Clear any input state
page().top_level_traversable()->event_handler().clear_per_test_input_state({});
}
void Internals::set_highlighted_node(GC::Ptr<DOM::Node> node)

4
Libraries/LibWeb/Page/DragAndDropEventHandler.h
View file

@ -27,6 +27,8 @@ public:
EventResult handle_drag_leave(JS::Realm&, CSSPixelPoint screen_position, CSSPixelPoint page_offset, CSSPixelPoint client_offset, CSSPixelPoint offset, unsigned button, unsigned buttons, unsigned modifiers);
EventResult handle_drop(JS::Realm&, CSSPixelPoint screen_position, CSSPixelPoint page_offset, CSSPixelPoint client_offset, CSSPixelPoint offset, unsigned button, unsigned buttons, unsigned modifiers);
void reset();
private:
enum class Cancelled {
No,
@ -49,8 +51,6 @@ private:
bool allow_text_drop(GC::Ref<DOM::Node>) const;
void reset();
RefPtr<HTML::DragDataStore> m_drag_data_store;
// https://html.spec.whatwg.org/multipage/dnd.html#source-node

13
Libraries/LibWeb/Page/EventHandler.cpp
View file

@ -980,6 +980,19 @@ void EventHandler::stop_updating_selection()
m_auto_scroll_handler = nullptr;
}
void EventHandler::clear_per_test_input_state(Badge<Internals::Internals>)
{
clear_mousedown_tracking();
stop_updating_selection();
m_middle_button_scroll_handler = nullptr;
m_prevent_mouse_event = false;
m_hovered_chrome_widget = nullptr;
m_captured_chrome_widget = nullptr;
m_effective_legacy_mouse_pointer_position = nullptr;
m_drag_and_drop_event_handler->reset();
m_mousemove_previous_screen_position.clear();
}
EventResult EventHandler::handle_mouseup(CSSPixelPoint visual_viewport_position, CSSPixelPoint screen_position, u32 button, u32 buttons, u32 modifiers)
{
auto middle_button_autoscrolled = m_middle_button_scroll_handler && m_middle_button_scroll_handler->mouse_has_moved_beyond_dead_zone();

2
Libraries/LibWeb/Page/EventHandler.h
View file

@ -77,6 +77,8 @@ public:
return {};
}
void clear_per_test_input_state(Badge<Internals::Internals>);
private:
EventResult focus_next_element();
EventResult focus_previous_element();