dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibJS: Enforce "only one JS::VM" but allow destroying+recreating VMs

Browse source 
test262-runner needs to make a clean slate VM for each test, so let's
relax the enforcement here a little bit. As long as there is only one
JS::VM instantiated, we're good.
This commit is contained in:
Andreas Kling 2025-12-10 08:02:33 -06:00 committed by Tim Flynn
parent b1f672de81
commit 87ecd3f558
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Libraries/LibJS/Runtime/VM.cpp
View file

@ -38,6 +38,7 @@
namespace JS {
VM* VM::s_the = nullptr;
static size_t s_vm_count = 0;
VM& VM::the()
{
@ -46,7 +47,11 @@ VM& VM::the()
NonnullRefPtr<VM> VM::create()
{
VERIFY(!s_the);
// NOTE: We only allow a single VM instance per process.
// However, test262-runner needs to create and destroy VMs repeatedly,
// so we allow recreating the VM as long as the previous one was destroyed.
VERIFY(s_vm_count == 0);
++s_vm_count;
ErrorMessages error_messages {};
error_messages[to_underlying(ErrorMessage::OutOfMemory)] = ErrorType::OutOfMemory.message();
@ -223,7 +228,11 @@ VM::VM(ErrorMessages error_messages)
};
}
VM::~VM() = default;
VM::~VM()
{
--s_vm_count;
VERIFY(s_vm_count == 0);
}
Utf16String const& VM::error_message(ErrorMessage type) const
{