dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Bail on unresolved percentages in resolve_value

Browse source 
Previously we assumed that if the calculation had been simplified to a
single `NumericCalculationNode` that we could resolve it - this isn't
the case if we have a percentage that should be resolved to a different
type.

Fixes #10209
This commit is contained in:
Callum Law 2026-06-21 12:44:29 +12:00 committed by Sam Atkins
parent 360bfd66f6
commit 9183c2a029
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/CSS/StyleValues/CalculatedStyleValue.cpp
View file

@ -3162,7 +3162,7 @@ Optional<CalculatedStyleValue::ResolvedValue> CalculatedStyleValue::resolve_valu
// NOTE: Any nodes which rely on dynamic state should have been simplified away in absolutized so we can pass a nullptr here
auto simplified_tree = simplify_a_calculation_tree(m_calculation, m_context, resolution_context);
if (!is<NumericCalculationNode>(*simplified_tree))
if (!is<NumericCalculationNode>(*simplified_tree) || (simplified_tree->contains_percentage() && m_context.percentages_resolve_as.has_value()))
return {};
auto value = try_get_value_with_canonical_unit(simplified_tree, m_context, resolution_context);

9
Tests/LibWeb/Crash/CSS/unresolved-percentage-isnt-considered-resolvable.html Normal file
View file

@ -0,0 +1,9 @@
<!doctype html>
<style>
input:focus {
transform: translateX(calc(10%));
}</style
><input id="target" />
<script>
target.focus();
</script>