dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UI/AppKit: Prevent autocomplete highlight flicker while typing

Browse source 
While typing in the location bar, intermediate autocomplete updates
caused the highlighted suggestion to flicker.

These updates trigger on each keystroke and lead to unnecessary
selection changes.

Skip intermediate popup updates while it is visible and rely on final
results to update both suggestions and selection atomically.
This commit is contained in:
Christian Frey 2026-06-03 11:01:39 +02:00 committed by Andreas Kling
parent 388189d979
commit a8cb27ddd0
1 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
UI/AppKit/Interface/TabController.mm
View file

@ -394,18 +394,13 @@ static NSImage* location_field_globe_icon()
}
auto selected_row = [self applyInlineAutocomplete:suggestions];
if (result_kind == WebView::AutocompleteResultKind::Intermediate && [self.autocomplete isVisible]) {
if (auto selected_suggestion = [self.autocomplete selectedSuggestion];
selected_suggestion.has_value()) {
for (auto const& suggestion : suggestions) {
if (suggestion.text == *selected_suggestion)
return;
}
}
[self.autocomplete clearSelection];
// Do not update the popup while results are still changing.
// Intermediate updates are triggered on every keystroke and would
// cause visible flicker in the suggestion list.
// Only final results are used to refresh the UI.
if (result_kind == WebView::AutocompleteResultKind::Intermediate && [self.autocomplete isVisible])
return;
}
[self.autocomplete showWithSuggestions:move(suggestions)
selectedRow:selected_row];