dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Make HTMLMediaElement's FetchController reference weak

Browse source 
This allows the FetchController to be reclaimed when the fetch
completes.
This commit is contained in:
Zaggy1024 2026-02-17 18:06:40 -06:00 committed by Gregory Bertilson
parent 7c0802bd4f
commit ad92622cf4
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View file

@ -105,7 +105,6 @@ void HTMLMediaElement::visit_edges(Cell::Visitor& visitor)
visitor.visit(m_text_tracks);
visitor.visit(m_document_observer);
visitor.visit(m_source_element_selector);
visitor.visit(m_fetch_controller);
visitor.visit(m_pending_play_promises);
visitor.visit(m_selected_video_track);
}

2
Libraries/LibWeb/HTML/HTMLMediaElement.h
View file

@ -351,7 +351,7 @@ private:
GC::Ptr<SourceElementSelector> m_source_element_selector;
GC::Ptr<Fetch::Infrastructure::FetchController> m_fetch_controller;
GC::Weak<Fetch::Infrastructure::FetchController> m_fetch_controller;
u32 m_current_fetch_generation { 0 };
RefPtr<Media::PlaybackManager> m_playback_manager;