From ae0c7bc097e59c3a532eef3e3f6dc3d6d9ee7cac Mon Sep 17 00:00:00 2001 From: Shannon Booth Date: Mon, 22 Jun 2026 14:15:53 +0200 Subject: [PATCH] LibWeb/Encoding: Dont return ExceptionOr for encoder constructors No exception is thrown. --- Libraries/LibWeb/Encoding/TextEncoder.cpp | 2 +- Libraries/LibWeb/Encoding/TextEncoder.h | 2 +- Libraries/LibWeb/Encoding/TextEncoderStream.cpp | 2 +- Libraries/LibWeb/Encoding/TextEncoderStream.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Libraries/LibWeb/Encoding/TextEncoder.cpp b/Libraries/LibWeb/Encoding/TextEncoder.cpp index f287b9e873..54cc0b7f01 100644 --- a/Libraries/LibWeb/Encoding/TextEncoder.cpp +++ b/Libraries/LibWeb/Encoding/TextEncoder.cpp @@ -14,7 +14,7 @@ namespace Web::Encoding { GC_DEFINE_ALLOCATOR(TextEncoder); -WebIDL::ExceptionOr> TextEncoder::construct_impl(JS::Realm& realm) +GC::Ref TextEncoder::construct_impl(JS::Realm& realm) { return realm.create(realm); } diff --git a/Libraries/LibWeb/Encoding/TextEncoder.h b/Libraries/LibWeb/Encoding/TextEncoder.h index 6904d6f198..c7021214b7 100644 --- a/Libraries/LibWeb/Encoding/TextEncoder.h +++ b/Libraries/LibWeb/Encoding/TextEncoder.h @@ -27,7 +27,7 @@ class TextEncoder final GC_DECLARE_ALLOCATOR(TextEncoder); public: - static WebIDL::ExceptionOr> construct_impl(JS::Realm&); + static GC::Ref construct_impl(JS::Realm&); virtual ~TextEncoder() override; diff --git a/Libraries/LibWeb/Encoding/TextEncoderStream.cpp b/Libraries/LibWeb/Encoding/TextEncoderStream.cpp index f5879cfaf7..6be87d9b93 100644 --- a/Libraries/LibWeb/Encoding/TextEncoderStream.cpp +++ b/Libraries/LibWeb/Encoding/TextEncoderStream.cpp @@ -21,7 +21,7 @@ namespace Web::Encoding { GC_DEFINE_ALLOCATOR(TextEncoderStream); // https://encoding.spec.whatwg.org/#dom-textencoderstream -WebIDL::ExceptionOr> TextEncoderStream::construct_impl(JS::Realm& realm) +GC::Ref TextEncoderStream::construct_impl(JS::Realm& realm) { // 1. Set this’s encoder to an instance of the UTF-8 encoder. // NOTE: No-op, as AK::String is already in UTF-8 format. diff --git a/Libraries/LibWeb/Encoding/TextEncoderStream.h b/Libraries/LibWeb/Encoding/TextEncoderStream.h index 2d5c24d264..57225e34ed 100644 --- a/Libraries/LibWeb/Encoding/TextEncoderStream.h +++ b/Libraries/LibWeb/Encoding/TextEncoderStream.h @@ -20,7 +20,7 @@ class TextEncoderStream final GC_DECLARE_ALLOCATOR(TextEncoderStream); public: - static WebIDL::ExceptionOr> construct_impl(JS::Realm&); + static GC::Ref construct_impl(JS::Realm&); virtual ~TextEncoderStream() override; private: