dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Defer vector allocation in StyleValueList::absolutized()

Browse source 
We now only allocate a StyleValueVector if we know absolutization has
caused a value to change.

This change also avoids a double StyleValue::absolutized() computation.
This commit is contained in:
Tim Ledbetter 2026-02-23 14:24:26 +00:00 committed by Jelle Raaijmakers
parent 73d948a028
commit b3e6df5eef
1 changed files with 13 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
Libraries/LibWeb/CSS/StyleValues/StyleValueList.cpp
View file

@ -25,22 +25,20 @@ bool StyleValueList::Properties::operator==(Properties const& other) const
ValueComparingNonnullRefPtr<StyleValue const> StyleValueList::absolutized(ComputationContext const& computation_context) const
{
StyleValueVector absolutized_style_values;
absolutized_style_values.ensure_capacity(m_properties.values.size());
bool any_absolutized = false;
for (auto const& value : m_properties.values) {
auto absolutized_style_value = value->absolutized(computation_context);
if (absolutized_style_value != value)
any_absolutized = true;
absolutized_style_values.append(value->absolutized(computation_context));
for (size_t i = 0; i < m_properties.values.size(); ++i) {
auto absolutized_value = m_properties.values[i]->absolutized(computation_context);
if (absolutized_value != m_properties.values[i]) {
StyleValueVector result;
result.ensure_capacity(m_properties.values.size());
for (size_t j = 0; j < i; ++j)
result.append(m_properties.values[j]);
result.append(move(absolutized_value));
for (size_t j = i + 1; j < m_properties.values.size(); ++j)
result.append(m_properties.values[j]->absolutized(computation_context));
return StyleValueList::create(move(result), m_properties.separator);
}
}
if (!any_absolutized)
return *this;
return StyleValueList::create(move(absolutized_style_values), m_properties.separator);
return *this;
}
void StyleValueList::serialize(StringBuilder& builder, SerializationMode mode) const