dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

WebContent: Ignore stale DevTools highlight requests

Browse source 
Firefox can still send highlight requests for node fronts that are
being replaced during navigation. Those node IDs can refer to a
disconnected or inactive document. Active documents may also have dirty
layout by the time the request arrives.

Ignore stale nodes and update layout before reading the layout node.
This keeps late highlight requests from tripping layout freshness
assertions.
This commit is contained in:
Sam Atkins 2026-05-28 17:09:11 +01:00
parent 5283f669a1
commit bbb4be8c1e
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Services/WebContent/ConnectionFromClient.cpp
View file

@ -1002,10 +1002,19 @@ void ConnectionFromClient::highlight_dom_node(u64 page_id, Web::UniqueNodeID nod
}
auto* node = Web::DOM::Node::from_unique_id(node_id);
if (!node || !node->layout_node())
if (!node || !node->is_connected())
return;
node->document().set_highlighted_node(node, pseudo_element);
auto& document = node->document();
auto navigable = document.navigable();
if (!navigable || navigable->active_document() != &document)
return;
document.update_layout(Web::DOM::UpdateLayoutReason::Debugging);
if (!node->layout_node())
return;
document.set_highlighted_node(node, pseudo_element);
}
static Web::Painting::FlexboxInspectorOverlayOptions flexbox_inspector_overlay_options_from_json(JsonValue const& options)