dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Avoid TextCodec when parsing JSON bytes

Browse source 
Use String::from_utf8_with_replacement_character() directly for Infra's
parse JSON bytes algorithm instead of constructing a more generic
TextCodec UTF-8 decoder.
This commit is contained in:
Shannon Booth 2026-06-20 00:03:24 +02:00 committed by Andreas Kling
parent c907338ab3
commit be6192dab2
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/Infra/JSON.cpp
View file

@ -27,11 +27,8 @@ WebIDL::ExceptionOr<JS::Value> parse_json_string_to_javascript_value(JS::Realm&
// https://infra.spec.whatwg.org/#parse-json-bytes-to-a-javascript-value
WebIDL::ExceptionOr<JS::Value> parse_json_bytes_to_javascript_value(JS::Realm& realm, ReadonlyBytes bytes)
{
auto& vm = realm.vm();
// 1. Let string be the result of running UTF-8 decode on bytes.
TextCodec::UTF8Decoder decoder;
auto string = TRY_OR_THROW_OOM(vm, decoder.to_utf8(bytes));
auto string = String::from_utf8_with_replacement_character(bytes, String::WithBOMHandling::Yes);
// 2. Return the result of parsing a JSON string to an Infra value given string.
return parse_json_string_to_javascript_value(realm, string);