dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Avoid style computation if document is detached

Browse source
This commit is contained in:
Tim Ledbetter 2026-03-18 22:10:52 +00:00 committed by Jelle Raaijmakers
parent 26389363ad
commit c173a66754
3 changed files with 22 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Libraries/LibWeb/CSS/CSSStyleProperties.cpp
View file

@ -540,10 +540,19 @@ Optional<StyleProperty> CSSStyleProperties::get_direct_property(PropertyNameAndI
auto abstract_element = *owner_node();
// https://www.w3.org/TR/cssom-1/#dom-window-getcomputedstyle
// NB: This is a partial enforcement of step 5 ("If elt is connected, ...")
if (!abstract_element.element().is_connected())
// https://drafts.csswg.org/cssom/#dom-window-getcomputedstyle
// NB: This is a partial enforcement of step 5:
// If [...] elt is connected, part of the flat tree, and its shadow-including root has a browsing context which
// either doesn't have a browsing context container, or whose browsing context container is being rendered.
auto& element = abstract_element.element();
if (!element.is_connected())
return {};
auto browsing_context = element.shadow_including_root().document().browsing_context();
if (!browsing_context)
return {};
// FIXME: Check if the element is part of the flat tree.
// FIXME: Check that the browsing context either doesn't have a browsing context container, or that its
// browsing context container is being rendered.
// NB: We grab the layout node before deciding whether update_layout() is needed.
// For properties that don't need layout or a layout node (the else branch below),

5
Tests/LibWeb/Crash/CSS/getComputedStyle-detached-document-body.html Normal file
View file

@ -0,0 +1,5 @@
<!DOCTYPE html>
<script>
var doc = document.implementation.createHTMLDocument("");
getComputedStyle(doc.body).color;
</script>

5
Tests/LibWeb/Crash/CSS/getComputedStyle-detached-document.html Normal file
View file

@ -0,0 +1,5 @@
<!DOCTYPE html>
<script>
var doc = document.implementation.createHTMLDocument("");
getComputedStyle(doc.documentElement).color;
</script>