dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

RequestServer: Delete cache entry files when the cache version is bumped

Browse source 
When we increment the cache version, we previously only wiped the cache
index table; we did not delete the corresponding cache entry files.
This commit is contained in:
Timothy Flynn 2026-05-11 07:47:07 -04:00 committed by Tim Flynn
parent f2fc39eabf
commit c1a69e6c9e
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibHTTP/Cache/CacheIndex.cpp
View file

@ -50,8 +50,6 @@ static NonnullRefPtr<HeaderList> deserialize_headers(StringView serialized_heade
return headers;
}
#if HTTP_DISK_CACHE_DEBUG
template<typename Callback>
static void for_each_cache_entry_file(Database::Database& database, Callback&& callback)
{
@ -75,6 +73,8 @@ static void for_each_cache_entry_file(Database::Database& database, Callback&& c
});
}
#if HTTP_DISK_CACHE_DEBUG
static void log_orphaned_disk_cache_entries(Database::Database& database)
{
auto check_entry = MUST(database.prepare_statement(R"#(
@ -127,6 +127,10 @@ ErrorOr<CacheIndex> CacheIndex::create(Database::Database& database, LexicalPath
auto set_cache_version = TRY(database.prepare_statement("INSERT OR REPLACE INTO CacheMetadata VALUES (?, ?);"sv));
database.execute_statement(set_cache_version, {}, CACHE_METADATA_KEY, CACHE_VERSION);
for_each_cache_entry_file(database, [&](LexicalPath const& cache_entry) {
(void)FileSystem::remove(cache_entry.string(), FileSystem::RecursionMode::Disallowed);
});
}
auto create_cache_index_table = TRY(database.prepare_statement(R"#(