dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibCore: Release IOSurface creation properties

Browse source 
IOSurfaceHandle::create() builds a CoreFoundation dictionary for
IOSurfaceCreate() and previously left that dictionary alive after the
surface was created. Each locally created IOSurface therefore leaked
the temporary properties dictionary.
This commit is contained in:
Aliaksandr Kalenik 2026-05-27 23:50:07 +02:00 committed by Andreas Kling
parent 2773e45db5
commit cdacc11624
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibCore/IOSurface.cpp
View file

@ -66,17 +66,17 @@ IOSurfaceHandle IOSurfaceHandle::create(int width, int height)
RefAutoRelease<CFNumberRef> bytes_per_element_number = CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, &bytes_per_element);
RefAutoRelease<CFNumberRef> pixel_format_number = CFNumberCreate(kCFAllocatorDefault, kCFNumberSInt32Type, &pixel_format);
CFMutableDictionaryRef props = CFDictionaryCreateMutable(kCFAllocatorDefault,
RefAutoRelease<CFMutableDictionaryRef> props = CFDictionaryCreateMutable(kCFAllocatorDefault,
0,
&kCFTypeDictionaryKeyCallBacks,
&kCFTypeDictionaryValueCallBacks);
CFDictionarySetValue(props, kIOSurfaceWidth, width_number.ref());
CFDictionarySetValue(props, kIOSurfaceHeight, height_number.ref());
CFDictionarySetValue(props, kIOSurfaceBytesPerElement, bytes_per_element_number.ref());
CFDictionarySetValue(props, kIOSurfacePixelFormat, pixel_format_number.ref());
CFDictionarySetValue(props.ref(), kIOSurfaceWidth, width_number.ref());
CFDictionarySetValue(props.ref(), kIOSurfaceHeight, height_number.ref());
CFDictionarySetValue(props.ref(), kIOSurfaceBytesPerElement, bytes_per_element_number.ref());
CFDictionarySetValue(props.ref(), kIOSurfacePixelFormat, pixel_format_number.ref());
auto* ref = IOSurfaceCreate(props);
auto* ref = IOSurfaceCreate(props.ref());
VERIFY(ref);
return IOSurfaceHandle(make<IOSurfaceRefWrapper>(ref));
}