dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibJS: Fix async arrow and for-of async parsing

Browse source
This commit is contained in:
RubenKelevra 2026-03-17 13:57:23 +01:00 committed by Andreas Kling
parent af777b5d86
commit d6229a1cc8
2 changed files with 21 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibJS/Rust/src/parser/expressions.rs
View file

@ -469,6 +469,13 @@ impl Parser<'_> {
) {
return (arrow, false);
}
self.arrow_function_failed_positions
.remove(&(start.offset as usize));
// `async => ...` is a regular arrow function with parameter name `async`
// (not an async arrow function).
if let Some(arrow) = self.try_parse_arrow_function_expression(false, false, None) {
return (arrow, false);
}
let token = self.consume_and_check_identifier();
let value = self.token_value(&token).to_vec();
let id = self.make_identifier(start, value.clone());

14
Libraries/LibJS/Rust/src/parser/statements.rs
View file

@ -394,6 +394,7 @@ impl Parser<'_> {
}
let init_start = self.position();
let init_starts_with_async_keyword = self.match_token(TokenType::Async);
let is_var_init = self.match_token(TokenType::Var);
let is_using = self.match_for_using_declaration();
let is_let = self.match_token(TokenType::Let)
@ -475,6 +476,19 @@ impl Parser<'_> {
} else {
self.validate_for_in_of_lhs(&init);
// https://tc39.es/ecma262/#sec-for-in-and-for-of-statements
// `for (async of ...)` must be rejected when `async` is the
// reserved keyword token. Escaped identifiers (e.g. `\u0061sync`)
// are still valid here.
if init_starts_with_async_keyword
&& let LocalForInit::Expression(ref expression) = init
&& let ExpressionKind::Identifier(ref ident) = expression.inner
&& ident.name == utf16!("async")
{
self.syntax_error(
"for-of statement may not use 'async' as the left-hand side",
);
}
// https://tc39.es/ecma262/#sec-for-in-and-for-of-statements
if let LocalForInit::Expression(ref expression) = init
&& let ExpressionKind::Member { ref object, .. } = expression.inner
&& let ExpressionKind::Identifier(ref ident) = object.inner