dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibGfx/PNM: Remove two fixmes

Browse source 
bab2113ec1 made read_whitespace() return ErrorOr, which makes this
easy to do.

(7cafd7d177, which added the fixmes, landed slightly after bab2113ec1,
so not quite sure why it wasn't like this immediately. Maybe commit
order got changed during review; both commits were in #17831.)

No behavior change.
This commit is contained in:
Nico Weber 2024-02-01 21:01:55 -05:00 committed by Sam Atkins
parent eeb0d6f52b
commit e269526020
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGfx/ImageFormats/PortableImageLoaderCommon.h
View file

@ -116,12 +116,12 @@ static ErrorOr<void> read_whitespace(TContext& context)
auto const byte = byte_or_error.value();
if (byte == '#') {
stream.seek(-1, SeekMode::FromCurrentPosition).release_value_but_fixme_should_propagate_errors();
TRY(stream.seek(-1, SeekMode::FromCurrentPosition));
TRY(read_comment(context));
continue;
}
if (byte != ' ' && byte != '\t' && byte != '\n' && byte != '\r') {
stream.seek(-1, SeekMode::FromCurrentPosition).release_value_but_fixme_should_propagate_errors();
TRY(stream.seek(-1, SeekMode::FromCurrentPosition));
if (is_first_char)
return Error::from_string_literal("Can't read whitespace from stream");
break;