dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Resolve editing background colors without layout

Browse source 
removeFormat computes effective command values for nodes in the active
selection. Hidden editable elements can be selected without having a
styled layout node, but background-color resolution only needs an
element color context.

Use the element color context instead of requiring
Layout::NodeWithStyle. Add reduced crash coverage for removeFormat with
a hidden button.
This commit is contained in:
Andreas Kling 2026-06-06 19:43:04 +02:00 committed by Andreas Kling
parent 998fa908db
commit eb2200e33d
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/Editing/Internal/Algorithms.cpp
View file

@ -1142,8 +1142,7 @@ Optional<Utf16String> effective_command_value(GC::Ptr<DOM::Node> node, FlyString
auto background_color = resolved_background_color();
if (!background_color)
return NumericLimits<u8>::max();
VERIFY(is<Layout::NodeWithStyle>(node->layout_node()));
return background_color->to_color(CSS::ColorResolutionContext::for_layout_node_with_style(*static_cast<Layout::NodeWithStyle*>(node->layout_node()))).value().alpha();
return background_color->to_color(CSS::ColorResolutionContext::for_element({ node_as_element() })).value().alpha();
};
while (resolved_background_alpha() == 0 && node->parent() && is<DOM::Element>(*node->parent()))
node = node->parent();

10
Tests/LibWeb/Crash/Editing/remove-format-with-hidden-selection.html Normal file
View file

@ -0,0 +1,10 @@
<script>
function runTest()
{
document.execCommand("selectAll", false);
document.documentElement.setAttribute("contenteditable", "true");
document.execCommand("removeFormat", false);
}
</script>
<body onload="runTest()">
<button hidden>|@QXs,uQhRb({z6)</button>