From ebda8fcf119f57c0393c9064513742ddeded374d Mon Sep 17 00:00:00 2001 From: Zaggy1024 Date: Thu, 19 Feb 2026 15:59:26 -0600 Subject: [PATCH] LibWeb: Clarify the capture safety in HTMLMediaElement::fetch_resource These tasks' captures aren't clearly safe as written, since raw references don't make it apparent that we're capturing a GC-aware reference. Conservative scanning made this safe, but let's make it a bit clearer. --- Libraries/LibWeb/HTML/HTMLMediaElement.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Libraries/LibWeb/HTML/HTMLMediaElement.cpp b/Libraries/LibWeb/HTML/HTMLMediaElement.cpp index e19374fa85..886e64de5c 100644 --- a/Libraries/LibWeb/HTML/HTMLMediaElement.cpp +++ b/Libraries/LibWeb/HTML/HTMLMediaElement.cpp @@ -1134,8 +1134,8 @@ void HTMLMediaElement::fetch_resource(NonnullRefPtr const& fetch_data fetch_data->stream->add_chunk_at(fetch_data->offset, media_data.bytes()); fetch_data->offset += media_data.size(); - weak_self->queue_a_media_element_task([&self = *weak_self] { - self.process_media_data(FetchingStatus::Ongoing).release_value_but_fixme_should_propagate_errors(); + weak_self->queue_a_media_element_task([self = weak_self.as_nonnull()] { + self->process_media_data(FetchingStatus::Ongoing).release_value_but_fixme_should_propagate_errors(); }); }); @@ -1150,8 +1150,8 @@ void HTMLMediaElement::fetch_resource(NonnullRefPtr const& fetch_data return; fetch_data->stream->close(); - weak_self->queue_a_media_element_task([&self = *weak_self] { - self.process_media_data(FetchingStatus::Complete).release_value_but_fixme_should_propagate_errors(); + weak_self->queue_a_media_element_task([self = weak_self.as_nonnull()] { + self->process_media_data(FetchingStatus::Complete).release_value_but_fixme_should_propagate_errors(); }); });