From f58298132b78900c898ff4bc3f4eea49446074a8 Mon Sep 17 00:00:00 2001 From: ayeteadoe Date: Tue, 1 Jul 2025 18:24:22 -0700 Subject: [PATCH] LibDevTools: Enable EXPLICIT_SYMBOL_EXPORT --- Libraries/LibDevTools/Actor.h | 2 +- Libraries/LibDevTools/Actors/CSSPropertiesActor.h | 3 ++- Libraries/LibDevTools/Actors/ConsoleActor.h | 3 ++- Libraries/LibDevTools/Actors/DeviceActor.h | 3 ++- Libraries/LibDevTools/Actors/FrameActor.h | 3 ++- Libraries/LibDevTools/Actors/HighlighterActor.h | 3 ++- Libraries/LibDevTools/Actors/InspectorActor.h | 3 ++- Libraries/LibDevTools/Actors/LayoutInspectorActor.h | 3 ++- Libraries/LibDevTools/Actors/NodeActor.h | 3 ++- Libraries/LibDevTools/Actors/PageStyleActor.h | 3 ++- Libraries/LibDevTools/Actors/PreferenceActor.h | 3 ++- Libraries/LibDevTools/Actors/ProcessActor.h | 3 ++- Libraries/LibDevTools/Actors/RootActor.h | 3 ++- Libraries/LibDevTools/Actors/StyleSheetsActor.h | 3 ++- Libraries/LibDevTools/Actors/TabActor.h | 3 ++- Libraries/LibDevTools/Actors/TargetConfigurationActor.h | 3 ++- Libraries/LibDevTools/Actors/ThreadActor.h | 3 ++- Libraries/LibDevTools/Actors/ThreadConfigurationActor.h | 3 ++- Libraries/LibDevTools/Actors/WalkerActor.h | 3 ++- Libraries/LibDevTools/Actors/WatcherActor.h | 3 ++- Libraries/LibDevTools/CMakeLists.txt | 2 +- Libraries/LibDevTools/Connection.h | 2 +- Libraries/LibDevTools/DevToolsDelegate.h | 2 +- Libraries/LibDevTools/DevToolsServer.h | 2 +- Libraries/LibDevTools/Forward.h | 2 ++ 25 files changed, 45 insertions(+), 24 deletions(-) diff --git a/Libraries/LibDevTools/Actor.h b/Libraries/LibDevTools/Actor.h index 02cf30dc74..2a892c2788 100644 --- a/Libraries/LibDevTools/Actor.h +++ b/Libraries/LibDevTools/Actor.h @@ -19,7 +19,7 @@ namespace DevTools { -class Actor +class DEVTOOLS_API Actor : public RefCounted , public Weakable { public: diff --git a/Libraries/LibDevTools/Actors/CSSPropertiesActor.h b/Libraries/LibDevTools/Actors/CSSPropertiesActor.h index 14cce55d6d..0951fb52cb 100644 --- a/Libraries/LibDevTools/Actors/CSSPropertiesActor.h +++ b/Libraries/LibDevTools/Actors/CSSPropertiesActor.h @@ -9,6 +9,7 @@ #include #include #include +#include namespace DevTools { @@ -17,7 +18,7 @@ struct CSSProperty { bool is_inherited { false }; }; -class CSSPropertiesActor final : public Actor { +class DEVTOOLS_API CSSPropertiesActor final : public Actor { public: static constexpr auto base_name = "css-properties"sv; diff --git a/Libraries/LibDevTools/Actors/ConsoleActor.h b/Libraries/LibDevTools/Actors/ConsoleActor.h index e7da0d7285..1dc56360d8 100644 --- a/Libraries/LibDevTools/Actors/ConsoleActor.h +++ b/Libraries/LibDevTools/Actors/ConsoleActor.h @@ -8,10 +8,11 @@ #include #include +#include namespace DevTools { -class ConsoleActor final : public Actor { +class DEVTOOLS_API ConsoleActor final : public Actor { public: static constexpr auto base_name = "console"sv; diff --git a/Libraries/LibDevTools/Actors/DeviceActor.h b/Libraries/LibDevTools/Actors/DeviceActor.h index f42b369111..6506c36fcd 100644 --- a/Libraries/LibDevTools/Actors/DeviceActor.h +++ b/Libraries/LibDevTools/Actors/DeviceActor.h @@ -8,10 +8,11 @@ #include #include +#include namespace DevTools { -class DeviceActor final : public Actor { +class DEVTOOLS_API DeviceActor final : public Actor { public: static constexpr auto base_name = "device"sv; diff --git a/Libraries/LibDevTools/Actors/FrameActor.h b/Libraries/LibDevTools/Actors/FrameActor.h index 1c53415c13..3c88b2ac7d 100644 --- a/Libraries/LibDevTools/Actors/FrameActor.h +++ b/Libraries/LibDevTools/Actors/FrameActor.h @@ -10,12 +10,13 @@ #include #include #include +#include #include #include namespace DevTools { -class FrameActor final : public Actor { +class DEVTOOLS_API FrameActor final : public Actor { public: static constexpr auto base_name = "frame"sv; diff --git a/Libraries/LibDevTools/Actors/HighlighterActor.h b/Libraries/LibDevTools/Actors/HighlighterActor.h index 0dd6220372..fc1789e234 100644 --- a/Libraries/LibDevTools/Actors/HighlighterActor.h +++ b/Libraries/LibDevTools/Actors/HighlighterActor.h @@ -8,10 +8,11 @@ #include #include +#include namespace DevTools { -class HighlighterActor final : public Actor { +class DEVTOOLS_API HighlighterActor final : public Actor { public: static constexpr auto base_name = "highlighter"sv; diff --git a/Libraries/LibDevTools/Actors/InspectorActor.h b/Libraries/LibDevTools/Actors/InspectorActor.h index ae7c8df7a1..c2c3d0f3a0 100644 --- a/Libraries/LibDevTools/Actors/InspectorActor.h +++ b/Libraries/LibDevTools/Actors/InspectorActor.h @@ -9,10 +9,11 @@ #include #include #include +#include namespace DevTools { -class InspectorActor final : public Actor { +class DEVTOOLS_API InspectorActor final : public Actor { public: static constexpr auto base_name = "inspector"sv; diff --git a/Libraries/LibDevTools/Actors/LayoutInspectorActor.h b/Libraries/LibDevTools/Actors/LayoutInspectorActor.h index 4200284018..eece0d9039 100644 --- a/Libraries/LibDevTools/Actors/LayoutInspectorActor.h +++ b/Libraries/LibDevTools/Actors/LayoutInspectorActor.h @@ -8,10 +8,11 @@ #include #include +#include namespace DevTools { -class LayoutInspectorActor final : public Actor { +class DEVTOOLS_API LayoutInspectorActor final : public Actor { public: static constexpr auto base_name = "layout-inspector"sv; diff --git a/Libraries/LibDevTools/Actors/NodeActor.h b/Libraries/LibDevTools/Actors/NodeActor.h index 6b74694b19..8b8d6fd013 100644 --- a/Libraries/LibDevTools/Actors/NodeActor.h +++ b/Libraries/LibDevTools/Actors/NodeActor.h @@ -10,12 +10,13 @@ #include #include #include +#include #include #include namespace DevTools { -struct NodeIdentifier { +struct DEVTOOLS_API NodeIdentifier { static NodeIdentifier for_node(JsonObject const& node); bool operator==(NodeIdentifier const&) const = default; diff --git a/Libraries/LibDevTools/Actors/PageStyleActor.h b/Libraries/LibDevTools/Actors/PageStyleActor.h index 469e44558b..dddf1b7f9f 100644 --- a/Libraries/LibDevTools/Actors/PageStyleActor.h +++ b/Libraries/LibDevTools/Actors/PageStyleActor.h @@ -8,11 +8,12 @@ #include #include +#include #include namespace DevTools { -class PageStyleActor final : public Actor { +class DEVTOOLS_API PageStyleActor final : public Actor { public: static constexpr auto base_name = "page-style"sv; diff --git a/Libraries/LibDevTools/Actors/PreferenceActor.h b/Libraries/LibDevTools/Actors/PreferenceActor.h index bc554c8ce6..0d736696b4 100644 --- a/Libraries/LibDevTools/Actors/PreferenceActor.h +++ b/Libraries/LibDevTools/Actors/PreferenceActor.h @@ -8,10 +8,11 @@ #include #include +#include namespace DevTools { -class PreferenceActor final : public Actor { +class DEVTOOLS_API PreferenceActor final : public Actor { public: static constexpr auto base_name = "preference"sv; diff --git a/Libraries/LibDevTools/Actors/ProcessActor.h b/Libraries/LibDevTools/Actors/ProcessActor.h index 7a651b7b4e..244e9a39ae 100644 --- a/Libraries/LibDevTools/Actors/ProcessActor.h +++ b/Libraries/LibDevTools/Actors/ProcessActor.h @@ -8,6 +8,7 @@ #include #include +#include namespace DevTools { @@ -17,7 +18,7 @@ struct ProcessDescription { bool is_windowless_parent { false }; }; -class ProcessActor final : public Actor { +class DEVTOOLS_API ProcessActor final : public Actor { public: static constexpr auto base_name = "process"sv; diff --git a/Libraries/LibDevTools/Actors/RootActor.h b/Libraries/LibDevTools/Actors/RootActor.h index b600a899c8..83ef143b86 100644 --- a/Libraries/LibDevTools/Actors/RootActor.h +++ b/Libraries/LibDevTools/Actors/RootActor.h @@ -8,10 +8,11 @@ #include #include +#include namespace DevTools { -class RootActor final : public Actor { +class DEVTOOLS_API RootActor final : public Actor { public: static constexpr auto base_name = "root"sv; diff --git a/Libraries/LibDevTools/Actors/StyleSheetsActor.h b/Libraries/LibDevTools/Actors/StyleSheetsActor.h index 206e63ea44..d6f02e5855 100644 --- a/Libraries/LibDevTools/Actors/StyleSheetsActor.h +++ b/Libraries/LibDevTools/Actors/StyleSheetsActor.h @@ -9,11 +9,12 @@ #include #include #include +#include #include namespace DevTools { -class StyleSheetsActor final : public Actor { +class DEVTOOLS_API StyleSheetsActor final : public Actor { public: static constexpr auto base_name = "style-sheets"sv; diff --git a/Libraries/LibDevTools/Actors/TabActor.h b/Libraries/LibDevTools/Actors/TabActor.h index ef6d480a37..8b78f00d44 100644 --- a/Libraries/LibDevTools/Actors/TabActor.h +++ b/Libraries/LibDevTools/Actors/TabActor.h @@ -9,6 +9,7 @@ #include #include #include +#include namespace DevTools { @@ -18,7 +19,7 @@ struct TabDescription { String url; }; -class TabActor final : public Actor { +class DEVTOOLS_API TabActor final : public Actor { public: static constexpr auto base_name = "tab"sv; diff --git a/Libraries/LibDevTools/Actors/TargetConfigurationActor.h b/Libraries/LibDevTools/Actors/TargetConfigurationActor.h index ee4d6dbf6e..733516e04b 100644 --- a/Libraries/LibDevTools/Actors/TargetConfigurationActor.h +++ b/Libraries/LibDevTools/Actors/TargetConfigurationActor.h @@ -8,10 +8,11 @@ #include #include +#include namespace DevTools { -class TargetConfigurationActor final : public Actor { +class DEVTOOLS_API TargetConfigurationActor final : public Actor { public: static constexpr auto base_name = "target-configuration"sv; diff --git a/Libraries/LibDevTools/Actors/ThreadActor.h b/Libraries/LibDevTools/Actors/ThreadActor.h index c403a1a381..41d9abf0bd 100644 --- a/Libraries/LibDevTools/Actors/ThreadActor.h +++ b/Libraries/LibDevTools/Actors/ThreadActor.h @@ -8,10 +8,11 @@ #include #include +#include namespace DevTools { -class ThreadActor final : public Actor { +class DEVTOOLS_API ThreadActor final : public Actor { public: static constexpr auto base_name = "thread"sv; diff --git a/Libraries/LibDevTools/Actors/ThreadConfigurationActor.h b/Libraries/LibDevTools/Actors/ThreadConfigurationActor.h index a3ada0c113..c46b1feb18 100644 --- a/Libraries/LibDevTools/Actors/ThreadConfigurationActor.h +++ b/Libraries/LibDevTools/Actors/ThreadConfigurationActor.h @@ -8,10 +8,11 @@ #include #include +#include namespace DevTools { -class ThreadConfigurationActor final : public Actor { +class DEVTOOLS_API ThreadConfigurationActor final : public Actor { public: static constexpr auto base_name = "thread-configuration"sv; diff --git a/Libraries/LibDevTools/Actors/WalkerActor.h b/Libraries/LibDevTools/Actors/WalkerActor.h index 552e832d10..d62ba49813 100644 --- a/Libraries/LibDevTools/Actors/WalkerActor.h +++ b/Libraries/LibDevTools/Actors/WalkerActor.h @@ -12,12 +12,13 @@ #include #include #include +#include #include #include namespace DevTools { -class WalkerActor final : public Actor { +class DEVTOOLS_API WalkerActor final : public Actor { public: static constexpr auto base_name = "walker"sv; diff --git a/Libraries/LibDevTools/Actors/WatcherActor.h b/Libraries/LibDevTools/Actors/WatcherActor.h index 812712eea0..2872776053 100644 --- a/Libraries/LibDevTools/Actors/WatcherActor.h +++ b/Libraries/LibDevTools/Actors/WatcherActor.h @@ -8,10 +8,11 @@ #include #include +#include namespace DevTools { -class WatcherActor final : public Actor { +class DEVTOOLS_API WatcherActor final : public Actor { public: static constexpr auto base_name = "watcher"sv; diff --git a/Libraries/LibDevTools/CMakeLists.txt b/Libraries/LibDevTools/CMakeLists.txt index e0fca22fe8..ed9f28569d 100644 --- a/Libraries/LibDevTools/CMakeLists.txt +++ b/Libraries/LibDevTools/CMakeLists.txt @@ -23,5 +23,5 @@ set(SOURCES DevToolsServer.cpp ) -ladybird_lib(LibDevTools devtools) +ladybird_lib(LibDevTools devtools EXPLICIT_SYMBOL_EXPORT) target_link_libraries(LibDevTools PRIVATE LibCore LibWeb) diff --git a/Libraries/LibDevTools/Connection.h b/Libraries/LibDevTools/Connection.h index 4474eb5bf5..2f05666674 100644 --- a/Libraries/LibDevTools/Connection.h +++ b/Libraries/LibDevTools/Connection.h @@ -16,7 +16,7 @@ namespace DevTools { -class Connection : public RefCounted { +class DEVTOOLS_API Connection : public RefCounted { public: static NonnullRefPtr create(NonnullOwnPtr); ~Connection(); diff --git a/Libraries/LibDevTools/DevToolsDelegate.h b/Libraries/LibDevTools/DevToolsDelegate.h index 95886f4240..5c91eec6e4 100644 --- a/Libraries/LibDevTools/DevToolsDelegate.h +++ b/Libraries/LibDevTools/DevToolsDelegate.h @@ -22,7 +22,7 @@ namespace DevTools { -class DevToolsDelegate { +class DEVTOOLS_API DevToolsDelegate { public: virtual ~DevToolsDelegate() = default; diff --git a/Libraries/LibDevTools/DevToolsServer.h b/Libraries/LibDevTools/DevToolsServer.h index d256e51824..9c875706ff 100644 --- a/Libraries/LibDevTools/DevToolsServer.h +++ b/Libraries/LibDevTools/DevToolsServer.h @@ -19,7 +19,7 @@ namespace DevTools { using ActorRegistry = HashMap>; -class DevToolsServer { +class DEVTOOLS_API DevToolsServer { public: static ErrorOr> create(DevToolsDelegate&, u16 port); ~DevToolsServer(); diff --git a/Libraries/LibDevTools/Forward.h b/Libraries/LibDevTools/Forward.h index d77f025ea2..c905f716fc 100644 --- a/Libraries/LibDevTools/Forward.h +++ b/Libraries/LibDevTools/Forward.h @@ -6,6 +6,8 @@ #pragma once +#include + namespace DevTools { class Actor;