dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibThreading: Remove Weakable from Thread

Browse source 
Weakable is not thread-safe, so taking a strong reference from a
WeakPtr<Thread> may result in a use-after-free. We don't use this
functionality anywhere anyway, so remove it.
This commit is contained in:
Zaggy1024 2025-09-17 15:53:38 -05:00 committed by Gregory Bertilson
parent 2aaf53bd2c
commit fceb73e65a
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibThreading/Thread.h
View file

@ -43,8 +43,7 @@ enum class ThreadState : u8 {
};
class Thread final
: public AtomicRefCounted<Thread>
, public Weakable<Thread> {
: public AtomicRefCounted<Thread> {
public:
static NonnullRefPtr<Thread> construct(ESCAPING Function<intptr_t()> action, StringView thread_name = {})
{