245b7d74a7
Move weak container cleanup (remove_dead_cells) out of both sweep_dead_cells() and start_incremental_sweep() to the place where it is actually safe to inspect cell state: collect_garbage(). Previously, remove_dead_cells could access cells that had already been swept and poisoned by ASAN, causing use-after-poison crashes when a new GC triggered while an incremental sweep was in progress.
35 lines
645 B
C++
35 lines
645 B
C++
/*
|
|
* Copyright (c) 2021, Idan Horowitz <idan.horowitz@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/IntrusiveList.h>
|
|
#include <LibGC/Forward.h>
|
|
|
|
namespace GC {
|
|
|
|
class GC_API WeakContainer {
|
|
public:
|
|
explicit WeakContainer(Heap&);
|
|
virtual ~WeakContainer();
|
|
|
|
virtual Cell const& owner_cell(Badge<Heap>) const = 0;
|
|
virtual void remove_dead_cells(Badge<Heap>) = 0;
|
|
|
|
protected:
|
|
void deregister();
|
|
|
|
private:
|
|
bool m_registered { true };
|
|
Heap& m_heap;
|
|
|
|
IntrusiveListNode<WeakContainer> m_list_node;
|
|
|
|
public:
|
|
using List = IntrusiveList<&WeakContainer::m_list_node>;
|
|
};
|
|
|
|
}
|