568b7ce7ea
The Paintable tree and its supplemental painting data structures were GC allocated because that was the easiest way to manage it and avoid leaks introduced by ref cycles. This included the Paintable subclasses themselves plus StackingContext, ChromeWidget, Scrollbar, ResizeHandle, and scroll-frame state. We are now trying to reduce GC allocation churn on layout and painting updates, so keeping this short-lived rendering tree outside the JS heap is a better fit. Move Paintable to RefCountedTreeNode, make painting helpers ref-counted or weakly reference Paintables, and update the layout and event-handler call sites to use RefPtr/WeakPtr ownership.
67 lines
1.8 KiB
C++
67 lines
1.8 KiB
C++
/*
|
|
* Copyright (c) 2024, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/DistinctNumeric.h>
|
|
#include <AK/WeakPtr.h>
|
|
#include <LibWeb/Forward.h>
|
|
#include <LibWeb/PixelUnits.h>
|
|
|
|
namespace Web::Painting {
|
|
|
|
AK_TYPEDEF_DISTINCT_ORDERED_ID(size_t, ScrollFrameIndex);
|
|
|
|
struct StickyInsets {
|
|
Optional<CSSPixels> top;
|
|
Optional<CSSPixels> right;
|
|
Optional<CSSPixels> bottom;
|
|
Optional<CSSPixels> left;
|
|
};
|
|
|
|
struct StickyConstraints {
|
|
CSSPixelPoint position_relative_to_scroll_ancestor;
|
|
CSSPixelSize border_box_size;
|
|
CSSPixelSize scrollport_size;
|
|
CSSPixelRect containing_block_region;
|
|
bool needs_parent_offset_adjustment { false };
|
|
StickyInsets insets;
|
|
};
|
|
|
|
class ScrollFrame {
|
|
public:
|
|
ScrollFrame() = default;
|
|
ScrollFrame(PaintableBox const& paintable_box, bool sticky, ScrollFrameIndex parent_index);
|
|
|
|
PaintableBox const& paintable_box() const;
|
|
|
|
bool is_sticky() const { return m_sticky; }
|
|
|
|
CSSPixelPoint own_offset() const { return m_own_offset; }
|
|
|
|
void set_own_offset(CSSPixelPoint offset)
|
|
{
|
|
m_own_offset = offset;
|
|
}
|
|
|
|
ScrollFrameIndex parent_index() const { return m_parent_index; }
|
|
|
|
void set_sticky_constraints(StickyConstraints constraints) { m_sticky_constraints = constraints; }
|
|
bool has_sticky_constraints() const { return m_sticky_constraints.has_value(); }
|
|
StickyConstraints const& sticky_constraints() const { return m_sticky_constraints.value(); }
|
|
|
|
private:
|
|
friend class ScrollState;
|
|
friend class ScrollStateSnapshot;
|
|
|
|
WeakPtr<PaintableBox> m_paintable_box;
|
|
bool m_sticky { false };
|
|
ScrollFrameIndex m_parent_index;
|
|
CSSPixelPoint m_own_offset;
|
|
Optional<StickyConstraints> m_sticky_constraints;
|
|
};
|
|
|
|
}
|