d1fc4b4234
Previously, presentational hints bypassed the regular cascade pipeline and wrote directly into `CascadedProperties` under `CascadeOrigin::Author`. That meant `var()` substitution and the invalid-at-computed-value-time fallback had to be duplicated in a separate per-element pass, which in practice missed the IACVT step and could leave a `GuaranteedInvalidStyleValue` in the cascaded properties. This caused a crash in downstream code that assumed the value had been resolved. This introduces an `AuthorPresentationalHint` cascade origin and feeds them through the cascade as normal declarations. This means that `var()` resolution now happens in only one place.
42 lines
1.1 KiB
C++
42 lines
1.1 KiB
C++
/*
|
|
* Copyright (c) 2023, MacDue <macdue@dueutil.tech>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibGfx/Color.h>
|
|
#include <LibWeb/SVG/AttributeParser.h>
|
|
#include <LibWeb/SVG/SVGAnimatedNumber.h>
|
|
#include <LibWeb/SVG/SVGElement.h>
|
|
|
|
namespace Web::SVG {
|
|
|
|
// https://svgwg.org/svg2-draft/pservers.html#GradientStops
|
|
class SVGStopElement final : public SVGElement {
|
|
WEB_PLATFORM_OBJECT(SVGStopElement, SVGElement);
|
|
GC_DECLARE_ALLOCATOR(SVGStopElement);
|
|
|
|
public:
|
|
virtual ~SVGStopElement() override = default;
|
|
|
|
GC::Ref<SVGAnimatedNumber> offset();
|
|
|
|
virtual bool is_presentational_hint(FlyString const&) const override;
|
|
virtual void apply_presentational_hints(Vector<CSS::StyleProperty>&) const override;
|
|
|
|
float stop_offset() { return offset()->base_val(); }
|
|
Gfx::Color stop_color();
|
|
float stop_opacity() const;
|
|
|
|
private:
|
|
SVGStopElement(DOM::Document&, DOM::QualifiedName);
|
|
|
|
virtual void initialize(JS::Realm&) override;
|
|
virtual void visit_edges(Visitor&) override;
|
|
|
|
GC::Ptr<SVGAnimatedNumber> m_stop_offset;
|
|
};
|
|
|
|
}
|