48a0e9fef7
Add the same connect timeout used by regular requests to curl-backed websockets, buffer unsent websocket bytes, and resume them from a write notifier instead of retrying curl_easy_send() in a tight loop. This prevents CPU spins on CURLE_AGAIN and keeps large websocket sends from hanging when the peer applies backpressure.
54 lines
1.4 KiB
C++
54 lines
1.4 KiB
C++
/*
|
|
* Copyright (c) 2025, Andrew Kaster <andrew@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/MemoryStream.h>
|
|
#include <LibCore/Forward.h>
|
|
#include <LibWebSocket/Impl/WebSocketImpl.h>
|
|
|
|
typedef void CURL;
|
|
typedef void CURLM;
|
|
struct curl_slist;
|
|
|
|
namespace RequestServer {
|
|
|
|
class WebSocketImplCurl final : public WebSocket::WebSocketImpl {
|
|
public:
|
|
virtual ~WebSocketImplCurl() override;
|
|
|
|
static NonnullRefPtr<WebSocketImplCurl> create(CURLM*);
|
|
|
|
virtual void connect(WebSocket::ConnectionInfo const&) override;
|
|
virtual bool can_read_line() override;
|
|
virtual ErrorOr<ByteString> read_line(size_t) override;
|
|
virtual ErrorOr<ByteBuffer> read(int max_size) override;
|
|
virtual bool send(ReadonlyBytes) override;
|
|
virtual bool eof() override;
|
|
virtual void discard_connection() override;
|
|
|
|
virtual bool handshake_complete_when_connected() const override { return true; }
|
|
|
|
bool did_connect();
|
|
|
|
private:
|
|
explicit WebSocketImplCurl(CURLM*);
|
|
|
|
void read_from_socket();
|
|
bool flush_pending_write_buffer();
|
|
|
|
CURLM* m_multi_handle { nullptr };
|
|
CURL* m_easy_handle { nullptr };
|
|
RefPtr<Core::Notifier> m_read_notifier;
|
|
RefPtr<Core::Notifier> m_write_notifier;
|
|
RefPtr<Core::Notifier> m_error_notifier;
|
|
Vector<curl_slist*> m_curl_string_lists;
|
|
AllocatingMemoryStream m_read_buffer;
|
|
ByteBuffer m_pending_write_buffer;
|
|
size_t m_pending_write_buffer_offset { 0 };
|
|
};
|
|
|
|
}
|