706eb0018c
Let's make sure that subclasses always call their base class when overriding these virtuals: - void finalize() - void visit_edges(Visitor&)
56 lines
1.9 KiB
C++
56 lines
1.9 KiB
C++
/*
|
|
* Copyright (c) 2026, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
// RUN: %clang++ -Xclang -verify %plugin_opts% -c %s -o %t 2>&1
|
|
|
|
#include <LibGC/Cell.h>
|
|
|
|
// Class that overrides must_survive_garbage_collection without the flag - ERROR
|
|
class MissingSurviveFlag : public GC::Cell {
|
|
GC_CELL(MissingSurviveFlag, GC::Cell);
|
|
|
|
// expected-error@+1 {{Class MissingSurviveFlag overrides must_survive_garbage_collection but does not set static constexpr bool OVERRIDES_MUST_SURVIVE_GARBAGE_COLLECTION = true}}
|
|
virtual bool must_survive_garbage_collection() const override { return true; }
|
|
};
|
|
|
|
// Class that overrides finalize without the flag - ERROR
|
|
class MissingFinalizeFlag : public GC::Cell {
|
|
GC_CELL(MissingFinalizeFlag, GC::Cell);
|
|
|
|
// expected-error@+1 {{Class MissingFinalizeFlag overrides finalize but does not set static constexpr bool OVERRIDES_FINALIZE = true}}
|
|
virtual void finalize() override { Base::finalize(); }
|
|
};
|
|
|
|
// Class that correctly sets the survive flag - OK
|
|
class CorrectSurviveFlag : public GC::Cell {
|
|
GC_CELL(CorrectSurviveFlag, GC::Cell);
|
|
|
|
public:
|
|
static constexpr bool OVERRIDES_MUST_SURVIVE_GARBAGE_COLLECTION = true;
|
|
|
|
virtual bool must_survive_garbage_collection() const override { return true; }
|
|
};
|
|
|
|
// Class that correctly sets the finalize flag - OK
|
|
class CorrectFinalizeFlag : public GC::Cell {
|
|
GC_CELL(CorrectFinalizeFlag, GC::Cell);
|
|
|
|
public:
|
|
static constexpr bool OVERRIDES_FINALIZE = true;
|
|
|
|
virtual void finalize() override { Base::finalize(); }
|
|
};
|
|
|
|
// Class that sets the flag to false - ERROR (flag must be true)
|
|
class FlagSetToFalse : public GC::Cell {
|
|
GC_CELL(FlagSetToFalse, GC::Cell);
|
|
|
|
public:
|
|
static constexpr bool OVERRIDES_FINALIZE = false;
|
|
|
|
// expected-error@+1 {{Class FlagSetToFalse overrides finalize but does not set static constexpr bool OVERRIDES_FINALIZE = true}}
|
|
virtual void finalize() override { Base::finalize(); }
|
|
};
|