95b464fb8b
This extends the LibJSGC Clang plugin to detect GC pointers (GC::Ptr, GC::Ref, JS::Value, etc.) inside non-GC-allocated struct/class members. When a GC::Cell has a member of a non-Cell type that contains GC pointers, we now enforce that: 1. The non-Cell type must have a visit_edges(GC::Cell::Visitor&) method 2. The Cell's visit_edges must access that member (presumably to call its visit_edges) The check works recursively, so nested structs and containers like Vector<GC::Ptr<T>> or HashMap<K, GC::Ptr<V>> are handled correctly. GC infrastructure types (Root, Heap, etc.) and AK library types are excluded from these checks as they handle visitation differently.
42 lines
935 B
C++
42 lines
935 B
C++
/*
|
|
* Copyright (c) 2026, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
// RUN: %clang++ -Xclang -verify %plugin_opts% -c %s -o %t 2>&1
|
|
// expected-no-diagnostics
|
|
|
|
#include <LibJS/Runtime/Object.h>
|
|
|
|
// Inner struct containing a GC pointer with proper visit_edges
|
|
struct InnerStruct {
|
|
GC::Ptr<JS::Object> m_inner_object;
|
|
|
|
void visit_edges(JS::Cell::Visitor& visitor)
|
|
{
|
|
visitor.visit(m_inner_object);
|
|
}
|
|
};
|
|
|
|
// Outer struct containing the inner struct with proper visit_edges
|
|
struct OuterStruct {
|
|
InnerStruct m_inner;
|
|
|
|
void visit_edges(JS::Cell::Visitor& visitor)
|
|
{
|
|
m_inner.visit_edges(visitor);
|
|
}
|
|
};
|
|
|
|
class TestClass : public JS::Object {
|
|
JS_OBJECT(TestClass, JS::Object);
|
|
|
|
virtual void visit_edges(Visitor& visitor) override
|
|
{
|
|
Base::visit_edges(visitor);
|
|
m_outer.visit_edges(visitor);
|
|
}
|
|
|
|
OuterStruct m_outer;
|
|
};
|