Problem: CSSPixels::abs() invokes UB for the i32 minimum raw value. Cause: abs() returned from_raw(::abs(m_value)) — and ::abs() of the i32 minimum isn’t representable as an int. Fix: Compute the magnitude with saturating_sub(0, raw_value()) for negative inputs — so the i32 minimum saturates to the maximum.
179 lines
4.7 KiB
C++
179 lines
4.7 KiB
C++
/*
|
|
* Copyright (c) 2023, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibTest/TestCase.h>
|
|
#include <LibWeb/PixelUnits.h>
|
|
|
|
namespace Web {
|
|
|
|
TEST_CASE(addition1)
|
|
{
|
|
CSSPixels a(10);
|
|
CSSPixels b(20);
|
|
CSSPixels c = a + b;
|
|
EXPECT_EQ(c, CSSPixels(30));
|
|
}
|
|
|
|
TEST_CASE(subtraction1)
|
|
{
|
|
CSSPixels a(30);
|
|
CSSPixels b(10);
|
|
CSSPixels c = a - b;
|
|
EXPECT_EQ(c, CSSPixels(20));
|
|
}
|
|
|
|
TEST_CASE(division1)
|
|
{
|
|
CSSPixels a(10);
|
|
CSSPixels b(5);
|
|
CSSPixels c = a / b;
|
|
EXPECT_EQ(c, CSSPixels(2));
|
|
|
|
a = CSSPixels::from_raw(0x3FFF'FFFF); // int_max / 2
|
|
b = CSSPixels(0.25);
|
|
EXPECT(!a.might_be_saturated());
|
|
EXPECT((a / b).might_be_saturated());
|
|
}
|
|
|
|
TEST_CASE(multiplication1)
|
|
{
|
|
CSSPixels a(3);
|
|
CSSPixels b(4);
|
|
CSSPixels c = a * b;
|
|
EXPECT_EQ(c, CSSPixels(12));
|
|
|
|
// Temporary overflow
|
|
a = CSSPixels::from_raw(0xFFFF'FFFF >> (CSSPixels::fractional_bits + 1));
|
|
b = 1;
|
|
EXPECT_EQ((a * b), a);
|
|
|
|
// Rounding
|
|
a = CSSPixels::from_raw(0b01'000001);
|
|
b = CSSPixels::from_raw(0b01'100000);
|
|
EXPECT_EQ(a * b, CSSPixels(a.to_double() * b.to_double()));
|
|
EXPECT_EQ(a * -b, CSSPixels(a.to_double() * -b.to_double()));
|
|
|
|
EXPECT_EQ(
|
|
CSSPixels::from_raw(0b01'0000011) * CSSPixels::from_raw(0b00'010000),
|
|
CSSPixels::from_raw(0b00'0100001));
|
|
EXPECT_EQ(
|
|
CSSPixels::from_raw(0b01'0000111) * CSSPixels::from_raw(0b00'010000),
|
|
CSSPixels::from_raw(0b00'0100010));
|
|
}
|
|
|
|
TEST_CASE(addition2)
|
|
{
|
|
CSSPixels a(3);
|
|
a += CSSPixels(2);
|
|
EXPECT_EQ(a, CSSPixels(5));
|
|
}
|
|
|
|
TEST_CASE(to_double)
|
|
{
|
|
CSSPixels a(10);
|
|
EXPECT_EQ(a.to_double(), 10);
|
|
}
|
|
|
|
TEST_CASE(to_float)
|
|
{
|
|
CSSPixels a(11);
|
|
EXPECT_EQ(a.to_float(), 11);
|
|
}
|
|
|
|
TEST_CASE(to_int)
|
|
{
|
|
CSSPixels b(12);
|
|
EXPECT_EQ(b.to_int(), 12);
|
|
}
|
|
|
|
TEST_CASE(float_conversion)
|
|
{
|
|
auto value = 620.0 * .333333;
|
|
EXPECT_EQ(CSSPixels::nearest_value_for(value), CSSPixels::from_raw(13227));
|
|
EXPECT_EQ(CSSPixels::floored_value_for(value), CSSPixels::from_raw(13226));
|
|
EXPECT_EQ(CSSPixels::truncated_value_for(value), CSSPixels::from_raw(13226));
|
|
|
|
EXPECT_EQ(CSSPixels::floored_value_for(-value), CSSPixels::from_raw(-13227));
|
|
EXPECT_EQ(CSSPixels::truncated_value_for(-value), CSSPixels::from_raw(-13226));
|
|
|
|
EXPECT_EQ(CSSPixels::truncated_value_for(INFINITY), CSSPixels::max());
|
|
EXPECT_EQ(CSSPixels::truncated_value_for(-INFINITY), CSSPixels::min());
|
|
}
|
|
|
|
TEST_CASE(comparison1)
|
|
{
|
|
EXPECT_EQ(CSSPixels(1) < CSSPixels(2), true);
|
|
}
|
|
|
|
TEST_CASE(comparison2)
|
|
{
|
|
EXPECT_EQ(CSSPixels(123) == CSSPixels(123), true);
|
|
}
|
|
|
|
TEST_CASE(saturated_addition)
|
|
{
|
|
EXPECT_EQ(CSSPixels(INFINITY), CSSPixels(INFINITY) + 1);
|
|
}
|
|
|
|
TEST_CASE(saturated_subtraction)
|
|
{
|
|
auto value = CSSPixels(INFINITY);
|
|
EXPECT_EQ(value - -1, CSSPixels(INFINITY));
|
|
}
|
|
|
|
TEST_CASE(saturated_abs)
|
|
{
|
|
// abs() of the minimum saturates to the maximum instead of overflowing.
|
|
EXPECT_EQ(CSSPixels::min().abs(), CSSPixels::max());
|
|
EXPECT_EQ(CSSPixels::from_raw(-5).abs(), CSSPixels::from_raw(5));
|
|
EXPECT_EQ(CSSPixels::from_raw(5).abs(), CSSPixels::from_raw(5));
|
|
}
|
|
|
|
TEST_CASE(multiplication_uses_i64_for_raw_values)
|
|
{
|
|
CSSPixels a(1200);
|
|
CSSPixels b(647);
|
|
CSSPixels c = a * b;
|
|
EXPECT_EQ(c, CSSPixels(776400));
|
|
}
|
|
|
|
TEST_CASE(rounding)
|
|
{
|
|
EXPECT_EQ(ceil(CSSPixels(0)), CSSPixels(0));
|
|
EXPECT_EQ(ceil(CSSPixels(0.5)), CSSPixels(1));
|
|
EXPECT_EQ(ceil(CSSPixels(1.3)), CSSPixels(2));
|
|
EXPECT_EQ(ceil(CSSPixels(1.5)), CSSPixels(2));
|
|
EXPECT_EQ(ceil(CSSPixels(1.7)), CSSPixels(2));
|
|
|
|
EXPECT_EQ(ceil(CSSPixels(-0.5)), CSSPixels(0));
|
|
EXPECT_EQ(ceil(CSSPixels(-1.3)), CSSPixels(-1));
|
|
EXPECT_EQ(ceil(CSSPixels(-1.5)), CSSPixels(-1));
|
|
EXPECT_EQ(ceil(CSSPixels(-1.7)), CSSPixels(-1));
|
|
|
|
EXPECT_EQ(floor(CSSPixels(0)), CSSPixels(0));
|
|
EXPECT_EQ(floor(CSSPixels(0.5)), CSSPixels(0));
|
|
EXPECT_EQ(floor(CSSPixels(1.3)), CSSPixels(1));
|
|
EXPECT_EQ(floor(CSSPixels(1.5)), CSSPixels(1));
|
|
EXPECT_EQ(floor(CSSPixels(1.7)), CSSPixels(1));
|
|
|
|
EXPECT_EQ(floor(CSSPixels(-0.5)), CSSPixels(-1));
|
|
EXPECT_EQ(floor(CSSPixels(-1.3)), CSSPixels(-2));
|
|
EXPECT_EQ(floor(CSSPixels(-1.5)), CSSPixels(-2));
|
|
EXPECT_EQ(floor(CSSPixels(-1.7)), CSSPixels(-2));
|
|
|
|
EXPECT_EQ(round(CSSPixels(0)), CSSPixels(0));
|
|
EXPECT_EQ(round(CSSPixels(0.5)), CSSPixels(1));
|
|
EXPECT_EQ(round(CSSPixels(1.3)), CSSPixels(1));
|
|
EXPECT_EQ(round(CSSPixels(1.5)), CSSPixels(2));
|
|
EXPECT_EQ(round(CSSPixels(1.7)), CSSPixels(2));
|
|
|
|
EXPECT_EQ(round(CSSPixels(-0.5)), CSSPixels(-1));
|
|
EXPECT_EQ(round(CSSPixels(-1.3)), CSSPixels(-1));
|
|
EXPECT_EQ(round(CSSPixels(-1.5)), CSSPixels(-2));
|
|
EXPECT_EQ(round(CSSPixels(-1.7)), CSSPixels(-2));
|
|
}
|
|
|
|
}
|