028eb0a966
Problem: is_within_range<I>(F value) — where I is an integer and F is a floating-point type — is unexpectedly too permissive in some cases: a. Values that are 1 past the integer range unexpectedly pass; e.g., is_within_range<int>(2147483648.0f) returns true — even though 2147483648 is INT_MAX + 1. b. Fractional values whose magnitude exceeds the destination max unexpectedly pass; e.g., is_within_range<unsigned>(4294967295.5) returns true — even though 4294967295.5 > UINT_MAX. c. Fractional values within the destination’s numeric range unexpectedly pass (e.g., is_within_range<int>(2.5) returns true) — even though they aren’t exactly representable as the destination type. Cause: TypeBoundsChecker integer-bounds specializations compare against NumericLimits<Destination>::max() and ::min() directly. When a caller’s value is a float, the integer max/min get implicitly converted to a float for the comparison. For Destination/Source pairs with the integer extreme not exactly representable in the float, that conversion rounds up to the next power-of-two boundary — so “value <= F(max)” accepts values that are actually out of range by one (case a). And the comparison itself doesn’t reject fractional values (cases b and c). Fix: When Source is a floating-point type: 1. First gate (case a) — Compare against 2^digits; exactly representable in any IEEE float, and equals max + 1 for unsigned / -min for two’s- complement signed integers. 2. Second gate (cases b and c) – Round-trip check: cast value to Destination, then cast back — and require equality. Only integer- valued floats whose truncation matches the original pass. Fixes https://github.com/LadybirdBrowser/ladybird/issues/6212 |
||
|---|---|---|
| .devcontainer | ||
| .github | ||
| AK | ||
| Base/res | ||
| Documentation | ||
| Libraries | ||
| Meta | ||
| Services | ||
| Tests | ||
| UI | ||
| Utilities | ||
| .clang-format | ||
| .clang-tidy | ||
| .clangd | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .pre-commit-config.yaml | ||
| .prettierignore | ||
| .prettierrc | ||
| .ycm_extra_conf.py | ||
| Cargo.lock | ||
| Cargo.toml | ||
| CMakeLists.txt | ||
| CMakePresets.json | ||
| CODE_OF_CONDUCT.md | ||
| CONTRIBUTING.md | ||
| ISSUES.md | ||
| LICENSE | ||
| pyproject.toml | ||
| README.md | ||
| rust-toolchain.toml | ||
| rustfmt.toml | ||
| SECURITY.md | ||
| vcpkg-configuration.json | ||
| vcpkg.json | ||
Ladybird
Ladybird is a truly independent web browser, using a novel engine based on web standards.
Important
Ladybird is in a pre-alpha state, and only suitable for use by developers
Features
We aim to build a complete, usable browser for the modern web.
Ladybird uses a multi-process architecture with a main UI process, several WebContent renderer processes, an ImageDecoder process, and a RequestServer process.
Image decoding and network connections are done out of process to be more robust against malicious content. Each tab has its own renderer process, which is sandboxed from the rest of the system.
At the moment, many core library support components are inherited from SerenityOS:
- LibWeb: Web rendering engine
- LibJS: JavaScript engine
- LibWasm: WebAssembly implementation
- LibCrypto/LibTLS: Cryptography primitives and Transport Layer Security
- LibHTTP: HTTP/1.1 client
- LibGfx: 2D Graphics Library, Image Decoding and Rendering
- LibUnicode: Unicode and locale support
- LibMedia: Audio and video playback
- LibCore: Event loop, OS abstraction layer
- LibIPC: Inter-process communication
How do I build and run this?
See build instructions for information on how to build Ladybird.
Ladybird runs on Linux, macOS, Windows (with WSL2), and many other *Nixes.
How do I read the documentation?
Code-related documentation can be found in the documentation folder.
Get in touch and participate!
Join our Discord server to participate in development discussion.
Please read Getting started contributing if you plan to contribute to Ladybird for the first time.
Before opening an issue, please see the issue policy and the detailed issue-reporting guidelines.
The full contribution guidelines can be found in CONTRIBUTING.md.
License
Ladybird is licensed under a 2-clause BSD license.