Move CSS animation values into a mutable overlay on computed properties and make base computed style data immutable after construction. Base style mutation now goes through a builder that is consumed on publish, so installed styles no longer expose mutation APIs. Build new base style data for inherited style updates instead of cloning and mutating installed computed properties. Element-specific computed style adjustments now run before publication, while animation and transition updates continue to mutate only the animated overlay.
71 lines
2.7 KiB
C++
71 lines
2.7 KiB
C++
/*
|
|
* Copyright (c) 2018-2021, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/Bindings/HTMLBRElement.h>
|
|
#include <LibWeb/CSS/ComputedProperties.h>
|
|
#include <LibWeb/CSS/StyleValues/DisplayStyleValue.h>
|
|
#include <LibWeb/CSS/StyleValues/KeywordStyleValue.h>
|
|
#include <LibWeb/DOM/Document.h>
|
|
#include <LibWeb/HTML/HTMLBRElement.h>
|
|
#include <LibWeb/Layout/BreakNode.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
GC_DEFINE_ALLOCATOR(HTMLBRElement);
|
|
|
|
HTMLBRElement::HTMLBRElement(DOM::Document& document, DOM::QualifiedName qualified_name)
|
|
: HTMLElement(document, move(qualified_name))
|
|
{
|
|
}
|
|
|
|
HTMLBRElement::~HTMLBRElement() = default;
|
|
|
|
void HTMLBRElement::initialize(JS::Realm& realm)
|
|
{
|
|
WEB_SET_PROTOTYPE_FOR_INTERFACE(HTMLBRElement);
|
|
Base::initialize(realm);
|
|
}
|
|
|
|
RefPtr<Layout::Node> HTMLBRElement::create_layout_node(CSS::ComputedProperties const& style)
|
|
{
|
|
return make_ref_counted<Layout::BreakNode>(document(), *this, style);
|
|
}
|
|
|
|
bool HTMLBRElement::is_presentational_hint(FlyString const& name) const
|
|
{
|
|
if (Base::is_presentational_hint(name))
|
|
return true;
|
|
|
|
return name == HTML::AttributeNames::clear;
|
|
}
|
|
|
|
void HTMLBRElement::apply_presentational_hints(Vector<CSS::StyleProperty>& properties) const
|
|
{
|
|
Base::apply_presentational_hints(properties);
|
|
for_each_attribute([&](auto& name, auto& value) {
|
|
// https://html.spec.whatwg.org/multipage/rendering.html#phrasing-content-3
|
|
if (name == HTML::AttributeNames::clear) {
|
|
if (value.equals_ignoring_ascii_case("left"sv))
|
|
properties.append({ .property_id = CSS::PropertyID::Clear, .value = CSS::KeywordStyleValue::create(CSS::Keyword::Left) });
|
|
else if (value.equals_ignoring_ascii_case("right"sv))
|
|
properties.append({ .property_id = CSS::PropertyID::Clear, .value = CSS::KeywordStyleValue::create(CSS::Keyword::Right) });
|
|
else if (value.equals_ignoring_ascii_case("all"sv) || value.equals_ignoring_ascii_case("both"sv))
|
|
properties.append({ .property_id = CSS::PropertyID::Clear, .value = CSS::KeywordStyleValue::create(CSS::Keyword::Both) });
|
|
}
|
|
});
|
|
}
|
|
|
|
void HTMLBRElement::adjust_computed_style(CSS::ComputedProperties::Builder& style)
|
|
{
|
|
// https://drafts.csswg.org/css-display-3/#unbox
|
|
if (style.display().is_contents())
|
|
style.set_property(CSS::PropertyID::Display, CSS::DisplayStyleValue::create(CSS::Display::from_short(CSS::Display::Short::None)));
|
|
else if (!style.display().is_none())
|
|
// AD-HOC: Prevent other display values from applying, so that we always create a BreakNode
|
|
style.set_property(CSS::PropertyID::Display, CSS::DisplayStyleValue::create(CSS::Display::from_short(CSS::Display::Short::Inline)));
|
|
}
|
|
|
|
}
|