Recording a display list for an SVG image triggered a full layout update on the SVG's internal document and re-recorded the commands on every paint. Pages with many small SVG icons therefore could accumulate tens of thousands of redundant layout updates per page load. We now cache these display lists per output size to avoid this redundant work. The cache currently uses the same 10 entry cap as the cache for rendered surfaces.
118 lines
5 KiB
C++
118 lines
5 KiB
C++
/*
|
|
* Copyright (c) 2023, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibGfx/DecodedImageFrame.h>
|
|
#include <LibWeb/HTML/DecodedImageData.h>
|
|
#include <LibWeb/Page/Page.h>
|
|
#include <LibWeb/Painting/DisplayList.h>
|
|
#include <LibWeb/Painting/DisplayListResourceStorage.h>
|
|
|
|
namespace Web::SVG {
|
|
|
|
class SVGDecodedImageData final : public HTML::DecodedImageData {
|
|
GC_CELL(SVGDecodedImageData, HTML::DecodedImageData);
|
|
GC_DECLARE_ALLOCATOR(SVGDecodedImageData);
|
|
|
|
public:
|
|
class SVGPageClient;
|
|
static ErrorOr<GC::Ref<SVGDecodedImageData>> create(JS::Realm&, GC::Ref<Page>, URL::URL const&, ReadonlyBytes encoded_svg);
|
|
virtual ~SVGDecodedImageData() override;
|
|
|
|
virtual Optional<Gfx::DecodedImageFrame> frame(size_t frame_index, Gfx::IntSize) const override;
|
|
|
|
virtual Optional<CSSPixels> intrinsic_width() const override;
|
|
virtual Optional<CSSPixels> intrinsic_height() const override;
|
|
virtual Optional<CSSPixelFraction> intrinsic_aspect_ratio() const override;
|
|
|
|
// FIXME: Support SVG animations. :^)
|
|
virtual int frame_duration(size_t) const override { return 0; }
|
|
virtual size_t frame_count() const override { return 1; }
|
|
virtual size_t loop_count() const override { return 0; }
|
|
virtual bool is_animated() const override { return false; }
|
|
|
|
DOM::Document const& svg_document() const { return *m_document; }
|
|
|
|
virtual void visit_edges(Cell::Visitor& visitor) override;
|
|
virtual size_t external_memory_size() const override;
|
|
|
|
virtual Optional<Gfx::IntRect> frame_rect(size_t frame_index) const override;
|
|
virtual void paint(DisplayListRecordingContext&, size_t frame_index, Gfx::IntRect dst_rect, Gfx::IntRect clip_rect, Gfx::ScalingMode scaling_mode) const override;
|
|
|
|
private:
|
|
SVGDecodedImageData(GC::Ref<Page>, GC::Ref<SVGPageClient>, GC::Ref<DOM::Document>, GC::Ref<SVG::SVGSVGElement>);
|
|
|
|
RefPtr<Gfx::PaintingSurface> surface(size_t frame_index, Gfx::IntSize) const;
|
|
RefPtr<Gfx::PaintingSurface> render_to_surface(Gfx::IntSize) const;
|
|
RefPtr<Painting::DisplayList> record_display_list(Gfx::IntSize, Painting::DisplayListResourceStorage&) const;
|
|
|
|
// FIXME: Remove this once everything is using surfaces instead.
|
|
mutable HashMap<Gfx::IntSize, Gfx::DecodedImageFrame> m_cached_rendered_frames;
|
|
|
|
mutable HashMap<Gfx::IntSize, NonnullRefPtr<Gfx::PaintingSurface>> m_cached_rendered_surfaces;
|
|
|
|
struct CachedDisplayList {
|
|
RefPtr<Painting::DisplayList> display_list;
|
|
Painting::DisplayListResourceStorage resource_storage;
|
|
};
|
|
mutable HashMap<Gfx::IntSize, CachedDisplayList> m_cached_display_lists;
|
|
|
|
GC::Ref<Page> m_page;
|
|
GC::Ref<SVGPageClient> m_page_client;
|
|
|
|
GC::Ref<DOM::Document> m_document;
|
|
GC::Ref<SVG::SVGSVGElement> m_root_element;
|
|
};
|
|
|
|
class SVGDecodedImageData::SVGPageClient final : public PageClient {
|
|
GC_CELL(SVGDecodedImageData::SVGPageClient, PageClient);
|
|
GC_DECLARE_ALLOCATOR(SVGDecodedImageData::SVGPageClient);
|
|
|
|
public:
|
|
static GC::Ref<SVGPageClient> create(JS::VM& vm, Page& page)
|
|
{
|
|
return vm.heap().allocate<SVGPageClient>(page);
|
|
}
|
|
|
|
virtual ~SVGPageClient() override = default;
|
|
|
|
GC::Ref<Page> m_host_page;
|
|
GC::Ptr<Page> m_svg_page;
|
|
|
|
virtual u64 id() const override { VERIFY_NOT_REACHED(); }
|
|
virtual Page& page() override { return *m_svg_page; }
|
|
virtual Page const& page() const override { return *m_svg_page; }
|
|
virtual bool is_connection_open() const override { return false; }
|
|
virtual Gfx::Palette palette() const override { return m_host_page->client().palette(); }
|
|
virtual DevicePixelRect screen_rect() const override { return {}; }
|
|
virtual double zoom_level() const override { return 1.0; }
|
|
virtual double device_pixel_ratio() const override { return 1.0; }
|
|
virtual double device_pixels_per_css_pixel() const override { return 1.0; }
|
|
virtual CSS::PreferredColorScheme preferred_color_scheme() const override { return m_host_page->client().preferred_color_scheme(); }
|
|
virtual CSS::PreferredContrast preferred_contrast() const override { return m_host_page->client().preferred_contrast(); }
|
|
virtual CSS::PreferredMotion preferred_motion() const override { return m_host_page->client().preferred_motion(); }
|
|
virtual size_t screen_count() const override { return 1; }
|
|
virtual void request_file(FileRequest) override { }
|
|
virtual Queue<QueuedInputEvent>& input_event_queue() override { VERIFY_NOT_REACHED(); }
|
|
virtual void report_finished_handling_input_event([[maybe_unused]] u64 page_id, [[maybe_unused]] EventResult event_was_handled) override { }
|
|
virtual void request_frame() override { }
|
|
|
|
virtual DisplayListPlayerType display_list_player_type() const override { return m_host_page->client().display_list_player_type(); }
|
|
virtual bool is_headless() const override { return m_host_page->client().is_headless(); }
|
|
|
|
private:
|
|
explicit SVGPageClient(Page& host_page)
|
|
: m_host_page(host_page)
|
|
{
|
|
}
|
|
|
|
virtual bool is_svg_page_client() const override { return true; }
|
|
|
|
virtual void visit_edges(Visitor&) override;
|
|
};
|
|
|
|
}
|