9340d2d1a3
Move the layout tree from GC allocation to refcounted ownership so removed layout and paint subtrees are destroyed synchronously instead of waiting for the next GC sweep. This dramatically reduces GC memory usage peaks after layout tree churn and makes it easier for memory use to fall back after large document updates. Update layout factories, tree traversal, SVG layout node creation, paintable back-pointers, and pseudo-element layout links to use RefPtr ownership. Make display: contents follow the same shape as Blink and WebKit: the element itself does not create a layout node, and its children are flattened into the nearest layout parent. Wrap direct non-whitespace text in an anonymous inline node when the boxless element contributes inherited style to that text. Use an internal inline wrapper for display: contents pseudo-elements so generated content can still participate in layout, painting, hit testing, and pseudo-element queries. Keep CSSOM reporting the computed display value from the pseudo style, not the internal wrapper. Remove the retained out-of-tree layout node list and its testing hook, since the flattened model does not need a side owner for boxless elements. Add coverage for inherited text style, dynamic insertion order, pseudo-element hit testing, and computed style queries.
75 lines
2.5 KiB
C++
75 lines
2.5 KiB
C++
/*
|
||
* Copyright (c) 2023, Preston Taylor <95388976+PrestonLTaylor@users.noreply.github.com>
|
||
*
|
||
* SPDX-License-Identifier: BSD-2-Clause
|
||
*/
|
||
|
||
#include <LibWeb/Bindings/Intrinsics.h>
|
||
#include <LibWeb/Bindings/SVGSymbolElement.h>
|
||
#include <LibWeb/CSS/ComputedProperties.h>
|
||
#include <LibWeb/CSS/StyleValues/DisplayStyleValue.h>
|
||
#include <LibWeb/DOM/ShadowRoot.h>
|
||
#include <LibWeb/Layout/SVGGraphicsBox.h>
|
||
#include <LibWeb/SVG/SVGSymbolElement.h>
|
||
#include <LibWeb/SVG/SVGUseElement.h>
|
||
|
||
namespace Web::SVG {
|
||
|
||
GC_DEFINE_ALLOCATOR(SVGSymbolElement);
|
||
|
||
SVGSymbolElement::SVGSymbolElement(DOM::Document& document, DOM::QualifiedName qualified_name)
|
||
: SVGGraphicsElement(document, qualified_name)
|
||
{
|
||
}
|
||
|
||
void SVGSymbolElement::initialize(JS::Realm& realm)
|
||
{
|
||
WEB_SET_PROTOTYPE_FOR_INTERFACE(SVGSymbolElement);
|
||
Base::initialize(realm);
|
||
SVGFitToViewBox::initialize(realm);
|
||
}
|
||
|
||
void SVGSymbolElement::visit_edges(Cell::Visitor& visitor)
|
||
{
|
||
Base::visit_edges(visitor);
|
||
SVGFitToViewBox::visit_edges(visitor);
|
||
}
|
||
|
||
void SVGSymbolElement::adjust_computed_style(CSS::ComputedProperties& computed_properties)
|
||
{
|
||
Base::adjust_computed_style(computed_properties);
|
||
|
||
if (is_direct_child_of_use_shadow_tree()) {
|
||
// The generated instance of a ‘symbol’ that is the direct referenced element of a ‘use’ element must always have a computed value of inline for the display property.
|
||
computed_properties.set_property(CSS::PropertyID::Display, CSS::DisplayStyleValue::create(CSS::Display::from_short(CSS::Display::Short::Inline)));
|
||
}
|
||
}
|
||
|
||
void SVGSymbolElement::attribute_changed(FlyString const& name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_)
|
||
{
|
||
Base::attribute_changed(name, old_value, value, namespace_);
|
||
SVGFitToViewBox::attribute_changed(*this, name, value);
|
||
}
|
||
|
||
bool SVGSymbolElement::is_direct_child_of_use_shadow_tree() const
|
||
{
|
||
auto maybe_shadow_root = parent();
|
||
if (!is<DOM::ShadowRoot>(maybe_shadow_root)) {
|
||
return false;
|
||
}
|
||
|
||
auto host = static_cast<DOM::ShadowRoot const&>(*maybe_shadow_root).host();
|
||
return is<SVGUseElement>(host);
|
||
}
|
||
|
||
RefPtr<Layout::Node> SVGSymbolElement::create_layout_node(CSS::ComputedProperties const& style)
|
||
{
|
||
// https://svgwg.org/svg2-draft/render.html#TermNeverRenderedElement
|
||
// [..] it also includes a ‘symbol’ element that is not the instance root of a use-element shadow tree.
|
||
if (!is_direct_child_of_use_shadow_tree())
|
||
return {};
|
||
|
||
return make_ref_counted<Layout::SVGGraphicsBox>(document(), *this, style);
|
||
}
|
||
|
||
}
|