dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Clarify the capture safety in HTMLMediaElement::fetch_resource

Browse source 
These tasks' captures aren't clearly safe as written, since raw
references don't make it apparent that we're capturing a GC-aware
reference. Conservative scanning made this safe, but let's make it a
bit clearer.
This commit is contained in:
Zaggy1024 2026-02-19 15:59:26 -06:00 committed by Gregory Bertilson
parent cf180bd4da
commit ebda8fcf11
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View file

@ -1134,8 +1134,8 @@ void HTMLMediaElement::fetch_resource(NonnullRefPtr<FetchData> const& fetch_data
fetch_data->stream->add_chunk_at(fetch_data->offset, media_data.bytes());
fetch_data->offset += media_data.size();
weak_self->queue_a_media_element_task([&self = *weak_self] {
self.process_media_data(FetchingStatus::Ongoing).release_value_but_fixme_should_propagate_errors();
weak_self->queue_a_media_element_task([self = weak_self.as_nonnull()] {
self->process_media_data(FetchingStatus::Ongoing).release_value_but_fixme_should_propagate_errors();
});
});
@ -1150,8 +1150,8 @@ void HTMLMediaElement::fetch_resource(NonnullRefPtr<FetchData> const& fetch_data
return;
fetch_data->stream->close();
weak_self->queue_a_media_element_task([&self = *weak_self] {
self.process_media_data(FetchingStatus::Complete).release_value_but_fixme_should_propagate_errors();
weak_self->queue_a_media_element_task([self = weak_self.as_nonnull()] {
self->process_media_data(FetchingStatus::Complete).release_value_but_fixme_should_propagate_errors();
});
});